Title: [187792] trunk/Source/WebCore
- Revision
- 187792
- Author
- [email protected]
- Date
- 2015-08-03 17:48:41 -0700 (Mon, 03 Aug 2015)
Log Message
REGRESSION (r186916): TextIndicators for multiline link previews are unreadable/offset/blank
https://bugs.webkit.org/show_bug.cgi?id=147615
<rdar://problem/22116575>
Reviewed by Dean Jackson.
* page/mac/TextIndicatorWindow.mm:
(-[WebTextIndicatorView initWithFrame:textIndicator:margin:offset:]):
No need to offset by the difference between the text bounding rect and the selection bounding rect,
because the snapshot is now (after r186916) taken of exactly the text bounding rect.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (187791 => 187792)
--- trunk/Source/WebCore/ChangeLog 2015-08-04 00:39:19 UTC (rev 187791)
+++ trunk/Source/WebCore/ChangeLog 2015-08-04 00:48:41 UTC (rev 187792)
@@ -1,3 +1,16 @@
+2015-08-03 Tim Horton <[email protected]>
+
+ REGRESSION (r186916): TextIndicators for multiline link previews are unreadable/offset/blank
+ https://bugs.webkit.org/show_bug.cgi?id=147615
+ <rdar://problem/22116575>
+
+ Reviewed by Dean Jackson.
+
+ * page/mac/TextIndicatorWindow.mm:
+ (-[WebTextIndicatorView initWithFrame:textIndicator:margin:offset:]):
+ No need to offset by the difference between the text bounding rect and the selection bounding rect,
+ because the snapshot is now (after r186916) taken of exactly the text bounding rect.
+
2015-08-03 Matt Rajca <[email protected]>
Media Session: let UI clients query whether a media element is paused
Modified: trunk/Source/WebCore/page/mac/TextIndicatorWindow.mm (187791 => 187792)
--- trunk/Source/WebCore/page/mac/TextIndicatorWindow.mm 2015-08-04 00:39:19 UTC (rev 187791)
+++ trunk/Source/WebCore/page/mac/TextIndicatorWindow.mm 2015-08-04 00:48:41 UTC (rev 187792)
@@ -222,7 +222,6 @@
[textLayer setContents:(id)contentsImage.get()];
FloatRect imageRect = textRect;
- imageRect.move(_textIndicator->textBoundingRectInRootViewCoordinates().location() - _textIndicator->selectionRectInRootViewCoordinates().location());
[textLayer setContentsRect:CGRectMake(imageRect.x() / contentsImageLogicalSize.width(), imageRect.y() / contentsImageLogicalSize.height(), imageRect.width() / contentsImageLogicalSize.width(), imageRect.height() / contentsImageLogicalSize.height())];
[textLayer setContentsGravity:kCAGravityCenter];
[textLayer setContentsScale:_textIndicator->contentImageScaleFactor()];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
