Title: [188055] trunk
- Revision
- 188055
- Author
- commit-qu...@webkit.org
- Date
- 2015-08-06 13:40:35 -0700 (Thu, 06 Aug 2015)
Log Message
AX: AXLoadComplete that comes before AX API access won't fire
https://bugs.webkit.org/show_bug.cgi?id=147737
Patch by Doug Russell <d_russ...@apple.com> on 2015-08-06
Reviewed by Chris Fleizach.
Treat setEnhancedUserInterfaceAccessibility() as AX API access and if true,
enableAccessibility().
Source/WebCore:
Test: accessibility/mac/loaded-notification.html
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):
LayoutTests:
* accessibility/mac/loaded-notification-expected.txt: Added.
* accessibility/mac/loaded-notification.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (188054 => 188055)
--- trunk/LayoutTests/ChangeLog 2015-08-06 20:33:15 UTC (rev 188054)
+++ trunk/LayoutTests/ChangeLog 2015-08-06 20:40:35 UTC (rev 188055)
@@ -1,3 +1,16 @@
+2015-08-06 Doug Russell <d_russ...@apple.com>
+
+ AX: AXLoadComplete that comes before AX API access won't fire
+ https://bugs.webkit.org/show_bug.cgi?id=147737
+
+ Reviewed by Chris Fleizach.
+
+ Treat setEnhancedUserInterfaceAccessibility() as AX API access and if true,
+ enableAccessibility().
+
+ * accessibility/mac/loaded-notification-expected.txt: Added.
+ * accessibility/mac/loaded-notification.html: Added.
+
2015-08-05 Alexey Proskuryakov <a...@apple.com>
Fix TestExpectations lint warnings.
Added: trunk/LayoutTests/accessibility/mac/loaded-notification-expected.txt (0 => 188055)
--- trunk/LayoutTests/accessibility/mac/loaded-notification-expected.txt (rev 0)
+++ trunk/LayoutTests/accessibility/mac/loaded-notification-expected.txt 2015-08-06 20:40:35 UTC (rev 188055)
@@ -0,0 +1,10 @@
+This tests that when enable enhanced accessibility is true and no other accessibility API is called, the load notification will successfully fire.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS addedNotification is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/accessibility/mac/loaded-notification.html (0 => 188055)
--- trunk/LayoutTests/accessibility/mac/loaded-notification.html (rev 0)
+++ trunk/LayoutTests/accessibility/mac/loaded-notification.html 2015-08-06 20:40:35 UTC (rev 188055)
@@ -0,0 +1,34 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src=""
+</head>
+<body id="body">
+
+<p id="description"></p>
+<div id="console"></div>
+<div id="notifications"></div>
+
+<script>
+
+ description("This tests that when enable enhanced accessibility is true and no other accessibility API is called, the load notification will successfully fire.");
+
+ function notifyCallback(element, notification) {
+ if (notification == "AXLoadComplete") {
+ accessibilityController.removeNotificationListener();
+ window.testRunner.notifyDone();
+ }
+ }
+
+ if (window.accessibilityController) {
+ window.testRunner.waitUntilDone();
+ accessibilityController.enableEnhancedAccessibility(true);
+ var addedNotification = accessibilityController.addNotificationListener(notifyCallback);
+ shouldBe("addedNotification", "true");
+ }
+
+</script>
+
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (188054 => 188055)
--- trunk/Source/WebCore/ChangeLog 2015-08-06 20:33:15 UTC (rev 188054)
+++ trunk/Source/WebCore/ChangeLog 2015-08-06 20:40:35 UTC (rev 188055)
@@ -1,3 +1,18 @@
+2015-08-06 Doug Russell <d_russ...@apple.com>
+
+ AX: AXLoadComplete that comes before AX API access won't fire
+ https://bugs.webkit.org/show_bug.cgi?id=147737
+
+ Reviewed by Chris Fleizach.
+
+ Treat setEnhancedUserInterfaceAccessibility() as AX API access and if true,
+ enableAccessibility().
+
+ Test: accessibility/mac/loaded-notification.html
+
+ * accessibility/AXObjectCache.cpp:
+ (WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):
+
2015-08-06 Eric Carlson <eric.carl...@apple.com>
Do not enforce "content-disposition: attachment" sandbox restrictions on a MediaDocument
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (188054 => 188055)
--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2015-08-06 20:33:15 UTC (rev 188054)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2015-08-06 20:40:35 UTC (rev 188055)
@@ -129,6 +129,8 @@
void AXObjectCache::setEnhancedUserInterfaceAccessibility(bool flag)
{
gAccessibilityEnhancedUserInterfaceEnabled = flag;
+ if (flag)
+ enableAccessibility();
}
AXObjectCache::AXObjectCache(Document& document)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
