Title: [188057] trunk/Source/WebCore
- Revision
- 188057
- Author
- mmaxfi...@apple.com
- Date
- 2015-08-06 13:53:33 -0700 (Thu, 06 Aug 2015)
Log Message
Add comment to CSSParserString
https://bugs.webkit.org/show_bug.cgi?id=147724
Reviewed by Dean Jackson.
No new tests because there is no behavior change.
* css/CSSParserValues.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (188056 => 188057)
--- trunk/Source/WebCore/ChangeLog 2015-08-06 20:45:50 UTC (rev 188056)
+++ trunk/Source/WebCore/ChangeLog 2015-08-06 20:53:33 UTC (rev 188057)
@@ -1,5 +1,16 @@
2015-08-06 Myles C. Maxfield <mmaxfi...@apple.com>
+ Add comment to CSSParserString
+ https://bugs.webkit.org/show_bug.cgi?id=147724
+
+ Reviewed by Dean Jackson.
+
+ No new tests because there is no behavior change.
+
+ * css/CSSParserValues.h:
+
+2015-08-06 Myles C. Maxfield <mmaxfi...@apple.com>
+
Font feature settings comparisons are order-dependent and case-dependent
https://bugs.webkit.org/show_bug.cgi?id=147719
Modified: trunk/Source/WebCore/css/CSSParserValues.h (188056 => 188057)
--- trunk/Source/WebCore/css/CSSParserValues.h 2015-08-06 20:45:50 UTC (rev 188056)
+++ trunk/Source/WebCore/css/CSSParserValues.h 2015-08-06 20:53:33 UTC (rev 188057)
@@ -32,6 +32,9 @@
class CSSValue;
class QualifiedName;
+// This can't be a StringView for 2 reasons:
+// 1. lower() clobbers the data we point to.
+// 2. We are an element of a union (in CSSParserValue) so we need to have a trivial destructor.
struct CSSParserString {
void init(LChar* characters, unsigned length)
{
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
