Title: [188230] trunk/Websites/test-results
- Revision
- 188230
- Author
- dburk...@apple.com
- Date
- 2015-08-10 14:35:54 -0700 (Mon, 10 Aug 2015)
Log Message
Fix flakiness dashboard stability and performance issues.
https://bugs.webkit.org/show_bug.cgi?id=147835
Reviewed by Ryosuke Niwa.
* init-database.sql:
* public/.htaccess:
* public/include/json-shared.php:
* public/include/test-results.php:
Modified Paths
Diff
Modified: trunk/Websites/test-results/ChangeLog (188229 => 188230)
--- trunk/Websites/test-results/ChangeLog 2015-08-10 20:56:18 UTC (rev 188229)
+++ trunk/Websites/test-results/ChangeLog 2015-08-10 21:35:54 UTC (rev 188230)
@@ -1,3 +1,15 @@
+2015-08-10 Dana Burkart <dburk...@apple.com>
+
+ Fix flakiness dashboard stability and performance issues.
+ https://bugs.webkit.org/show_bug.cgi?id=147835
+
+ Reviewed by Ryosuke Niwa.
+
+ * init-database.sql:
+ * public/.htaccess:
+ * public/include/json-shared.php:
+ * public/include/test-results.php:
+
2014-01-23 Ryosuke Niwa <rn...@webkit.org>
Upstream changes to json-shared.php from the perf dashboard
@@ -535,7 +547,7 @@
(TestResultsView._createResultCell): Show the test time and the expected result.
(TestResultsView._createTestResultRow): Compute the slowest run and also round time to tenth of second for time
less than 10s or second if it's more than 10s so that the test time will always be shown in two digits.
- Also show the bug number and the latest expected result on the left columns after linkifying the bug numbers.
+ Also show the bug number and the latest expected result on the left columns after linkifying the bug numbers.
(TestResultsView._matchesFailureType): Added. Determines whether results is of a particular failure type.
(TestResultsView._populateBuilderPane):
(TestResultsView.fetchFailingTestsForBuilder): Store the failure type such as flaky, wrongtestexpectations.
@@ -576,4 +588,3 @@
loadTestsFromLocationHash.
(TestResultsView.loadTestsFromLocationHash): Take care of both 'tests' and 'builder' components.
(fetchManifest): Setup the UI to select a builder.
-
Modified: trunk/Websites/test-results/init-database.sql (188229 => 188230)
--- trunk/Websites/test-results/init-database.sql 2015-08-10 20:56:18 UTC (rev 188229)
+++ trunk/Websites/test-results/init-database.sql 2015-08-10 21:35:54 UTC (rev 188230)
@@ -51,7 +51,7 @@
reftest_type varchar(64));
CREATE TABLE results (
- id serial PRIMARY KEY,
+ id bigserial PRIMARY KEY,
test integer REFERENCES tests ON DELETE CASCADE,
build integer REFERENCES builds ON DELETE CASCADE,
expected varchar(64) NOT NULL,
@@ -64,4 +64,4 @@
CREATE INDEX results_build ON results(build);
CREATE INDEX results_is_flaky ON results(is_flaky);
-SET work_mem='50MB';
+SET work_mem='1024MB';
Modified: trunk/Websites/test-results/public/.htaccess (188229 => 188230)
--- trunk/Websites/test-results/public/.htaccess 2015-08-10 20:56:18 UTC (rev 188229)
+++ trunk/Websites/test-results/public/.htaccess 2015-08-10 21:35:54 UTC (rev 188230)
@@ -5,4 +5,5 @@
php_value post_max_size 110000000
php_value memory_limit 120000000
php_value max_input_time 60
+php_value max_execution_time 240
</IfModule>
Modified: trunk/Websites/test-results/public/include/json-shared.php (188229 => 188230)
--- trunk/Websites/test-results/public/include/json-shared.php 2015-08-10 20:56:18 UTC (rev 188229)
+++ trunk/Websites/test-results/public/include/json-shared.php 2015-08-10 21:35:54 UTC (rev 188230)
@@ -1,4 +1,5 @@
<?php
+ini_set('memory_limit','1024M');
require_once('db.php');
Modified: trunk/Websites/test-results/public/include/test-results.php (188229 => 188230)
--- trunk/Websites/test-results/public/include/test-results.php 2015-08-10 20:56:18 UTC (rev 188229)
+++ trunk/Websites/test-results/public/include/test-results.php 2015-08-10 21:35:54 UTC (rev 188230)
@@ -1,4 +1,5 @@
<?php
+ini_set('memory_limit', '1024M');
require_once('db.php');
@@ -67,7 +68,7 @@
require_format('test_time', $tests['time'], '/^\d*$/');
$modifiers = array_get($tests, 'modifiers');
if ($modifiers)
- require_format('test_modifiers', $modifiers, '/^[A-Za-z0-9 \.\/]+$/');
+ require_format('test_modifiers', $modifiers, '/^[A-Za-z0-9 \.\/\+]+$/');
else
$modifiers = NULL;
$category = 'LayoutTest'; // FIXME: Support other test categories.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
