- Revision
- 188304
- Author
- [email protected]
- Date
- 2015-08-11 15:47:30 -0700 (Tue, 11 Aug 2015)
Log Message
Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
for internalTrac.
https://bugs.webkit.org/show_bug.cgi?id=147805
Patch by Jason Marcell <[email protected]> on 2015-08-11
Reviewed by Daniel Bates.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
Dashboard.Repository.Internal.trac for internalTrac.
(BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
respectively.
(BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
(BuildbotQueueView.prototype.revisionContentForIteration): Substituted
Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
internalTrac.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
(Analyzer): Ditto.
(Analyzer.prototype.analyze): Ditto.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js (188303 => 188304)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2015-08-11 22:43:08 UTC (rev 188303)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2015-08-11 22:47:30 UTC (rev 188304)
@@ -38,9 +38,9 @@
queue.addEventListener(BuildbotQueue.Event.UnauthorizedAccess, this._unauthorizedAccess, this);
}.bind(this));
- webkitTrac.addEventListener(Trac.Event.CommitsUpdated, this._newCommitsRecorded, this);
- if (typeof internalTrac != "undefined")
- internalTrac.addEventListener(Trac.Event.CommitsUpdated, this._newCommitsRecorded, this);
+ Dashboard.Repository.OpenSource.trac.addEventListener(Trac.Event.CommitsUpdated, this._newCommitsRecorded, this);
+ if (typeof Dashboard.Repository.Internal.trac != "undefined")
+ Dashboard.Repository.Internal.trac.addEventListener(Trac.Event.CommitsUpdated, this._newCommitsRecorded, this);
};
BaseObject.addConstructorFunctions(BuildbotQueueView);
@@ -76,6 +76,8 @@
if (!latestProductiveIteration)
return;
+ var webkitTrac = Dashboard.Repository.OpenSource.trac;
+ var internalTrac = Dashboard.Repository.Internal.trac;
var latestRecordedOpenSourceRevisionNumber = webkitTrac.latestRecordedRevisionNumber;
if (!latestRecordedOpenSourceRevisionNumber || webkitTrac.oldestRecordedRevisionNumber > latestProductiveIteration.revision[Dashboard.Repository.OpenSource.name]) {
webkitTrac.loadMoreHistoricalData();
@@ -153,6 +155,8 @@
var content = document.createElement("div");
content.className = "commit-history-popover";
+ var webkitTrac = Dashboard.Repository.OpenSource.trac;
+ var internalTrac = Dashboard.Repository.Internal.trac;
var linesForOpenSource = this._popoverLinesForCommitRange(webkitTrac, queue.branch.openSource, latestProductiveIteration.revision[Dashboard.Repository.OpenSource.name] + 1, webkitTrac.latestRecordedRevisionNumber);
for (var i = 0; i != linesForOpenSource.length; ++i)
content.appendChild(linesForOpenSource[i]);
@@ -262,12 +266,14 @@
{
console.assert(iteration.revision[Dashboard.Repository.OpenSource.name]);
- var openSourceContent = this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration, Dashboard.Repository.OpenSource.name, webkitTrac);
+ var openSourceContent = this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration,
+ Dashboard.Repository.OpenSource.name, Dashboard.Repository.OpenSource.trac);
if (!iteration.revision[Dashboard.Repository.Internal.name])
return openSourceContent;
- var internalContent = this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration, Dashboard.Repository.Internal.name, internalTrac);
+ var internalContent = this._revisionContentWithPopoverForIteration(iteration, previousDisplayedIteration,
+ Dashboard.Repository.Internal.name, Dashboard.Repository.Internal.trac);
var fragment = document.createDocumentFragment();
fragment.appendChild(openSourceContent);
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js (188303 => 188304)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js 2015-08-11 22:43:08 UTC (rev 188303)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js 2015-08-11 22:47:30 UTC (rev 188304)
@@ -25,7 +25,7 @@
var settings = new Settings;
var buildbots = [ new WebKitBuildbot ];
-var webkitTrac = new Trac("https://trac.webkit.org/");
+Dashboard.Repository.OpenSource.trac = new Trac("https://trac.webkit.org/");
if (typeof Bugzilla !== "undefined")
var bugzilla = new Bugzilla;
if (typeof BubbleQueueServer !== "undefined")
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js (188303 => 188304)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js 2015-08-11 22:43:08 UTC (rev 188303)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js 2015-08-11 22:47:30 UTC (rev 188304)
@@ -296,8 +296,8 @@
}
}
-webkitTrac.startPeriodicUpdates();
-if (typeof internalTrac !== "undefined")
- internalTrac.startPeriodicUpdates();
+Dashboard.Repository.OpenSource.trac.startPeriodicUpdates();
+if (typeof Dashboard.Repository.Internal.trac !== "undefined")
+ Dashboard.Repository.Internal.trac.startPeriodicUpdates();
document.addEventListener("DOMContentLoaded", documentReady);
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js (188303 => 188304)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js 2015-08-11 22:43:08 UTC (rev 188303)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js 2015-08-11 22:47:30 UTC (rev 188304)
@@ -30,7 +30,7 @@
// Only load one queue at a time to not overload the server.
this._queueBeingLoaded = null;
- webkitTrac.addEventListener(Trac.Event.Loaded, this._loadedFromTrac, this);
+ Dashboard.Repository.OpenSource.trac.addEventListener(Trac.Event.Loaded, this._loadedFromTrac, this);
};
BaseObject.addConstructorFunctions(Analyzer);
@@ -77,7 +77,7 @@
this._queuesReadyToAnalyze.push(queue);
}, this);
- webkitTrac.load(this._rangeStartTime, this._rangeEndTime);
+ Dashboard.Repository.OpenSource.trac.load(this._rangeStartTime, this._rangeEndTime);
bubbleQueueServer.loadProcessingTimes(this._rangeStartTime, this._rangeEndTime, this._loadedBubblesTiming.bind(this));
},
@@ -264,7 +264,7 @@
var worstTimeRevision;
var worstOwnTimeRevision;
- webkitTrac.recordedCommits.forEach(function(revision) {
+ Dashboard.Repository.OpenSource.trac.recordedCommits.forEach(function(revision) {
if (revision.date < this._rangeStartTime || revision.date >= this._rangeEndTime)
return;
Modified: trunk/Tools/ChangeLog (188303 => 188304)
--- trunk/Tools/ChangeLog 2015-08-11 22:43:08 UTC (rev 188303)
+++ trunk/Tools/ChangeLog 2015-08-11 22:47:30 UTC (rev 188304)
@@ -1,3 +1,27 @@
+2015-08-11 Jason Marcell <[email protected]>
+
+ Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
+ for internalTrac.
+ https://bugs.webkit.org/show_bug.cgi?id=147805
+
+ Reviewed by Daniel Bates.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
+ (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
+ Dashboard.Repository.Internal.trac for internalTrac.
+ (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
+ and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
+ respectively.
+ (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
+ (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
+ Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
+ internalTrac.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
+ (Analyzer): Ditto.
+ (Analyzer.prototype.analyze): Ditto.
+
2015-08-11 Filip Pizlo <[email protected]>
Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
