[webkit-changes] [188309] trunk/Tools

Tue, 11 Aug 2015 16:24:01 -0700

Title: [188309] trunk/Tools
Revision
188309
Author
[email protected]
Date
2015-08-11 16:23:16 -0700 (Tue, 11 Aug 2015)

Log Message

Fix names of Lock tests: should be "Contended", not "Contented".
https://bugs.webkit.org/show_bug.cgi?id=147905

Reviewed by Saam Barati.

We're testing the behavior of lock contention (i.e. when threads contend), not
whether the locks are happy (contented).

* Scripts/run-gtk-tests:
(TestRunner):
(TestRunner.__init__): Deleted.
* TestWebKitAPI/Tests/WTF/Lock.cpp:
(TestWebKitAPI::runLockTest):
(TestWebKitAPI::TEST):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (188308 => 188309)


--- trunk/Tools/ChangeLog	2015-08-11 23:17:03 UTC (rev 188308)
+++ trunk/Tools/ChangeLog	2015-08-11 23:23:16 UTC (rev 188309)
@@ -1,3 +1,20 @@
+2015-08-11  Mark Lam  <[email protected]>
+
+        Fix names of Lock tests: should be "Contended", not "Contented".
+        https://bugs.webkit.org/show_bug.cgi?id=147905
+
+        Reviewed by Saam Barati.
+
+        We're testing the behavior of lock contention (i.e. when threads contend), not
+        whether the locks are happy (contented).
+
+        * Scripts/run-gtk-tests:
+        (TestRunner):
+        (TestRunner.__init__): Deleted.
+        * TestWebKitAPI/Tests/WTF/Lock.cpp:
+        (TestWebKitAPI::runLockTest):
+        (TestWebKitAPI::TEST):
+
 2015-08-11  Alex Christensen  <[email protected]>
 
         Update WinCairoRequirements to VS2015.

Modified: trunk/Tools/Scripts/run-gtk-tests (188308 => 188309)


--- trunk/Tools/Scripts/run-gtk-tests	2015-08-11 23:17:03 UTC (rev 188308)
+++ trunk/Tools/Scripts/run-gtk-tests	2015-08-11 23:23:16 UTC (rev 188309)
@@ -81,7 +81,7 @@
     ]
 
     SLOW = [
-        "WTF_Lock.ContentedShortSection",
+        "WTF_Lock.ContendedShortSection",
     ]
 
     def __init__(self, options, tests=[]):

Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Lock.cpp (188308 => 188309)


--- trunk/Tools/TestWebKitAPI/Tests/WTF/Lock.cpp	2015-08-11 23:17:03 UTC (rev 188308)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/Lock.cpp	2015-08-11 23:23:16 UTC (rev 188309)
@@ -68,62 +68,62 @@
         EXPECT_EQ(expected, words[threadGroupIndex]);
 }
 
-TEST(WTF_Lock, UncontentedShortSection)
+TEST(WTF_Lock, UncontendedShortSection)
 {
     runLockTest<Lock>(1, 1, 1, 10000000);
 }
 
-TEST(WTF_Lock, UncontentedLongSection)
+TEST(WTF_Lock, UncontendedLongSection)
 {
     runLockTest<Lock>(1, 1, 10000, 1000);
 }
 
-TEST(WTF_Lock, ContentedShortSection)
+TEST(WTF_Lock, ContendedShortSection)
 {
     runLockTest<Lock>(1, 10, 1, 10000000);
 }
 
-TEST(WTF_Lock, ContentedLongSection)
+TEST(WTF_Lock, ContendedLongSection)
 {
     runLockTest<Lock>(1, 10, 10000, 10000);
 }
 
-TEST(WTF_Lock, ManyContentedShortSections)
+TEST(WTF_Lock, ManyContendedShortSections)
 {
     runLockTest<Lock>(10, 10, 1, 500000);
 }
 
-TEST(WTF_Lock, ManyContentedLongSections)
+TEST(WTF_Lock, ManyContendedLongSections)
 {
     runLockTest<Lock>(10, 10, 10000, 1000);
 }
 
-TEST(WTF_ByteLock, UncontentedShortSection)
+TEST(WTF_ByteLock, UncontendedShortSection)
 {
     runLockTest<ByteLock>(1, 1, 1, 10000000);
 }
 
-TEST(WTF_ByteLock, UncontentedLongSection)
+TEST(WTF_ByteLock, UncontendedLongSection)
 {
     runLockTest<ByteLock>(1, 1, 10000, 1000);
 }
 
-TEST(WTF_ByteLock, ContentedShortSection)
+TEST(WTF_ByteLock, ContendedShortSection)
 {
     runLockTest<ByteLock>(1, 10, 1, 10000000);
 }
 
-TEST(WTF_ByteLock, ContentedLongSection)
+TEST(WTF_ByteLock, ContendedLongSection)
 {
     runLockTest<ByteLock>(1, 10, 10000, 10000);
 }
 
-TEST(WTF_ByteLock, ManyContentedShortSections)
+TEST(WTF_ByteLock, ManyContendedShortSections)
 {
     runLockTest<ByteLock>(10, 10, 1, 500000);
 }
 
-TEST(WTF_ByteLock, ManyContentedLongSections)
+TEST(WTF_ByteLock, ManyContendedLongSections)
 {
     runLockTest<ByteLock>(10, 10, 10000, 1000);
 }

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to