[webkit-changes] [188770] trunk/LayoutTests

Fri, 21 Aug 2015 13:01:12 -0700

Title: [188770] trunk/LayoutTests
Revision
188770
Author
[email protected]
Date
2015-08-21 13:00:48 -0700 (Fri, 21 Aug 2015)

Log Message

AX: Fix accessibility/mac/search-with-frames.html test
https://bugs.webkit.org/show_bug.cgi?id=148313

Patch by Nan Wang <[email protected]> on 2015-08-21
Reviewed by Chris Fleizach.

uiElementForSearchPredicate function needs five parameters for DumpRenderTree.

* accessibility/mac/search-with-frames.html:
* platform/mac/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (188769 => 188770)


--- trunk/LayoutTests/ChangeLog	2015-08-21 19:55:53 UTC (rev 188769)
+++ trunk/LayoutTests/ChangeLog	2015-08-21 20:00:48 UTC (rev 188770)
@@ -1,3 +1,15 @@
+2015-08-21  Nan Wang  <[email protected]>
+
+        AX: Fix accessibility/mac/search-with-frames.html test
+        https://bugs.webkit.org/show_bug.cgi?id=148313
+
+        Reviewed by Chris Fleizach.
+
+        uiElementForSearchPredicate function needs five parameters for DumpRenderTree.
+
+        * accessibility/mac/search-with-frames.html:
+        * platform/mac/TestExpectations:
+
 2015-08-21  Doug Russell  <[email protected]>
 
         AX: Table with CSS that makes a row anonymous can return NULL from cellForColumnAndRow

Modified: trunk/LayoutTests/accessibility/mac/search-with-frames.html (188769 => 188770)


--- trunk/LayoutTests/accessibility/mac/search-with-frames.html	2015-08-21 19:55:53 UTC (rev 188769)
+++ trunk/LayoutTests/accessibility/mac/search-with-frames.html	2015-08-21 20:00:48 UTC (rev 188770)
@@ -45,7 +45,8 @@
           this.contentDocument.childNodes[0].childNodes[1].appendChild(ifrm); 
           if (e.target.id == "frame3") {
              ifrm._onload_ = function() {
-                 runTest();
+                 // runTest() might run on the same call stack and the frame is not actually finished loading.
+                 setTimeout("runTest()", 0);
              };
           }
        };
@@ -65,36 +66,36 @@
 
         // Search for the buttons. This tests searching through the frames.
         searchKey = "AXButtonSearchKey";
-        resultElement = body.uiElementForSearchPredicate("", true, searchKey, "");
+        resultElement = body.uiElementForSearchPredicate("", true, searchKey, "", false);
         shouldBe("resultElement.role", "'AXRole: AXButton'");
         shouldBe("resultElement.title", "'AXTitle: button1'");
 
-        resultElement = body.uiElementForSearchPredicate(resultElement, true, searchKey, "");
+        resultElement = body.uiElementForSearchPredicate(resultElement, true, searchKey, "", false);
         shouldBe("resultElement.role", "'AXRole: AXButton'");
         shouldBe("resultElement.title", "'AXTitle: button2'");
 
-        resultElement = body.uiElementForSearchPredicate(resultElement, true, searchKey, "");
+        resultElement = body.uiElementForSearchPredicate(resultElement, true, searchKey, "", false);
         shouldBe("resultElement.role", "'AXRole: AXButton'");
         shouldBe("resultElement.title", "'AXTitle: button3'");
 
         // Now search backwards.
-        resultElement = body.uiElementForSearchPredicate(resultElement, false, searchKey, "");
+        resultElement = body.uiElementForSearchPredicate(resultElement, false, searchKey, "", false);
         shouldBe("resultElement.role", "'AXRole: AXButton'");
         shouldBe("resultElement.title", "'AXTitle: button2'");
 
         // Search for the frames. First one is frame1
         searchKey = "AXFrameSearchKey";
-        resultElement = body.uiElementForSearchPredicate("", true, searchKey, "");
+        resultElement = body.uiElementForSearchPredicate("", true, searchKey, "", false);
         shouldBe("resultElement.role", "'AXRole: AXWebArea'");
         shouldBe("resultElement.description", "'AXDescription: frame1'");
 
         // Next we should find the frame inside of frame1.
-        resultElement = body.uiElementForSearchPredicate(resultElement, true, searchKey, "");
+        resultElement = body.uiElementForSearchPredicate(resultElement, true, searchKey, "", false);
         shouldBe("resultElement.role", "'AXRole: AXWebArea'");
         shouldBe("resultElement.description", "'AXDescription: frame1a'");
 
         // Then we should find the frame after frame1.
-        resultElement = body.uiElementForSearchPredicate(resultElement, true, searchKey, "");
+        resultElement = body.uiElementForSearchPredicate(resultElement, true, searchKey, "", false);
         shouldBe("resultElement.role", "'AXRole: AXWebArea'");
         shouldBe("resultElement.description", "'AXDescription: frame2'");
     }

Modified: trunk/LayoutTests/platform/mac/TestExpectations (188769 => 188770)


--- trunk/LayoutTests/platform/mac/TestExpectations	2015-08-21 19:55:53 UTC (rev 188769)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2015-08-21 20:00:48 UTC (rev 188770)
@@ -485,8 +485,6 @@
 http/tests/misc/willCacheResponse-delegate-callback.html [ Failure ]
 http/tests/xmlhttprequest/basic-auth-nopassword.html [ Failure ]
 
-accessibility/mac/search-with-frames.html [ Pass Failure ]
-
 # --- Plugins ---
 # WebKit1 OOP plug-ins: Can't evaluate _javascript_ from NPP_Destroy.
 plugins/document-open.html

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to