Title: [189010] trunk/Source/WebKit2
- Revision
- 189010
- Author
- commit-qu...@webkit.org
- Date
- 2015-08-26 20:32:12 -0700 (Wed, 26 Aug 2015)
Log Message
[ThreadedCompositor] Use WTF::Condition together with WTF::Lock
https://bugs.webkit.org/show_bug.cgi?id=148493
Patch by Emanuele Aina <emanuele.a...@collabora.com> on 2015-08-26
Reviewed by Gyuyoung Kim.
* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
Replace ThreadCondition::signal() calls with Condition::notifyOne().
* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
Replace ThreadCondition usage with Condition.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (189009 => 189010)
--- trunk/Source/WebKit2/ChangeLog 2015-08-27 02:49:52 UTC (rev 189009)
+++ trunk/Source/WebKit2/ChangeLog 2015-08-27 03:32:12 UTC (rev 189010)
@@ -1,3 +1,15 @@
+2015-08-26 Emanuele Aina <emanuele.a...@collabora.com>
+
+ [ThreadedCompositor] Use WTF::Condition together with WTF::Lock
+ https://bugs.webkit.org/show_bug.cgi?id=148493
+
+ Reviewed by Gyuyoung Kim.
+
+ * Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
+ Replace ThreadCondition::signal() calls with Condition::notifyOne().
+ * Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
+ Replace ThreadCondition usage with Condition.
+
2015-08-26 Wenson Hsieh <wenson_hs...@apple.com>
Fix crash due to animationDidEnd called on deallocated RemoteLayerTreeHost
Modified: trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp (189009 => 189010)
--- trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp 2015-08-27 02:49:52 UTC (rev 189009)
+++ trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp 2015-08-27 03:32:12 UTC (rev 189010)
@@ -312,7 +312,7 @@
m_scene = adoptRef(new CoordinatedGraphicsScene(this));
m_viewportController = std::make_unique<SimpleViewportController>(this);
- m_initializeRunLoopCondition.signal();
+ m_initializeRunLoopCondition.notifyOne();
}
m_compositingRunLoop->runLoop().run();
@@ -324,7 +324,7 @@
LockHolder locker(m_terminateRunLoopConditionMutex);
m_compositingRunLoop = nullptr;
m_context = nullptr;
- m_terminateRunLoopCondition.signal();
+ m_terminateRunLoopCondition.notifyOne();
}
detachThread(m_threadIdentifier);
Modified: trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h (189009 => 189010)
--- trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h 2015-08-27 02:49:52 UTC (rev 189009)
+++ trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h 2015-08-27 03:32:12 UTC (rev 189010)
@@ -33,6 +33,7 @@
#include <WebCore/GLContext.h>
#include <WebCore/IntSize.h>
#include <WebCore/TransformationMatrix.h>
+#include <wtf/Condition.h>
#include <wtf/FastMalloc.h>
#include <wtf/Noncopyable.h>
#include <wtf/ThreadSafeRefCounted.h>
@@ -110,9 +111,9 @@
std::unique_ptr<CompositingRunLoop> m_compositingRunLoop;
ThreadIdentifier m_threadIdentifier;
- ThreadCondition m_initializeRunLoopCondition;
+ Condition m_initializeRunLoopCondition;
Lock m_initializeRunLoopConditionMutex;
- ThreadCondition m_terminateRunLoopCondition;
+ Condition m_terminateRunLoopCondition;
Lock m_terminateRunLoopConditionMutex;
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
