Title: [189205] trunk
Revision
189205
Author
[email protected]
Date
2015-08-31 22:23:27 -0700 (Mon, 31 Aug 2015)

Log Message

Unreviewed, rolling out r189198.
https://bugs.webkit.org/show_bug.cgi?id=148670

"Caused http/tests/navigation/anchor-frames-same-origin.html
to fail on WebKit1" (Requested by cdumez on #webkit).

Reverted changeset:

"http/tests/w3c/dom/nodes/Element-matches.html is flaky"
https://bugs.webkit.org/show_bug.cgi?id=148615
http://trac.webkit.org/changeset/189198

Patch by Commit Queue <[email protected]> on 2015-08-31

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (189204 => 189205)


--- trunk/LayoutTests/ChangeLog	2015-09-01 05:08:48 UTC (rev 189204)
+++ trunk/LayoutTests/ChangeLog	2015-09-01 05:23:27 UTC (rev 189205)
@@ -1,3 +1,17 @@
+2015-08-31  Commit Queue  <[email protected]>
+
+        Unreviewed, rolling out r189198.
+        https://bugs.webkit.org/show_bug.cgi?id=148670
+
+        "Caused http/tests/navigation/anchor-frames-same-origin.html
+        to fail on WebKit1" (Requested by cdumez on #webkit).
+
+        Reverted changeset:
+
+        "http/tests/w3c/dom/nodes/Element-matches.html is flaky"
+        https://bugs.webkit.org/show_bug.cgi?id=148615
+        http://trac.webkit.org/changeset/189198
+
 2015-08-31  Alexey Proskuryakov  <[email protected]>
 
         Remove shadow DOM tests

Modified: trunk/LayoutTests/TestExpectations (189204 => 189205)


--- trunk/LayoutTests/TestExpectations	2015-09-01 05:08:48 UTC (rev 189204)
+++ trunk/LayoutTests/TestExpectations	2015-09-01 05:23:27 UTC (rev 189205)
@@ -222,6 +222,10 @@
 webkit.org/b/148546 [ Debug ] http/tests/w3c/dom/ranges/Range-mutations.html [ Skip ]
 webkit.org/b/148546 [ Debug ] http/tests/w3c/dom/ranges/Range-set.html [ Skip ]
 
+# Newly imported W3C DOM tests that are flaky.
+webkit.org/b/148615 http/tests/w3c/dom/nodes/Element-matches.html [ Failure Pass ]
+webkit.org/b/148638 http/tests/w3c/dom/nodes/ParentNode-querySelector-All-xhtml.xhtml [ Failure Pass ]
+
 # @supports W3C Failures
 webkit.org/b/137566 css3/conditional/w3c/at-supports-010.html [ ImageOnlyFailure ]
 webkit.org/b/137568 css3/conditional/w3c/at-supports-014.html [ ImageOnlyFailure ]

Modified: trunk/LayoutTests/http/tests/w3c/dom/nodes/Element-matches-expected.txt (189204 => 189205)


--- trunk/LayoutTests/http/tests/w3c/dom/nodes/Element-matches-expected.txt	2015-09-01 05:08:48 UTC (rev 189204)
+++ trunk/LayoutTests/http/tests/w3c/dom/nodes/Element-matches-expected.txt	2015-09-01 05:23:27 UTC (rev 189205)
@@ -171,7 +171,7 @@
 PASS In-document Element.matches: :empty pseudo-class selector, matching all empty elements (with no refNodes): #pseudo-empty :empty 
 PASS In-document Element.matches: :link and :visited pseudo-class selectors, matching a and area elements with href attributes (with no refNodes): #pseudo-link :link, #pseudo-link :visited 
 PASS In-document Element.matches: :link and :visited pseudo-class selectors, matching link elements with href attributes (with no refNodes): #head :link, #head :visited 
-PASS In-document Element.matches: :target pseudo-class selector, matching the element referenced by the URL fragment identifier (with no refNodes): :target 
+FAIL In-document Element.matches: :target pseudo-class selector, matching the element referenced by the URL fragment identifier (with no refNodes): :target assert_true: The element #target should match the selector. expected true got false
 PASS In-document Element.matches: :lang pseudo-class selector, matching inherited language (with no refNodes): #pseudo-lang-div1:lang(en) 
 PASS In-document Element.matches: :lang pseudo-class selector, matching specified language with exact value (with no refNodes): #pseudo-lang-div2:lang(fr) 
 PASS In-document Element.matches: :lang pseudo-class selector, matching specified language with partial value (with no refNodes): #pseudo-lang-div3:lang(en) 

Modified: trunk/LayoutTests/http/tests/w3c/dom/nodes/ParentNode-querySelector-All-expected.txt (189204 => 189205)


--- trunk/LayoutTests/http/tests/w3c/dom/nodes/ParentNode-querySelector-All-expected.txt	2015-09-01 05:08:48 UTC (rev 189204)
+++ trunk/LayoutTests/http/tests/w3c/dom/nodes/ParentNode-querySelector-All-expected.txt	2015-09-01 05:23:27 UTC (rev 189205)
@@ -553,8 +553,8 @@
 PASS Document.querySelector: :link and :visited pseudo-class selectors, matching a and area elements with href attributes: #pseudo-link :link, #pseudo-link :visited 
 PASS Document.querySelectorAll: :link and :visited pseudo-class selectors, matching link elements with href attributes: #head :link, #head :visited 
 PASS Document.querySelector: :link and :visited pseudo-class selectors, matching link elements with href attributes: #head :link, #head :visited 
-PASS Document.querySelectorAll: :target pseudo-class selector, matching the element referenced by the URL fragment identifier: :target 
-PASS Document.querySelector: :target pseudo-class selector, matching the element referenced by the URL fragment identifier: :target 
+FAIL Document.querySelectorAll: :target pseudo-class selector, matching the element referenced by the URL fragment identifier: :target assert_equals: The method should return the expected number of matches. expected 1 but got 0
+FAIL Document.querySelector: :target pseudo-class selector, matching the element referenced by the URL fragment identifier: :target assert_not_equals: The method should return a match. got disallowed value null
 PASS Document.querySelectorAll: :lang pseudo-class selector, matching inherited language: #pseudo-lang-div1:lang(en) 
 PASS Document.querySelector: :lang pseudo-class selector, matching inherited language: #pseudo-lang-div1:lang(en) 
 PASS Document.querySelectorAll: :lang pseudo-class selector, matching specified language with exact value: #pseudo-lang-div2:lang(fr) 
@@ -1803,8 +1803,8 @@
 PASS In-document Element.querySelector: :link and :visited pseudo-class selectors, not matching link elements with href attributes: #head :link, #head :visited 
 PASS In-document Element.querySelectorAll: :link and :visited pseudo-class selectors, chained, mutually exclusive pseudo-classes match nothing: :link:visited 
 PASS In-document Element.querySelector: :link and :visited pseudo-class selectors, chained, mutually exclusive pseudo-classes match nothing: :link:visited 
-PASS In-document Element.querySelectorAll: :target pseudo-class selector, matching the element referenced by the URL fragment identifier: :target 
-PASS In-document Element.querySelector: :target pseudo-class selector, matching the element referenced by the URL fragment identifier: :target 
+FAIL In-document Element.querySelectorAll: :target pseudo-class selector, matching the element referenced by the URL fragment identifier: :target assert_equals: The method should return the expected number of matches. expected 1 but got 0
+FAIL In-document Element.querySelector: :target pseudo-class selector, matching the element referenced by the URL fragment identifier: :target assert_not_equals: The method should return a match. got disallowed value null
 PASS In-document Element.querySelectorAll: :lang pseudo-class selector, matching inherited language: #pseudo-lang-div1:lang(en) 
 PASS In-document Element.querySelector: :lang pseudo-class selector, matching inherited language: #pseudo-lang-div1:lang(en) 
 PASS In-document Element.querySelectorAll: :lang pseudo-class selector, matching specified language with exact value: #pseudo-lang-div2:lang(fr) 

Modified: trunk/LayoutTests/http/tests/w3c/dom/nodes/ParentNode-querySelector-All-xhtml-expected.txt (189204 => 189205)


--- trunk/LayoutTests/http/tests/w3c/dom/nodes/ParentNode-querySelector-All-xhtml-expected.txt	2015-09-01 05:08:48 UTC (rev 189204)
+++ trunk/LayoutTests/http/tests/w3c/dom/nodes/ParentNode-querySelector-All-xhtml-expected.txt	2015-09-01 05:23:27 UTC (rev 189205)
@@ -553,8 +553,8 @@
 PASS Document.querySelector: :link and :visited pseudo-class selectors, matching a and area elements with href attributes: #pseudo-link :link, #pseudo-link :visited 
 PASS Document.querySelectorAll: :link and :visited pseudo-class selectors, matching link elements with href attributes: #head :link, #head :visited 
 PASS Document.querySelector: :link and :visited pseudo-class selectors, matching link elements with href attributes: #head :link, #head :visited 
-PASS Document.querySelectorAll: :target pseudo-class selector, matching the element referenced by the URL fragment identifier: :target 
-PASS Document.querySelector: :target pseudo-class selector, matching the element referenced by the URL fragment identifier: :target 
+FAIL Document.querySelectorAll: :target pseudo-class selector, matching the element referenced by the URL fragment identifier: :target assert_equals: The method should return the expected number of matches. expected 1 but got 0
+FAIL Document.querySelector: :target pseudo-class selector, matching the element referenced by the URL fragment identifier: :target assert_not_equals: The method should return a match. got disallowed value null
 PASS Document.querySelectorAll: :lang pseudo-class selector, matching inherited language: #pseudo-lang-div1:lang(en) 
 PASS Document.querySelector: :lang pseudo-class selector, matching inherited language: #pseudo-lang-div1:lang(en) 
 PASS Document.querySelectorAll: :lang pseudo-class selector, matching specified language with exact value: #pseudo-lang-div2:lang(fr) 
@@ -1803,8 +1803,8 @@
 PASS In-document Element.querySelector: :link and :visited pseudo-class selectors, not matching link elements with href attributes: #head :link, #head :visited 
 PASS In-document Element.querySelectorAll: :link and :visited pseudo-class selectors, chained, mutually exclusive pseudo-classes match nothing: :link:visited 
 PASS In-document Element.querySelector: :link and :visited pseudo-class selectors, chained, mutually exclusive pseudo-classes match nothing: :link:visited 
-PASS In-document Element.querySelectorAll: :target pseudo-class selector, matching the element referenced by the URL fragment identifier: :target 
-PASS In-document Element.querySelector: :target pseudo-class selector, matching the element referenced by the URL fragment identifier: :target 
+FAIL In-document Element.querySelectorAll: :target pseudo-class selector, matching the element referenced by the URL fragment identifier: :target assert_equals: The method should return the expected number of matches. expected 1 but got 0
+FAIL In-document Element.querySelector: :target pseudo-class selector, matching the element referenced by the URL fragment identifier: :target assert_not_equals: The method should return a match. got disallowed value null
 PASS In-document Element.querySelectorAll: :lang pseudo-class selector, matching inherited language: #pseudo-lang-div1:lang(en) 
 PASS In-document Element.querySelector: :lang pseudo-class selector, matching inherited language: #pseudo-lang-div1:lang(en) 
 PASS In-document Element.querySelectorAll: :lang pseudo-class selector, matching specified language with exact value: #pseudo-lang-div2:lang(fr) 

Modified: trunk/Source/WebCore/ChangeLog (189204 => 189205)


--- trunk/Source/WebCore/ChangeLog	2015-09-01 05:08:48 UTC (rev 189204)
+++ trunk/Source/WebCore/ChangeLog	2015-09-01 05:23:27 UTC (rev 189205)
@@ -1,3 +1,17 @@
+2015-08-31  Commit Queue  <[email protected]>
+
+        Unreviewed, rolling out r189198.
+        https://bugs.webkit.org/show_bug.cgi?id=148670
+
+        "Caused http/tests/navigation/anchor-frames-same-origin.html
+        to fail on WebKit1" (Requested by cdumez on #webkit).
+
+        Reverted changeset:
+
+        "http/tests/w3c/dom/nodes/Element-matches.html is flaky"
+        https://bugs.webkit.org/show_bug.cgi?id=148615
+        http://trac.webkit.org/changeset/189198
+
 2015-08-31  Joseph Pecoraro  <[email protected]>
 
         Remove unused #define

Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (189204 => 189205)


--- trunk/Source/WebCore/loader/FrameLoader.cpp	2015-09-01 05:08:48 UTC (rev 189204)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp	2015-09-01 05:23:27 UTC (rev 189205)
@@ -753,8 +753,6 @@
 
     m_client.dispatchDidFinishDocumentLoad();
 
-    scrollToFragmentWithParentBoundary(m_frame.document()->url());
-
     checkCompleted();
 
     if (!m_frame.view())
@@ -763,6 +761,7 @@
     // Check if the scrollbars are really needed for the content.
     // If not, remove them, relayout, and repaint.
     m_frame.view()->restoreScrollbar();
+    scrollToFragmentWithParentBoundary(m_frame.document()->url());
 }
 
 void FrameLoader::loadDone()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to