Title: [189360] trunk/Source/_javascript_Core
Revision
189360
Author
[email protected]
Date
2015-09-04 11:14:58 -0700 (Fri, 04 Sep 2015)

Log Message

Remove some unused functions from MarkedBlock and MarkedSpace.
<https://webkit.org/b/148748>

Reviewed by Darin Adler.

* ftl/FTLAbstractHeapRepository.h:
* heap/MarkedBlock.h:
(JSC::MarkedBlock::offsetOfMarks): Deleted.
(JSC::MarkedBlock::didConsumeEmptyFreeList): Deleted.
* heap/MarkedSpace.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (189359 => 189360)


--- trunk/Source/_javascript_Core/ChangeLog	2015-09-04 18:12:21 UTC (rev 189359)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-09-04 18:14:58 UTC (rev 189360)
@@ -1,3 +1,16 @@
+2015-09-04  Andreas Kling  <[email protected]>
+
+        Remove some unused functions from MarkedBlock and MarkedSpace.
+        <https://webkit.org/b/148748>
+
+        Reviewed by Darin Adler.
+
+        * ftl/FTLAbstractHeapRepository.h:
+        * heap/MarkedBlock.h:
+        (JSC::MarkedBlock::offsetOfMarks): Deleted.
+        (JSC::MarkedBlock::didConsumeEmptyFreeList): Deleted.
+        * heap/MarkedSpace.h:
+
 2015-09-04  Basile Clement  <[email protected]>
 
         Make a bunch of MacroAssembler operations constexpr

Modified: trunk/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h (189359 => 189360)


--- trunk/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h	2015-09-04 18:12:21 UTC (rev 189359)
+++ trunk/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.h	2015-09-04 18:14:58 UTC (rev 189360)
@@ -75,7 +75,6 @@
     macro(JSSymbolTableObject_symbolTable, JSSymbolTableObject::offsetOfSymbolTable()) \
     macro(JSWrapperObject_internalValue, JSWrapperObject::internalValueOffset()) \
     macro(MarkedAllocator_freeListHead, MarkedAllocator::offsetOfFreeListHead()) \
-    macro(MarkedBlock_markBits, MarkedBlock::offsetOfMarks()) \
     macro(ScopedArguments_overrodeThings, ScopedArguments::offsetOfOverrodeThings()) \
     macro(ScopedArguments_scope, ScopedArguments::offsetOfScope()) \
     macro(ScopedArguments_table, ScopedArguments::offsetOfTable()) \

Modified: trunk/Source/_javascript_Core/heap/MarkedBlock.h (189359 => 189360)


--- trunk/Source/_javascript_Core/heap/MarkedBlock.h	2015-09-04 18:12:21 UTC (rev 189359)
+++ trunk/Source/_javascript_Core/heap/MarkedBlock.h	2015-09-04 18:14:58 UTC (rev 189360)
@@ -138,8 +138,6 @@
         void didConsumeFreeList(); // Call this once you've allocated all the items in the free list.
         void stopAllocating(const FreeList&);
         FreeList resumeAllocating(); // Call this if you canonicalized a block for some non-collection related purpose.
-        void didConsumeEmptyFreeList(); // Call this if you sweep a block, but the returned FreeList is empty.
-        void didSweepToNoAvail(); // Call this if you sweep a block and get an empty free list back.
 
         // Returns true if the "newly allocated" bitmap was non-null 
         // and was successfully cleared and false otherwise.
@@ -165,11 +163,6 @@
         void setMarked(const void*);
         void clearMarked(const void*);
 
-        void setRemembered(const void*);
-        void clearRemembered(const void*);
-        void atomicClearRemembered(const void*);
-        bool isRemembered(const void*);
-
         bool isNewlyAllocated(const void*);
         void setNewlyAllocated(const void*);
         void clearNewlyAllocated(const void*);
@@ -183,8 +176,6 @@
         template <typename Functor> IterationStatus forEachLiveCell(Functor&);
         template <typename Functor> IterationStatus forEachDeadCell(Functor&);
 
-        static ptrdiff_t offsetOfMarks() { return OBJECT_OFFSETOF(MarkedBlock, m_marks); }
-
     private:
         static const size_t atomAlignmentMask = atomSize - 1; // atomSize must be a power of two.
 
@@ -298,15 +289,6 @@
         m_state = Allocated;
     }
 
-    inline void MarkedBlock::didConsumeEmptyFreeList()
-    {
-        HEAP_LOG_BLOCK_STATE_TRANSITION(this);
-
-        ASSERT(!m_newlyAllocated);
-        ASSERT(m_state == FreeListed);
-        m_state = Marked;
-    }
-
     inline size_t MarkedBlock::markCount()
     {
         return m_marks.count();

Modified: trunk/Source/_javascript_Core/heap/MarkedSpace.h (189359 => 189360)


--- trunk/Source/_javascript_Core/heap/MarkedSpace.h	2015-09-04 18:12:21 UTC (rev 189359)
+++ trunk/Source/_javascript_Core/heap/MarkedSpace.h	2015-09-04 18:14:58 UTC (rev 189360)
@@ -94,7 +94,6 @@
     ~MarkedSpace();
     void lastChanceToFinalize();
 
-    MarkedAllocator& firstAllocator();
     MarkedAllocator& allocatorFor(size_t);
     MarkedAllocator& destructorAllocatorFor(size_t);
     void* allocateWithDestructor(size_t);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to