[webkit-changes] [190699] trunk/Source/JavaScriptCore

Wed, 07 Oct 2015 17:48:13 -0700

Title: [190699] trunk/Source/_javascript_Core
Revision
190699
Author
mark....@apple.com
Date
2015-10-07 17:47:59 -0700 (Wed, 07 Oct 2015)

Log Message

[Follow up 2] Disable tail calls because it is breaking some sites.
https://bugs.webkit.org/show_bug.cgi?id=149900

Rubber stamped by Saam Barati.

Also need to surpress JSC tail call tests.

* tests/es6.yaml:
* tests/stress/dfg-tail-calls.js:
(nonInlinedTailCall.callee):
* tests/stress/mutual-tail-call-no-stack-overflow.js:
(shouldThrow):
* tests/stress/tail-call-in-inline-cache.js:
(tail):
* tests/stress/tail-call-no-stack-overflow.js:
(shouldThrow):
* tests/stress/tail-call-recognize.js:
(callerMustBeRun):
* tests/stress/tail-call-varargs-no-stack-overflow.js:
(shouldThrow):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (190698 => 190699)


--- trunk/Source/_javascript_Core/ChangeLog	2015-10-08 00:35:57 UTC (rev 190698)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-08 00:47:59 UTC (rev 190699)
@@ -1,3 +1,26 @@
+2015-10-07  Mark Lam  <mark....@apple.com>
+
+        [Follow up 2] Disable tail calls because it is breaking some sites.
+        https://bugs.webkit.org/show_bug.cgi?id=149900
+
+        Rubber stamped by Saam Barati.
+
+        Also need to surpress JSC tail call tests.
+
+        * tests/es6.yaml:
+        * tests/stress/dfg-tail-calls.js:
+        (nonInlinedTailCall.callee):
+        * tests/stress/mutual-tail-call-no-stack-overflow.js:
+        (shouldThrow):
+        * tests/stress/tail-call-in-inline-cache.js:
+        (tail):
+        * tests/stress/tail-call-no-stack-overflow.js:
+        (shouldThrow):
+        * tests/stress/tail-call-recognize.js:
+        (callerMustBeRun):
+        * tests/stress/tail-call-varargs-no-stack-overflow.js:
+        (shouldThrow):
+
 2015-10-07  Geoffrey Garen  <gga...@apple.com>
 
         Unreviewed, rolling back in r190450

Modified: trunk/Source/_javascript_Core/tests/es6.yaml (190698 => 190699)


--- trunk/Source/_javascript_Core/tests/es6.yaml	2015-10-08 00:35:57 UTC (rev 190698)
+++ trunk/Source/_javascript_Core/tests/es6.yaml	2015-10-08 00:47:59 UTC (rev 190699)
@@ -877,9 +877,9 @@
 - path: es6/Promise_Promise[Symbol.species].js
   cmd: runES6 :fail
 - path: es6/proper_tail_calls_tail_call_optimisation_direct_recursion.js
-  cmd: runES6 :normal
+  cmd: runES6 :fail
 - path: es6/proper_tail_calls_tail_call_optimisation_mutual_recursion.js
-  cmd: runES6 :normal
+  cmd: runES6 :fail
 - path: es6/prototype_of_bound_functions_arrow_functions.js
   cmd: runES6 :fail
 - path: es6/prototype_of_bound_functions_basic_functions.js

Modified: trunk/Source/_javascript_Core/tests/stress/dfg-tail-calls.js (190698 => 190699)


--- trunk/Source/_javascript_Core/tests/stress/dfg-tail-calls.js	2015-10-08 00:35:57 UTC (rev 190698)
+++ trunk/Source/_javascript_Core/tests/stress/dfg-tail-calls.js	2015-10-08 00:47:59 UTC (rev 190699)
@@ -1,3 +1,4 @@
+//@ skip
 (function nonInlinedTailCall() {
     function callee() { if (callee.caller != nonInlinedTailCall) throw new Error(); }
     noInline(callee);

Modified: trunk/Source/_javascript_Core/tests/stress/mutual-tail-call-no-stack-overflow.js (190698 => 190699)


--- trunk/Source/_javascript_Core/tests/stress/mutual-tail-call-no-stack-overflow.js	2015-10-08 00:35:57 UTC (rev 190698)
+++ trunk/Source/_javascript_Core/tests/stress/mutual-tail-call-no-stack-overflow.js	2015-10-08 00:47:59 UTC (rev 190699)
@@ -1,3 +1,4 @@
+//@ skip
 function shouldThrow(func, errorMessage) {
     var errorThrown = false;
     var error = null;

Modified: trunk/Source/_javascript_Core/tests/stress/tail-call-in-inline-cache.js (190698 => 190699)


--- trunk/Source/_javascript_Core/tests/stress/tail-call-in-inline-cache.js	2015-10-08 00:35:57 UTC (rev 190698)
+++ trunk/Source/_javascript_Core/tests/stress/tail-call-in-inline-cache.js	2015-10-08 00:47:59 UTC (rev 190699)
@@ -1,3 +1,4 @@
+//@ skip
 "use strict";
 
 function tail() { }

Modified: trunk/Source/_javascript_Core/tests/stress/tail-call-no-stack-overflow.js (190698 => 190699)


--- trunk/Source/_javascript_Core/tests/stress/tail-call-no-stack-overflow.js	2015-10-08 00:35:57 UTC (rev 190698)
+++ trunk/Source/_javascript_Core/tests/stress/tail-call-no-stack-overflow.js	2015-10-08 00:47:59 UTC (rev 190699)
@@ -1,3 +1,4 @@
+//@ skip
 function shouldThrow(func, errorMessage) {
     var errorThrown = false;
     var error = null;

Modified: trunk/Source/_javascript_Core/tests/stress/tail-call-recognize.js (190698 => 190699)


--- trunk/Source/_javascript_Core/tests/stress/tail-call-recognize.js	2015-10-08 00:35:57 UTC (rev 190698)
+++ trunk/Source/_javascript_Core/tests/stress/tail-call-recognize.js	2015-10-08 00:47:59 UTC (rev 190699)
@@ -1,3 +1,4 @@
+//@ skip
 function callerMustBeRun() {
     if (!Object.is(callerMustBeRun.caller, runTests))
         throw Error("Wrong caller, expected run but got ", callerMustBeRun.caller);

Modified: trunk/Source/_javascript_Core/tests/stress/tail-call-varargs-no-stack-overflow.js (190698 => 190699)


--- trunk/Source/_javascript_Core/tests/stress/tail-call-varargs-no-stack-overflow.js	2015-10-08 00:35:57 UTC (rev 190698)
+++ trunk/Source/_javascript_Core/tests/stress/tail-call-varargs-no-stack-overflow.js	2015-10-08 00:47:59 UTC (rev 190699)
@@ -1,3 +1,4 @@
+//@ skip
 function shouldThrow(func, errorMessage) {
     var errorThrown = false;
     var error = null;

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to