Title: [191768] trunk/PerformanceTests
- Revision
- 191768
- Author
- [email protected]
- Date
- 2015-10-29 18:28:23 -0700 (Thu, 29 Oct 2015)
Log Message
Animometer computes frame rate incorrectly
https://bugs.webkit.org/show_bug.cgi?id=150698
Reviewed by Tim Horton.
The existing code incremented this._frameCount after checking against this._dropFrameCount.
This has the effect of setting this._measureTimeOffset one frame too late, so
we were measuring only two frames, not three, and thus computing an incorrect fps.
* Animometer/tests/resources/main.js:
(Animator.prototype.animate):
Modified Paths
Diff
Modified: trunk/PerformanceTests/Animometer/tests/resources/main.js (191767 => 191768)
--- trunk/PerformanceTests/Animometer/tests/resources/main.js 2015-10-30 00:41:39 UTC (rev 191767)
+++ trunk/PerformanceTests/Animometer/tests/resources/main.js 2015-10-30 01:28:23 UTC (rev 191768)
@@ -94,12 +94,12 @@
if (!this._frameCount)
this._startTimeOffset = this._currentTimeOffset;
+ ++this._frameCount;
+
// Start measuring after dropping _dropFrameCount frames.
if (this._frameCount == this._dropFrameCount)
this._measureTimeOffset = this._currentTimeOffset;
- ++this._frameCount;
-
// Drop _dropFrameCount frames and measure the average of _measureFrameCount frames.
if (this._frameCount < this._dropFrameCount + this._measureFrameCount)
return true;
Modified: trunk/PerformanceTests/ChangeLog (191767 => 191768)
--- trunk/PerformanceTests/ChangeLog 2015-10-30 00:41:39 UTC (rev 191767)
+++ trunk/PerformanceTests/ChangeLog 2015-10-30 01:28:23 UTC (rev 191768)
@@ -1,3 +1,17 @@
+2015-10-29 Simon Fraser <[email protected]>
+
+ Animometer computes frame rate incorrectly
+ https://bugs.webkit.org/show_bug.cgi?id=150698
+
+ Reviewed by Tim Horton.
+
+ The existing code incremented this._frameCount after checking against this._dropFrameCount.
+ This has the effect of setting this._measureTimeOffset one frame too late, so
+ we were measuring only two frames, not three, and thus computing an incorrect fps.
+
+ * Animometer/tests/resources/main.js:
+ (Animator.prototype.animate):
+
2015-10-27 Jon Lee <[email protected]>
Add an option to make the graphics benchmark runs a specific test
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
