Title: [191962] trunk/Source/WebKit2
- Revision
- 191962
- Author
- ander...@apple.com
- Date
- 2015-11-03 11:25:52 -0800 (Tue, 03 Nov 2015)
Log Message
Simplify -[_WKRemoteObjectRegistry _invokeMethod:]
https://bugs.webkit.org/show_bug.cgi?id=150844
Reviewed by Tim Horton.
* Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:
(-[_WKRemoteObjectRegistry _invokeMethod:]):
(-[_WKRemoteObjectRegistry _invokeMessageWithInterfaceIdentifier:encodedInvocation:]): Deleted.
* Shared/API/Cocoa/_WKRemoteObjectRegistryInternal.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (191961 => 191962)
--- trunk/Source/WebKit2/ChangeLog 2015-11-03 19:02:45 UTC (rev 191961)
+++ trunk/Source/WebKit2/ChangeLog 2015-11-03 19:25:52 UTC (rev 191962)
@@ -1,3 +1,15 @@
+2015-11-03 Anders Carlsson <ander...@apple.com>
+
+ Simplify -[_WKRemoteObjectRegistry _invokeMethod:]
+ https://bugs.webkit.org/show_bug.cgi?id=150844
+
+ Reviewed by Tim Horton.
+
+ * Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:
+ (-[_WKRemoteObjectRegistry _invokeMethod:]):
+ (-[_WKRemoteObjectRegistry _invokeMessageWithInterfaceIdentifier:encodedInvocation:]): Deleted.
+ * Shared/API/Cocoa/_WKRemoteObjectRegistryInternal.h:
+
2015-11-02 Anders Carlsson <ander...@apple.com>
CTTE the responsiveness timer getter
Modified: trunk/Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectRegistry.mm (191961 => 191962)
--- trunk/Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectRegistry.mm 2015-11-03 19:02:45 UTC (rev 191961)
+++ trunk/Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectRegistry.mm 2015-11-03 19:25:52 UTC (rev 191962)
@@ -148,15 +148,11 @@
return *_remoteObjectRegistry;
}
-- (BOOL)_invokeMethod:(const RemoteObjectInvocation&)invocation
+- (void)_invokeMethod:(const RemoteObjectInvocation&)remoteObjectInvocation
{
- [self _invokeMessageWithInterfaceIdentifier:invocation.interfaceIdentifier() encodedInvocation:invocation.encodedInvocation()];
+ auto& interfaceIdentifier = remoteObjectInvocation.interfaceIdentifier();
+ auto* encodedInvocation = remoteObjectInvocation.encodedInvocation();
- return YES;
-}
-
-- (void)_invokeMessageWithInterfaceIdentifier:(const String&)interfaceIdentifier encodedInvocation:(const API::Dictionary*)encodedInvocation
-{
auto interfaceAndObject = _exportedObjects.get(interfaceIdentifier);
if (!interfaceAndObject.second) {
NSLog(@"Did not find a registered object for the interface \"%@\"", (NSString *)interfaceIdentifier);
Modified: trunk/Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectRegistryInternal.h (191961 => 191962)
--- trunk/Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectRegistryInternal.h 2015-11-03 19:02:45 UTC (rev 191961)
+++ trunk/Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectRegistryInternal.h 2015-11-03 19:25:52 UTC (rev 191962)
@@ -44,7 +44,7 @@
- (void)_invalidate;
- (void)_sendInvocation:(NSInvocation *)invocation interface:(_WKRemoteObjectInterface *)interface;
-- (BOOL)_invokeMethod:(const WebKit::RemoteObjectInvocation&)invocation;
+- (void)_invokeMethod:(const WebKit::RemoteObjectInvocation&)invocation;
@end
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
