Title: [192188] trunk/Source/WebInspectorUI
- Revision
- 192188
- Author
- commit-qu...@webkit.org
- Date
- 2015-11-09 16:30:29 -0800 (Mon, 09 Nov 2015)
Log Message
Web Inspector: Uncaught exception creating TimelineRecord alternate subtitles
https://bugs.webkit.org/show_bug.cgi?id=151046
Patch by Joseph Pecoraro <pecor...@apple.com> on 2015-11-09
Reviewed by Brian Burg.
* UserInterface/Views/TimelineRecordTreeElement.js:
(WebInspector.TimelineRecordTreeElement):
We just need to create an element, it does not need to be
a child of subtitle, as it gets appended to the right
place later on.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (192187 => 192188)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-11-10 00:26:37 UTC (rev 192187)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-11-10 00:30:29 UTC (rev 192188)
@@ -1,3 +1,16 @@
+2015-11-09 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Uncaught exception creating TimelineRecord alternate subtitles
+ https://bugs.webkit.org/show_bug.cgi?id=151046
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/TimelineRecordTreeElement.js:
+ (WebInspector.TimelineRecordTreeElement):
+ We just need to create an element, it does not need to be
+ a child of subtitle, as it gets appended to the right
+ place later on.
+
2015-11-09 Nikita Vasilyev <nvasil...@apple.com>
Web Inspector: [Regression] [Mavericks] Top border of selected tab matches the background when Web Inspector is undocked
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js (192187 => 192188)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js 2015-11-10 00:26:37 UTC (rev 192187)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js 2015-11-10 00:30:29 UTC (rev 192188)
@@ -94,7 +94,7 @@
case WebInspector.ScriptTimelineRecord.EventType.TimerInstalled:
if (includeDetailsInMainTitle) {
let timeoutString = Number.secondsToString(timelineRecord.details.timeout / 1000);
- alternateSubtitle = subtitle.appendChild(document.createElement("span"));
+ alternateSubtitle = document.createElement("span");
alternateSubtitle.classList.add("alternate-subtitle");
if (timelineRecord.details.repeating)
alternateSubtitle.textContent = WebInspector.UIString("%s interval").format(timeoutString);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
