Title: [192985] trunk/Source/_javascript_Core
Revision
192985
Author
commit-qu...@webkit.org
Date
2015-12-02 16:32:13 -0800 (Wed, 02 Dec 2015)

Log Message

[JSC] Remove stuffs related to alloca from FTLB3Output
https://bugs.webkit.org/show_bug.cgi?id=151780

Patch by Benjamin Poulain <bpoul...@apple.com> on 2015-12-02
Reviewed by Mark Lam.

We can use the Phis directly with B3 :)

* ftl/FTLB3Output.h:
(JSC::FTL::Output::alloca): Deleted.
(JSC::FTL::Output::get): Deleted.
(JSC::FTL::Output::set): Deleted.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192984 => 192985)


--- trunk/Source/_javascript_Core/ChangeLog	2015-12-03 00:21:20 UTC (rev 192984)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-12-03 00:32:13 UTC (rev 192985)
@@ -1,3 +1,17 @@
+2015-12-02  Benjamin Poulain  <bpoul...@apple.com>
+
+        [JSC] Remove stuffs related to alloca from FTLB3Output
+        https://bugs.webkit.org/show_bug.cgi?id=151780
+
+        Reviewed by Mark Lam.
+
+        We can use the Phis directly with B3 :)
+
+        * ftl/FTLB3Output.h:
+        (JSC::FTL::Output::alloca): Deleted.
+        (JSC::FTL::Output::get): Deleted.
+        (JSC::FTL::Output::set): Deleted.
+
 2015-12-02  Benjamin Poulain  <benja...@webkit.org>
 
         [JSC] Add sin(), cos(), pow() and log() to B3

Modified: trunk/Source/_javascript_Core/ftl/FTLB3Output.h (192984 => 192985)


--- trunk/Source/_javascript_Core/ftl/FTLB3Output.h	2015-12-03 00:21:20 UTC (rev 192984)
+++ trunk/Source/_javascript_Core/ftl/FTLB3Output.h	2015-12-03 00:32:13 UTC (rev 192985)
@@ -197,20 +197,6 @@
 
     LValue fround(LValue doubleValue) { CRASH(); }
 
-    // Hilariously, the #define machinery in the stdlib means that this method is actually called
-    // __builtin_alloca. So far this appears benign. :-|
-    LValue alloca(LType type) { CRASH(); }
-
-    // Access the value of an alloca. Also used as a low-level implementation primitive for
-    // load(). Never use this to load from "pointers" in the FTL sense, since FTL pointers
-    // are actually integers. This requires an LLVM pointer. Broadly speaking, you don't
-    // have any LLVM pointers even if you really think you do. A TypedPointer is not an
-    // LLVM pointer. See comment block at top of this file to understand the distinction
-    // between LLVM pointers, FTL pointers, and FTL references.
-    LValue get(LValue reference) { CRASH(); }
-    // Similar to get() but for storing to the value in an alloca.
-    LValue set(LValue value, LValue reference) { CRASH(); }
-
     LValue load(TypedPointer, LType);
     void store(LValue, TypedPointer);
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to