Title: [193623] trunk/Tools
Revision
193623
Author
ddkil...@apple.com
Date
2015-12-07 05:49:41 -0800 (Mon, 07 Dec 2015)

Log Message

TestNetscapePlugIn: Address review comment on r193607
<http://webkit.org/b/151881>

* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(testSetStatus): Initializing std::unique_ptr<char[]> with
nullptr is redundant.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (193622 => 193623)


--- trunk/Tools/ChangeLog	2015-12-07 12:36:18 UTC (rev 193622)
+++ trunk/Tools/ChangeLog	2015-12-07 13:49:41 UTC (rev 193623)
@@ -1,3 +1,12 @@
+2015-12-07  David Kilzer  <ddkil...@apple.com>
+
+        TestNetscapePlugIn: Address review comment on 193607
+        <http://webkit.org/b/151881>
+
+        * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
+        (testSetStatus): Initializing std::unique_ptr<char[]> with
+        nullptr is redundant.
+
 2015-12-07  Carlos Garcia Campos  <cgar...@igalia.com>
 
         [GTK] Add webkit_uri_request_get_http_method

Modified: trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp (193622 => 193623)


--- trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp	2015-12-07 12:36:18 UTC (rev 193622)
+++ trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp	2015-12-07 13:49:41 UTC (rev 193623)
@@ -974,7 +974,7 @@
 
 static bool testSetStatus(PluginObject* obj, const NPVariant* args, uint32_t argCount, NPVariant* result)
 {
-    std::unique_ptr<char[]> message(nullptr);
+    std::unique_ptr<char[]> message;
     if (argCount && NPVARIANT_IS_STRING(args[0])) {
         NPString statusString = NPVARIANT_TO_STRING(args[0]);
         message = toCString(statusString);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to