Title: [193651] trunk/Source/WebCore
- Revision
- 193651
- Author
- y...@igalia.com
- Date
- 2015-12-07 14:23:19 -0800 (Mon, 07 Dec 2015)
Log Message
[GTK] Clean up virtual functions in MediaPlayerPrivateGStreamerBase
https://bugs.webkit.org/show_bug.cgi?id=151940
Reviewed by Carlos Garcia Campos.
- Using 'override' when appropriate
- Explicitly marking methods as virtual when they are inherently virtual
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (193650 => 193651)
--- trunk/Source/WebCore/ChangeLog 2015-12-07 22:14:25 UTC (rev 193650)
+++ trunk/Source/WebCore/ChangeLog 2015-12-07 22:23:19 UTC (rev 193651)
@@ -1,3 +1,15 @@
+2015-12-07 Gwang Yoon Hwang <y...@igalia.com>
+
+ [GTK] Clean up virtual functions in MediaPlayerPrivateGStreamerBase
+ https://bugs.webkit.org/show_bug.cgi?id=151940
+
+ Reviewed by Carlos Garcia Campos.
+
+ - Using 'override' when appropriate
+ - Explicitly marking methods as virtual when they are inherently virtual
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
+
2015-12-07 Saam barati <sbar...@apple.com>
Add op_watchdog opcode that is generated when VM has a watchdog
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h (193650 => 193651)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h 2015-12-07 22:14:25 UTC (rev 193650)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h 2015-12-07 22:23:19 UTC (rev 193651)
@@ -56,53 +56,53 @@
public:
virtual ~MediaPlayerPrivateGStreamerBase();
- FloatSize naturalSize() const;
+ virtual FloatSize naturalSize() const override;
- void setVolume(float);
- float volume() const;
+ virtual void setVolume(float) override;
+ virtual float volume() const;
#if USE(GSTREAMER_GL)
bool ensureGstGLContext();
#endif
- bool supportsMuting() const { return true; }
- void setMuted(bool);
+ virtual bool supportsMuting() const override { return true; }
+ virtual void setMuted(bool) override;
bool muted() const;
- MediaPlayer::NetworkState networkState() const;
- MediaPlayer::ReadyState readyState() const;
+ virtual MediaPlayer::NetworkState networkState() const override;
+ virtual MediaPlayer::ReadyState readyState() const override;
- void setVisible(bool) { }
- void setSize(const IntSize&);
+ virtual void setVisible(bool) override { }
+ virtual void setSize(const IntSize&) override;
void sizeChanged();
- void paint(GraphicsContext&, const FloatRect&);
+ virtual void paint(GraphicsContext&, const FloatRect&) override;
- virtual bool hasSingleSecurityOrigin() const { return true; }
+ virtual bool hasSingleSecurityOrigin() const override { return true; }
virtual float maxTimeLoaded() const { return 0.0; }
- bool supportsFullscreen() const;
- PlatformMedia platformMedia() const;
+ virtual bool supportsFullscreen() const override;
+ virtual PlatformMedia platformMedia() const override;
- MediaPlayer::MovieLoadType movieLoadType() const;
+ virtual MediaPlayer::MovieLoadType movieLoadType() const override;
virtual bool isLiveStream() const = 0;
MediaPlayer* mediaPlayer() const { return m_player; }
- unsigned decodedFrameCount() const;
- unsigned droppedFrameCount() const;
- unsigned audioDecodedByteCount() const;
- unsigned videoDecodedByteCount() const;
+ virtual unsigned decodedFrameCount() const override;
+ virtual unsigned droppedFrameCount() const override;
+ virtual unsigned audioDecodedByteCount() const override;
+ virtual unsigned videoDecodedByteCount() const override;
#if USE(TEXTURE_MAPPER_GL) && !USE(COORDINATED_GRAPHICS)
- virtual PlatformLayer* platformLayer() const { return const_cast<MediaPlayerPrivateGStreamerBase*>(this); }
+ virtual PlatformLayer* platformLayer() const override { return const_cast<MediaPlayerPrivateGStreamerBase*>(this); }
#if PLATFORM(WIN_CAIRO)
// FIXME: Accelerated rendering has not been implemented for WinCairo yet.
- virtual bool supportsAcceleratedRendering() const { return false; }
+ virtual bool supportsAcceleratedRendering() const override { return false; }
#else
- virtual bool supportsAcceleratedRendering() const { return true; }
+ virtual bool supportsAcceleratedRendering() const override { return true; }
#endif
- virtual void paintToTextureMapper(TextureMapper*, const FloatRect&, const TransformationMatrix&, float);
+ virtual void paintToTextureMapper(TextureMapper*, const FloatRect&, const TransformationMatrix&, float) override;
#endif
protected:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
