Title: [193658] trunk
- Revision
- 193658
- Author
- beid...@apple.com
- Date
- 2015-12-07 15:12:50 -0800 (Mon, 07 Dec 2015)
Log Message
Modern IDB: storage/indexeddb/factory-deletedatabase.html fails.
https://bugs.webkit.org/show_bug.cgi?id=151966
Source/WebCore:
Reviewed by Sam Weinig.
No new tests (At least one failing test now passes).
* Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:
(WebCore::IDBClient::IDBOpenDBRequest::onDeleteDatabaseSuccess): The spec says that the result of
deleteDatabase should be undefined. Without explicitly making it undefined, it's incorrectly null.
LayoutTests:
Reviewed by Sam Weinig.
* platform/mac-wk1/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (193657 => 193658)
--- trunk/LayoutTests/ChangeLog 2015-12-07 23:07:03 UTC (rev 193657)
+++ trunk/LayoutTests/ChangeLog 2015-12-07 23:12:50 UTC (rev 193658)
@@ -1,5 +1,14 @@
2015-12-07 Brady Eidson <beid...@apple.com>
+ Modern IDB: storage/indexeddb/factory-deletedatabase.html fails.
+ https://bugs.webkit.org/show_bug.cgi?id=151966
+
+ Reviewed by Sam Weinig.
+
+ * platform/mac-wk1/TestExpectations:
+
+2015-12-07 Brady Eidson <beid...@apple.com>
+
Modern IDB: storage/indexeddb/cursor-continue-validity.html fails.
https://bugs.webkit.org/show_bug.cgi?id=151961
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (193657 => 193658)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-07 23:07:03 UTC (rev 193657)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-07 23:12:50 UTC (rev 193658)
@@ -122,7 +122,6 @@
storage/indexeddb/dont-commit-on-blocked.html [ Failure ]
storage/indexeddb/factory-basics.html [ Failure ]
storage/indexeddb/factory-cmp.html [ Failure ]
-storage/indexeddb/factory-deletedatabase.html [ Failure ]
storage/indexeddb/index-basics.html [ Failure ]
storage/indexeddb/index-count.html [ Failure ]
storage/indexeddb/index-cursor.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (193657 => 193658)
--- trunk/Source/WebCore/ChangeLog 2015-12-07 23:07:03 UTC (rev 193657)
+++ trunk/Source/WebCore/ChangeLog 2015-12-07 23:12:50 UTC (rev 193658)
@@ -1,5 +1,18 @@
2015-12-07 Brady Eidson <beid...@apple.com>
+ Modern IDB: storage/indexeddb/factory-deletedatabase.html fails.
+ https://bugs.webkit.org/show_bug.cgi?id=151966
+
+ Reviewed by Sam Weinig.
+
+ No new tests (At least one failing test now passes).
+
+ * Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:
+ (WebCore::IDBClient::IDBOpenDBRequest::onDeleteDatabaseSuccess): The spec says that the result of
+ deleteDatabase should be undefined. Without explicitly making it undefined, it's incorrectly null.
+
+2015-12-07 Brady Eidson <beid...@apple.com>
+
Modern IDB: storage/indexeddb/cursor-continue-validity.html fails.
https://bugs.webkit.org/show_bug.cgi?id=151961
Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp (193657 => 193658)
--- trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp 2015-12-07 23:07:03 UTC (rev 193657)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp 2015-12-07 23:12:50 UTC (rev 193658)
@@ -141,6 +141,7 @@
LOG(IndexedDB, "IDBOpenDBRequest::onDeleteDatabaseSuccess() - current version is %" PRIu64, oldVersion);
m_readyState = IDBRequestReadyState::Done;
+ m_result = IDBAny::createUndefined();
enqueueEvent(IDBVersionChangeEvent::create(oldVersion, 0, eventNames().successEvent));
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
