Title: [194066] trunk/Source/WebInspectorUI
- Revision
- 194066
- Author
- commit-qu...@webkit.org
- Date
- 2015-12-14 15:10:22 -0800 (Mon, 14 Dec 2015)
Log Message
Web Inspector: Copy message from console with a stack trace does not include source code locations
https://bugs.webkit.org/show_bug.cgi?id=152270
Patch by Joseph Pecoraro <pecor...@apple.com> on 2015-12-14
Reviewed by Timothy Hatcher.
* UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype.toClipboardString):
When the the StackTrace was upgraded to a real collection of CallFrame
object's the CallFrame's got real SourceCodeLocation properties.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (194065 => 194066)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-12-14 23:07:24 UTC (rev 194065)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-12-14 23:10:22 UTC (rev 194066)
@@ -1,3 +1,15 @@
+2015-12-14 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Copy message from console with a stack trace does not include source code locations
+ https://bugs.webkit.org/show_bug.cgi?id=152270
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/ConsoleMessageView.js:
+ (WebInspector.ConsoleMessageView.prototype.toClipboardString):
+ When the the StackTrace was upgraded to a real collection of CallFrame
+ object's the CallFrame's got real SourceCodeLocation properties.
+
2015-12-13 Matt Baker <mattba...@apple.com>
Web Inspector: Make TimelineOverview's graph container a subview
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js (194065 => 194066)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2015-12-14 23:07:24 UTC (rev 194065)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2015-12-14 23:10:22 UTC (rev 194066)
@@ -196,8 +196,8 @@
if (hasStackTrace) {
this._message.stackTrace.callFrames.forEach(function(frame) {
clipboardString += "\n\t" + (frame.functionName || WebInspector.UIString("(anonymous function)"));
- if (frame.url)
- clipboardString += " (" + WebInspector.displayNameForURL(frame.url) + ", line " + frame.lineNumber + ")";
+ if (frame.sourceCodeLocation)
+ clipboardString += " (" + frame.sourceCodeLocation.originalLocationString() + ")";
});
} else {
let repeatString = this.repeatCount > 1 ? "x" + this.repeatCount : "";
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
