Title: [194780] trunk/Source/ThirdParty/ANGLE
Revision
194780
Author
bfulg...@apple.com
Date
2016-01-08 13:01:26 -0800 (Fri, 08 Jan 2016)

Log Message

[ANGLE] Correct UNREACHABLE runtime assertion for void constructors
https://bugs.webkit.org/show_bug.cgi?id=152900
<rdar://problem/24107501>

Reviewed by Alex Christensen.

Tested by Khronos WebGL 1.0.4 suite.

Merge a small part of ANGLE upstream commit r284735:

    commit    01971113492d9aca386f2bca021b1f4b134fc277
    author    Dmitry Skiba <dsk...@google.com>  Fri Jul 10 18:54:00 2015
    committer Jamie Madill <jmad...@chromium.org>  Fri Jul 10 19:03:34 2015
    tree      47e42eac00f7d64cddb14b3cc21a4e605c189d20

This issue was found by <https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/bugs/angle-constructor-invalid-parameters.html?webglVersion=1&quiet=0>

* src/compiler/translator/Types.cpp:
(TType::buildMangledName): Don't assert with UNREACHABLE here.

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (194779 => 194780)


--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2016-01-08 21:01:01 UTC (rev 194779)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2016-01-08 21:01:26 UTC (rev 194780)
@@ -1,3 +1,25 @@
+2016-01-08  Brent Fulgham  <bfulg...@apple.com>
+
+        [ANGLE] Correct UNREACHABLE runtime assertion for void constructors
+        https://bugs.webkit.org/show_bug.cgi?id=152900
+        <rdar://problem/24107501>
+
+        Reviewed by Alex Christensen.
+
+        Tested by Khronos WebGL 1.0.4 suite.
+
+        Merge a small part of ANGLE upstream commit r284735:
+        
+            commit    01971113492d9aca386f2bca021b1f4b134fc277
+            author    Dmitry Skiba <dsk...@google.com>  Fri Jul 10 18:54:00 2015
+            committer Jamie Madill <jmad...@chromium.org>  Fri Jul 10 19:03:34 2015
+            tree      47e42eac00f7d64cddb14b3cc21a4e605c189d20
+
+        This issue was found by <https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/bugs/angle-constructor-invalid-parameters.html?webglVersion=1&quiet=0>
+
+        * src/compiler/translator/Types.cpp:
+        (TType::buildMangledName): Don't assert with UNREACHABLE here.
+
 2015-12-28  Joonghun Park  <jh718.p...@samsung.com>
 
         [ANGLE][EFL][GTK] Remove 'template<class> class std::auto_ptr is deprecated' compile warning

Modified: trunk/Source/ThirdParty/ANGLE/src/compiler/translator/Types.cpp (194779 => 194780)


--- trunk/Source/ThirdParty/ANGLE/src/compiler/translator/Types.cpp	2016-01-08 21:01:01 UTC (rev 194779)
+++ trunk/Source/ThirdParty/ANGLE/src/compiler/translator/Types.cpp	2016-01-08 21:01:26 UTC (rev 194780)
@@ -142,7 +142,8 @@
         mangledName += interfaceBlock->mangledName();
         break;
       default:
-        UNREACHABLE();
+        // EbtVoid, EbtAddress and non types
+        break;
     }
 
     if (isMatrix())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to