Diff
Modified: trunk/Source/WebKit2/ChangeLog (195588 => 195589)
--- trunk/Source/WebKit2/ChangeLog 2016-01-26 16:06:32 UTC (rev 195588)
+++ trunk/Source/WebKit2/ChangeLog 2016-01-26 16:08:21 UTC (rev 195589)
@@ -1,3 +1,31 @@
+2016-01-26 Daniel Bates <[email protected]>
+
+ WebKitTestRunner: Credential cache is not cleared between tests
+ https://bugs.webkit.org/show_bug.cgi?id=153407
+ <rdar://problem/24280834>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Expose SPI to call CredentialStorage::clearCredentials() on the default network storage
+ session to clear cached credentials.
+
+ * NetworkProcess/NetworkProcess.cpp:
+ (WebKit::NetworkProcess::clearCachedCredentials): Added.
+ * NetworkProcess/NetworkProcess.h:
+ * NetworkProcess/NetworkProcess.messages.in: Added message ClearCachedCredentials().
+ * UIProcess/API/C/WKContext.cpp:
+ (WKContextClearCachedCredentials): Added.
+ * UIProcess/API/C/WKContextPrivate.h:
+ * UIProcess/WebProcessPool.cpp:
+ (WebKit::WebProcessPool::clearCachedCredentials): Notify all web processes and the
+ network process to clear cached credentials.
+ * UIProcess/WebProcessPool.h:
+ * WebProcess/WebProcess.cpp:
+ (WebKit::WebProcess::clearCachedCredentials): Clear cached credentials in the default
+ network storage session.
+ * WebProcess/WebProcess.h:
+ * WebProcess/WebProcess.messages.in: Added message ClearCachedCredentials().
+
2016-01-26 Mario Sanchez Prada <[email protected]>
[GTK] WebProcess crashes when quickly attempting many DnD operations
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp (195588 => 195589)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2016-01-26 16:06:32 UTC (rev 195588)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2016-01-26 16:08:21 UTC (rev 195589)
@@ -255,6 +255,11 @@
#endif
}
+void NetworkProcess::clearCachedCredentials()
+{
+ NetworkStorageSession::defaultStorageSession().credentialStorage().clearCredentials();
+}
+
void NetworkProcess::ensurePrivateBrowsingSession(SessionID sessionID)
{
RemoteNetworkingContext::ensurePrivateBrowsingSession(sessionID);
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h (195588 => 195589)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h 2016-01-26 16:06:32 UTC (rev 195588)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h 2016-01-26 16:08:21 UTC (rev 195589)
@@ -146,6 +146,8 @@
void deleteWebsiteData(WebCore::SessionID, uint64_t websiteDataTypes, std::chrono::system_clock::time_point modifiedSince, uint64_t callbackID);
void deleteWebsiteDataForOrigins(WebCore::SessionID, uint64_t websiteDataTypes, const Vector<WebCore::SecurityOriginData>& origins, const Vector<String>& cookieHostNames, uint64_t callbackID);
+ void clearCachedCredentials();
+
// FIXME: This should take a session ID so we can identify which disk cache to delete.
void clearDiskCache(std::chrono::system_clock::time_point modifiedSince, std::function<void ()> completionHandler);
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.messages.in (195588 => 195589)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.messages.in 2016-01-26 16:06:32 UTC (rev 195588)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.messages.in 2016-01-26 16:08:21 UTC (rev 195589)
@@ -32,6 +32,8 @@
UserPreferredLanguagesChanged(Vector<String> languages)
#endif
+ ClearCachedCredentials()
+
EnsurePrivateBrowsingSession(WebCore::SessionID sessionID)
DestroyPrivateBrowsingSession(WebCore::SessionID sessionID)
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp (195588 => 195589)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2016-01-26 16:06:32 UTC (rev 195588)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2016-01-26 16:08:21 UTC (rev 195589)
@@ -538,6 +538,11 @@
toImpl(context)->useTestingNetworkSession();
}
+void WKContextClearCachedCredentials(WKContextRef context)
+{
+ toImpl(context)->clearCachedCredentials();
+}
+
WKDictionaryRef WKContextCopyPlugInAutoStartOriginHashes(WKContextRef contextRef)
{
return toAPI(toImpl(contextRef)->plugInAutoStartOriginHashes().leakRef());
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h (195588 => 195589)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h 2016-01-26 16:06:32 UTC (rev 195588)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h 2016-01-26 16:08:21 UTC (rev 195589)
@@ -82,6 +82,9 @@
// Test only. Should be called before any secondary processes are started.
WK_EXPORT void WKContextUseTestingNetworkSession(WKContextRef context);
+// Test only. Should be called before running a test.
+WK_EXPORT void WKContextClearCachedCredentials(WKContextRef context);
+
typedef void (*WKContextInvalidMessageFunction)(WKStringRef messageName);
WK_EXPORT void WKContextSetInvalidMessageFunction(WKContextInvalidMessageFunction invalidMessageFunction);
Modified: trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp (195588 => 195589)
--- trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2016-01-26 16:06:32 UTC (rev 195588)
+++ trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2016-01-26 16:08:21 UTC (rev 195589)
@@ -1073,6 +1073,13 @@
m_shouldUseTestingNetworkSession = true;
}
+void WebProcessPool::clearCachedCredentials()
+{
+ sendToAllProcesses(Messages::WebProcess::ClearCachedCredentials());
+ if (m_networkProcess)
+ m_networkProcess->send(Messages::NetworkProcess::ClearCachedCredentials(), 0);
+}
+
void WebProcessPool::allowSpecificHTTPSCertificateForHost(const WebCertificateInfo* certificate, const String& host)
{
if (m_networkProcess)
Modified: trunk/Source/WebKit2/UIProcess/WebProcessPool.h (195588 => 195589)
--- trunk/Source/WebKit2/UIProcess/WebProcessPool.h 2016-01-26 16:06:32 UTC (rev 195588)
+++ trunk/Source/WebKit2/UIProcess/WebProcessPool.h 2016-01-26 16:08:21 UTC (rev 195589)
@@ -241,6 +241,8 @@
void useTestingNetworkSession();
bool isUsingTestingNetworkSession() const { return m_shouldUseTestingNetworkSession; }
+ void clearCachedCredentials();
+
void allowSpecificHTTPSCertificateForHost(const WebCertificateInfo*, const String& host);
WebProcessProxy& createNewWebProcessRespectingProcessCountLimit(); // Will return an existing one if limit is met.
Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (195588 => 195589)
--- trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2016-01-26 16:06:32 UTC (rev 195588)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2016-01-26 16:08:21 UTC (rev 195589)
@@ -498,6 +498,11 @@
}
}
+void WebProcess::clearCachedCredentials()
+{
+ NetworkStorageSession::defaultStorageSession().credentialStorage().clearCredentials();
+}
+
WebPage* WebProcess::focusedWebPage() const
{
for (auto& page : m_pageMap.values()) {
Modified: trunk/Source/WebKit2/WebProcess/WebProcess.h (195588 => 195589)
--- trunk/Source/WebKit2/WebProcess/WebProcess.h 2016-01-26 16:06:32 UTC (rev 195588)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.h 2016-01-26 16:08:21 UTC (rev 195589)
@@ -210,6 +210,8 @@
void initializeWebProcess(WebProcessCreationParameters&&);
void platformInitializeWebProcess(WebProcessCreationParameters&&);
+ void clearCachedCredentials();
+
void platformTerminate();
void registerURLSchemeAsEmptyDocument(const String&);
void registerURLSchemeAsSecure(const String&) const;
Modified: trunk/Source/WebKit2/WebProcess/WebProcess.messages.in (195588 => 195589)
--- trunk/Source/WebKit2/WebProcess/WebProcess.messages.in 2016-01-26 16:06:32 UTC (rev 195588)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.messages.in 2016-01-26 16:08:21 UTC (rev 195589)
@@ -45,6 +45,8 @@
UserPreferredLanguagesChanged(Vector<String> languages)
FullKeyboardAccessModeChanged(bool fullKeyboardAccessEnabled)
+ ClearCachedCredentials()
+
// Legacy private browsing session is per process. Individual pages or page groups may use the private session or the default one as appropriate.
EnsurePrivateBrowsingSession(WebCore::SessionID sessionID)
DestroyPrivateBrowsingSession(WebCore::SessionID sessionID)
Modified: trunk/Tools/ChangeLog (195588 => 195589)
--- trunk/Tools/ChangeLog 2016-01-26 16:06:32 UTC (rev 195588)
+++ trunk/Tools/ChangeLog 2016-01-26 16:08:21 UTC (rev 195589)
@@ -1,3 +1,15 @@
+2016-01-26 Daniel Bates <[email protected]>
+
+ WebKitTestRunner: Credential cache is not cleared between tests
+ https://bugs.webkit.org/show_bug.cgi?id=153407
+ <rdar://problem/24280834>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
+ to clear cached credentials.
+
2016-01-26 Carlos Alberto Lopez Perez <[email protected]>
kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (195588 => 195589)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2016-01-26 16:06:32 UTC (rev 195588)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2016-01-26 16:08:21 UTC (rev 195589)
@@ -714,6 +714,8 @@
WKContextSetCacheModel(TestController::singleton().context(), kWKCacheModelDocumentBrowser);
+ WKContextClearCachedCredentials(TestController::singleton().context());
+
// FIXME: This function should also ensure that there is only one page open.
// Reset the EventSender for each test.
