Title: [195967] trunk/Source/WebInspectorUI
Revision
195967
Author
mattba...@apple.com
Date
2016-02-01 10:24:40 -0800 (Mon, 01 Feb 2016)

Log Message

Web Inspector: Rendering Frames timeline draws all frame bars at minimum height
https://bugs.webkit.org/show_bug.cgi?id=153736
<rdar://problem/21946301>

Reviewed by Timothy Hatcher.

* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
Update the new timeline overview's height before it's shown. Showing the
overview causes the rendering frames graph to do a layout, which requires
the height of the containing view to be a valid value.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (195966 => 195967)


--- trunk/Source/WebInspectorUI/ChangeLog	2016-02-01 18:22:37 UTC (rev 195966)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-02-01 18:24:40 UTC (rev 195967)
@@ -1,5 +1,19 @@
 2016-02-01  Matt Baker  <mattba...@apple.com>
 
+        Web Inspector: Rendering Frames timeline draws all frame bars at minimum height
+        https://bugs.webkit.org/show_bug.cgi?id=153736
+        <rdar://problem/21946301>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/TimelineRecordingContentView.js:
+        (WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
+        Update the new timeline overview's height before it's shown. Showing the
+        overview causes the rendering frames graph to do a layout, which requires
+        the height of the containing view to be a valid value.
+
+2016-02-01  Matt Baker  <mattba...@apple.com>
+
         Web Inspector: DataGridNode should support adding go-to arrow buttons to any cell
         https://bugs.webkit.org/show_bug.cgi?id=153733
         <rdar://problem/24431813>

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (195966 => 195967)


--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js	2016-02-01 18:22:37 UTC (rev 195966)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js	2016-02-01 18:24:40 UTC (rev 195967)
@@ -352,9 +352,9 @@
             this.replaceSubview(this._currentTimelineOverview, newTimelineOverview);
 
             this._currentTimelineOverview = newTimelineOverview;
-            this._currentTimelineOverview.shown();
 
             this._updateTimelineOverviewHeight();
+            this._currentTimelineOverview.shown();
         }
 
         if (timelineView) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to