Title: [196733] trunk/Source/_javascript_Core
- Revision
- 196733
- Author
- [email protected]
- Date
- 2016-02-17 17:05:56 -0800 (Wed, 17 Feb 2016)
Log Message
Remove a wrong cast in RemoteInspector::receivedSetupMessage
https://bugs.webkit.org/show_bug.cgi?id=154361
<rdar://problem/24709281>
Reviewed by Joseph Pecoraro.
* inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::receivedSetupMessage):
Not only is this cast unnecessary (the constructor accepts the base class),
but it is wrong since the target could be an automation target. Remove it.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (196732 => 196733)
--- trunk/Source/_javascript_Core/ChangeLog 2016-02-18 01:03:28 UTC (rev 196732)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-02-18 01:05:56 UTC (rev 196733)
@@ -1,3 +1,16 @@
+2016-02-17 Brian Burg <[email protected]>
+
+ Remove a wrong cast in RemoteInspector::receivedSetupMessage
+ https://bugs.webkit.org/show_bug.cgi?id=154361
+ <rdar://problem/24709281>
+
+ Reviewed by Joseph Pecoraro.
+
+ * inspector/remote/RemoteInspector.mm:
+ (Inspector::RemoteInspector::receivedSetupMessage):
+ Not only is this cast unnecessary (the constructor accepts the base class),
+ but it is wrong since the target could be an automation target. Remove it.
+
2016-02-17 Filip Pizlo <[email protected]>
Rename FTLB3Blah to FTLBlah
Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.mm (196732 => 196733)
--- trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.mm 2016-02-18 01:03:28 UTC (rev 196732)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.mm 2016-02-18 01:05:56 UTC (rev 196733)
@@ -618,7 +618,7 @@
// Attempt to create a connection. This may fail if the page already has an inspector or if it disallows inspection.
RemoteControllableTarget* target = findResult->value;
- RefPtr<RemoteConnectionToTarget> connectionToTarget = adoptRef(new RemoteConnectionToTarget(downcast<RemoteInspectionTarget>(target), connectionIdentifier, sender));
+ RefPtr<RemoteConnectionToTarget> connectionToTarget = adoptRef(new RemoteConnectionToTarget(target, connectionIdentifier, sender));
if (is<RemoteInspectionTarget>(target)) {
bool isAutomaticInspection = m_automaticInspectionCandidateTargetIdentifier == target->targetIdentifier();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
