Title: [196767] trunk/Source/WebKit2
- Revision
- 196767
- Author
- [email protected]
- Date
- 2016-02-18 11:06:50 -0800 (Thu, 18 Feb 2016)
Log Message
[GTK][Threaded Compositor] The web inspector doesn't work when using the threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=154067
Reviewed by Carlos Garcia Campos.
The forceCompositingMode should be true for threaded compositor. We set it true for a normal webView
in _WebKitSettingsPrivate() but we do not for inspector anywhere. So DrawingArea is not
properly created for the inspector. Let's move the setting to WebPreferences::platformInitializeStore
which is a common place for the webView and the inspector.
* UIProcess/API/gtk/WebKitSettings.cpp:
(_WebKitSettingsPrivate::_WebKitSettingsPrivate): Deleted.
* UIProcess/gtk/WebPreferencesGtk.cpp:
(WebKit::WebPreferences::platformInitializeStore):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (196766 => 196767)
--- trunk/Source/WebKit2/ChangeLog 2016-02-18 19:02:26 UTC (rev 196766)
+++ trunk/Source/WebKit2/ChangeLog 2016-02-18 19:06:50 UTC (rev 196767)
@@ -1,3 +1,20 @@
+2016-02-18 ChangSeok Oh <[email protected]>
+
+ [GTK][Threaded Compositor] The web inspector doesn't work when using the threaded compositor
+ https://bugs.webkit.org/show_bug.cgi?id=154067
+
+ Reviewed by Carlos Garcia Campos.
+
+ The forceCompositingMode should be true for threaded compositor. We set it true for a normal webView
+ in _WebKitSettingsPrivate() but we do not for inspector anywhere. So DrawingArea is not
+ properly created for the inspector. Let's move the setting to WebPreferences::platformInitializeStore
+ which is a common place for the webView and the inspector.
+
+ * UIProcess/API/gtk/WebKitSettings.cpp:
+ (_WebKitSettingsPrivate::_WebKitSettingsPrivate): Deleted.
+ * UIProcess/gtk/WebPreferencesGtk.cpp:
+ (WebKit::WebPreferences::platformInitializeStore):
+
2016-02-18 Commit Queue <[email protected]>
Unreviewed, rolling out r196765.
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp (196766 => 196767)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2016-02-18 19:02:26 UTC (rev 196766)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2016-02-18 19:06:50 UTC (rev 196767)
@@ -58,10 +58,6 @@
fantasyFontFamily = preferences->fantasyFontFamily().utf8();
pictographFontFamily = preferences->pictographFontFamily().utf8();
defaultCharset = preferences->defaultTextEncodingName().utf8();
-
-#if USE(COORDINATED_GRAPHICS_THREADED)
- preferences->setForceCompositingMode(true);
-#endif
}
RefPtr<WebPreferences> preferences;
Modified: trunk/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp (196766 => 196767)
--- trunk/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp 2016-02-18 19:02:26 UTC (rev 196766)
+++ trunk/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp 2016-02-18 19:06:50 UTC (rev 196767)
@@ -41,6 +41,9 @@
setAcceleratedCompositingEnabled(false);
}
#endif
+#if USE(COORDINATED_GRAPHICS_THREADED)
+ setForceCompositingMode(true);
+#endif
#if !ENABLE(OPENGL)
setAcceleratedCompositingEnabled(false);
#else
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
