Title: [196787] trunk/Websites/perf.webkit.org
- Revision
- 196787
- Author
- [email protected]
- Date
- 2016-02-18 16:51:46 -0800 (Thu, 18 Feb 2016)
Log Message
Statistically significant A/B testing results should be color coded in details view
https://bugs.webkit.org/show_bug.cgi?id=154414
Reviewed by Chris Dumez.
Color code the statistically significant comparisions in TestGroupResultsTable as done in the analysis
results viewer.
* public/v3/components/customizable-test-group-form.js:
(CustomizableTestGroupForm.cssTemplate): Build fix after r196768.
* public/v3/components/test-group-results-table.js:
(TestGroupResultsTable.prototype.buildRowGroups): Add the status as a class name.
(TestGroupResultsTable.cssTemplate): Added styles to color-code statistically significant results.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (196786 => 196787)
--- trunk/Websites/perf.webkit.org/ChangeLog 2016-02-19 00:42:01 UTC (rev 196786)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2016-02-19 00:51:46 UTC (rev 196787)
@@ -1,3 +1,19 @@
+2016-02-18 Ryosuke Niwa <[email protected]>
+
+ Statistically significant A/B testing results should be color coded in details view
+ https://bugs.webkit.org/show_bug.cgi?id=154414
+
+ Reviewed by Chris Dumez.
+
+ Color code the statistically significant comparisions in TestGroupResultsTable as done in the analysis
+ results viewer.
+
+ * public/v3/components/customizable-test-group-form.js:
+ (CustomizableTestGroupForm.cssTemplate): Build fix after r196768.
+ * public/v3/components/test-group-results-table.js:
+ (TestGroupResultsTable.prototype.buildRowGroups): Add the status as a class name.
+ (TestGroupResultsTable.cssTemplate): Added styles to color-code statistically significant results.
+
2016-02-17 Ryosuke Niwa <[email protected]>
v3 UI should allow custom revisions for A/B testing
Modified: trunk/Websites/perf.webkit.org/public/v3/components/customizable-test-group-form.js (196786 => 196787)
--- trunk/Websites/perf.webkit.org/public/v3/components/customizable-test-group-form.js 2016-02-19 00:42:01 UTC (rev 196786)
+++ trunk/Websites/perf.webkit.org/public/v3/components/customizable-test-group-form.js 2016-02-19 00:51:46 UTC (rev 196787)
@@ -129,7 +129,7 @@
static cssTemplate()
{
- return super.cssTemplate() + `
+ return `
.customize-link {
color: #333;
}
Modified: trunk/Websites/perf.webkit.org/public/v3/components/test-group-results-table.js (196786 => 196787)
--- trunk/Websites/perf.webkit.org/public/v3/components/test-group-results-table.js 2016-02-19 00:42:01 UTC (rev 196786)
+++ trunk/Websites/perf.webkit.org/public/v3/components/test-group-results-table.js 2016-02-19 00:51:46 UTC (rev 196787)
@@ -65,7 +65,8 @@
continue;
var row = new ResultsTableRow(`${startConfig} to ${endConfig}`, null);
- row.setLabelForWholeRow(result.fullLabel);
+ var element = ComponentBase.createElement;
+ row.setLabelForWholeRow(element('span', {class: 'results-label ' + result.status}, result.fullLabel));
comparisonRows.push(row);
}
}
@@ -74,6 +75,32 @@
return groups;
}
+
+ static cssTemplate()
+ {
+ return super.cssTemplate() + `
+ .results-label {
+ padding: 0.1rem;
+ width: 100%;
+ height: 100%;
+ }
+
+ .results-label .failed {
+ color: rgb(128, 51, 128);
+ }
+ .results-label .unchanged {
+ color: rgb(128, 128, 128);
+ }
+ .results-label.worse {
+ color: rgb(255, 102, 102);
+ font-weight: bold;
+ }
+ .results-label.better {
+ color: rgb(102, 102, 255);
+ font-weight: bold;
+ }
+ `;
+ }
}
ComponentBase.defineElement('test-group-results-table', TestGroupResultsTable);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
