Title: [196862] trunk/Source/WebCore
- Revision
- 196862
- Author
- [email protected]
- Date
- 2016-02-20 09:02:16 -0800 (Sat, 20 Feb 2016)
Log Message
REGRESSION(r196780): Fake memory handler takes too long to run now.
Unreviewed bot fix.
Put the footprint comparison code behind a compile-time flag for now.
It's taking too long to run on bots, and memory is getting measured
before all the pressure relief code has a chance to run.
* platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::install):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (196861 => 196862)
--- trunk/Source/WebCore/ChangeLog 2016-02-20 16:42:24 UTC (rev 196861)
+++ trunk/Source/WebCore/ChangeLog 2016-02-20 17:02:16 UTC (rev 196862)
@@ -1,3 +1,16 @@
+2016-02-20 Andreas Kling <[email protected]>
+
+ REGRESSION(r196780): Fake memory handler takes too long to run now.
+
+ Unreviewed bot fix.
+
+ Put the footprint comparison code behind a compile-time flag for now.
+ It's taking too long to run on bots, and memory is getting measured
+ before all the pressure relief code has a chance to run.
+
+ * platform/cocoa/MemoryPressureHandlerCocoa.mm:
+ (WebCore::MemoryPressureHandler::install):
+
2016-02-20 Olivier Blin <[email protected]>
Do not require UDate in LocaleICU with !ENABLE_DATE_AND_TIME_INPUT_TYPES
Modified: trunk/Source/WebCore/platform/cocoa/MemoryPressureHandlerCocoa.mm (196861 => 196862)
--- trunk/Source/WebCore/platform/cocoa/MemoryPressureHandlerCocoa.mm 2016-02-20 16:42:24 UTC (rev 196861)
+++ trunk/Source/WebCore/platform/cocoa/MemoryPressureHandlerCocoa.mm 2016-02-20 17:02:16 UTC (rev 196862)
@@ -46,6 +46,8 @@
#import "WebCoreThread.h"
#endif
+#define ENABLE_FMW_FOOTPRINT_COMPARISON 0
+
extern "C" void cache_simulate_memory_warning_event(uint64_t);
extern "C" void _sqlite3_purgeEligiblePagerCacheMemory(void);
@@ -130,7 +132,7 @@
// Allow simulation of memory pressure with "notifyutil -p org.WebKit.lowMemory"
notify_register_dispatch("org.WebKit.lowMemory", &_notifyToken, dispatch_get_main_queue(), ^(int) {
-#if ENABLE(RESOURCE_USAGE)
+#if ENABLE(FMW_FOOTPRINT_COMPARISON)
auto footprintBefore = pagesPerVMTag();
#endif
@@ -143,7 +145,7 @@
malloc_zone_pressure_relief(nullptr, 0);
-#if ENABLE(RESOURCE_USAGE)
+#if ENABLE(FMW_FOOTPRINT_COMPARISON)
auto footprintAfter = pagesPerVMTag();
logFootprintComparison(footprintBefore, footprintAfter);
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes