Title: [197028] trunk/Source/WebCore
Revision
197028
Author
youenn.fab...@crf.canon.fr
Date
2016-02-24 06:17:48 -0800 (Wed, 24 Feb 2016)

Log Message

Remove IteratorKey and IteratorValue declarations from JSXX class declarations.
https://bugs.webkit.org/show_bug.cgi?id=154577

Reviewed by Myles C. Maxfield.

No change of behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Deleted declaration of IteratorKey and IteratorValue.
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::createStructure): Rebasing of binding test expectation.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (197027 => 197028)


--- trunk/Source/WebCore/ChangeLog	2016-02-24 12:14:30 UTC (rev 197027)
+++ trunk/Source/WebCore/ChangeLog	2016-02-24 14:17:48 UTC (rev 197028)
@@ -1,5 +1,19 @@
 2016-02-24  Youenn Fablet  <youenn.fab...@crf.canon.fr>
 
+        Remove IteratorKey and IteratorValue declarations from JSXX class declarations.
+        https://bugs.webkit.org/show_bug.cgi?id=154577
+
+        Reviewed by Myles C. Maxfield.
+
+        No change of behavior.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateHeader): Deleted declaration of IteratorKey and IteratorValue.
+        * bindings/scripts/test/JS/JSTestObj.h:
+        (WebCore::JSTestObj::createStructure): Rebasing of binding test expectation.
+
+2016-02-24  Youenn Fablet  <youenn.fab...@crf.canon.fr>
+
         [Fetch API] Refactor FetchHeaders initialization with iterators
         https://bugs.webkit.org/show_bug.cgi?id=154537
 

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (197027 => 197028)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2016-02-24 12:14:30 UTC (rev 197027)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2016-02-24 14:17:48 UTC (rev 197028)
@@ -1050,16 +1050,6 @@
         push(@headerContent, "    static void destroy(JSC::JSCell*);\n");
     }
 
-    if ($interface->iterable) {
-        push(@headerContent, "\n");
-        if ($interface->iterable->keyType) {
-            my $keyType = GetNativeType($interface->iterable->keyType);
-            push(@headerContent, "    using IteratorKey = $keyType;\n");
-        }
-        my $valueType = GetNativeType($interface->iterable->valueType);
-        push(@headerContent, "    using IteratorValue = $valueType;\n");
-    }
-
     # Class info
     if ($interfaceName eq "Node") {
         push(@headerContent, "\n");
@@ -4039,7 +4029,6 @@
     my $svgNativeType = $codeGenerator->GetSVGTypeNeedingTearOff($type);
     return "${svgNativeType}*" if $svgNativeType;
     return "RefPtr<DOMStringList>" if $type eq "DOMStringList";
-    return "RefPtr<FontFace>" if $type eq "FontFace";
     return "RefPtr<${type}>" if $codeGenerator->IsTypedArrayType($type) and not $type eq "ArrayBuffer";
     return $nativeType{$type} if exists $nativeType{$type};
 

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h (197027 => 197028)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h	2016-02-24 12:14:30 UTC (rev 197027)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h	2016-02-24 14:17:48 UTC (rev 197028)
@@ -45,9 +45,6 @@
     static bool getOwnPropertySlot(JSC::JSObject*, JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&);
     static void destroy(JSC::JSCell*);
 
-    using IteratorKey = String;
-    using IteratorValue = TestObj*;
-
     DECLARE_INFO;
 
     static JSC::Structure* createStructure(JSC::VM& vm, JSC::JSGlobalObject* globalObject, JSC::JSValue prototype)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to