Title: [197110] releases/WebKitGTK/webkit-2.12/Source/_javascript_Core
Revision
197110
Author
carlo...@webkit.org
Date
2016-02-25 06:48:11 -0800 (Thu, 25 Feb 2016)

Log Message

Merge r196999 - Make JSObject::getMethod have fewer branches
https://bugs.webkit.org/show_bug.cgi?id=154603

Reviewed by Mark Lam.

Writing code with fewer branches is almost always better.

* runtime/JSObject.cpp:
(JSC::JSObject::getMethod):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.12/Source/_javascript_Core/ChangeLog (197109 => 197110)


--- releases/WebKitGTK/webkit-2.12/Source/_javascript_Core/ChangeLog	2016-02-25 14:40:13 UTC (rev 197109)
+++ releases/WebKitGTK/webkit-2.12/Source/_javascript_Core/ChangeLog	2016-02-25 14:48:11 UTC (rev 197110)
@@ -1,3 +1,15 @@
+2016-02-23  Saam barati  <sbar...@apple.com>
+
+        Make JSObject::getMethod have fewer branches
+        https://bugs.webkit.org/show_bug.cgi?id=154603
+
+        Reviewed by Mark Lam.
+
+        Writing code with fewer branches is almost always better.
+
+        * runtime/JSObject.cpp:
+        (JSC::JSObject::getMethod):
+
 2016-02-23  Filip Pizlo  <fpi...@apple.com>
 
         B3::Value doesn't self-destruct virtually enough (Causes many leaks in LowerDFGToB3::appendOSRExit)

Modified: releases/WebKitGTK/webkit-2.12/Source/_javascript_Core/runtime/JSObject.cpp (197109 => 197110)


--- releases/WebKitGTK/webkit-2.12/Source/_javascript_Core/runtime/JSObject.cpp	2016-02-25 14:40:13 UTC (rev 197109)
+++ releases/WebKitGTK/webkit-2.12/Source/_javascript_Core/runtime/JSObject.cpp	2016-02-25 14:48:11 UTC (rev 197110)
@@ -2947,10 +2947,10 @@
     if (exec->hadException())
         return jsUndefined();
 
-    if (method.isUndefined() || method.isNull())
-        return jsUndefined();
+    if (!method.isCell()) {
+        if (method.isUndefinedOrNull())
+            return jsUndefined();
 
-    if (!method.isCell()) {
         throwVMTypeError(exec, errorMessage);
         return jsUndefined();
     }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to