Title: [197134] trunk/Source/_javascript_Core
- Revision
- 197134
- Author
- [email protected]
- Date
- 2016-02-25 14:37:44 -0800 (Thu, 25 Feb 2016)
Log Message
[JSC] Remove a useless "Move" in the lowering of Select
https://bugs.webkit.org/show_bug.cgi?id=154670
Patch by Benjamin Poulain <[email protected]> on 2016-02-25
Reviewed by Geoffrey Garen.
I left the Move instruction when creating the aliasing form
of Select.
On ARM64, that meant a useless move for any case that can't
be coalesced.
On x86, that meant an extra constraint on child2, making it
stupidly hard to alias child1.
* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::createSelect): Deleted.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (197133 => 197134)
--- trunk/Source/_javascript_Core/ChangeLog 2016-02-25 22:37:15 UTC (rev 197133)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-02-25 22:37:44 UTC (rev 197134)
@@ -1,3 +1,22 @@
+2016-02-25 Benjamin Poulain <[email protected]>
+
+ [JSC] Remove a useless "Move" in the lowering of Select
+ https://bugs.webkit.org/show_bug.cgi?id=154670
+
+ Reviewed by Geoffrey Garen.
+
+ I left the Move instruction when creating the aliasing form
+ of Select.
+
+ On ARM64, that meant a useless move for any case that can't
+ be coalesced.
+
+ On x86, that meant an extra constraint on child2, making it
+ stupidly hard to alias child1.
+
+ * b3/B3LowerToAir.cpp:
+ (JSC::B3::Air::LowerToAir::createSelect): Deleted.
+
2016-02-24 Joseph Pecoraro <[email protected]>
Web Inspector: Expose Proxy target and handler internal properties to Inspector
Modified: trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp (197133 => 197134)
--- trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp 2016-02-25 22:37:15 UTC (rev 197133)
+++ trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp 2016-02-25 22:37:44 UTC (rev 197134)
@@ -1607,7 +1607,6 @@
Tmp result = tmp(m_value);
Tmp thenCase = tmp(m_value->child(1));
Tmp elseCase = tmp(m_value->child(2));
- append(relaxedMoveForType(m_value->type()), tmp(m_value->child(2)), result);
return Inst(
opcode, m_value, condition,
left.consume(*this), right.consume(*this), thenCase, elseCase, result);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
