Title: [197169] trunk/Source/WebInspectorUI
- Revision
- 197169
- Author
- [email protected]
- Date
- 2016-02-26 09:15:11 -0800 (Fri, 26 Feb 2016)
Log Message
Web Inspector: Option-clicking on the a CSS property sometimes doesn't work
https://bugs.webkit.org/show_bug.cgi?id=154384
<rdar://problem/24714755>
Patch by Devin Rousso <[email protected]> on 2016-02-26
Reviewed by Timothy Hatcher.
It seems as though there were race conditions between CodeMirror's event
and the native mousemove such that if CodeMirror fired second, the current
candidate was cleared, and would not reset itself until the cursor was
moved, at which point the same issue could happen. To fix this, the current
candidate is no longer cleared by CodeMirror's event and is instead only
modified by the native mouse-events.
* UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
(WebInspector.CodeMirrorTokenTrackingController.prototype._hidePopover):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (197168 => 197169)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-02-26 17:04:18 UTC (rev 197168)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-02-26 17:15:11 UTC (rev 197169)
@@ -1,3 +1,21 @@
+2016-02-26 Devin Rousso <[email protected]>
+
+ Web Inspector: Option-clicking on the a CSS property sometimes doesn't work
+ https://bugs.webkit.org/show_bug.cgi?id=154384
+ <rdar://problem/24714755>
+
+ Reviewed by Timothy Hatcher.
+
+ It seems as though there were race conditions between CodeMirror's event
+ and the native mousemove such that if CodeMirror fired second, the current
+ candidate was cleared, and would not reset itself until the cursor was
+ moved, at which point the same issue could happen. To fix this, the current
+ candidate is no longer cleared by CodeMirror's event and is instead only
+ modified by the native mouse-events.
+
+ * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
+ (WebInspector.CodeMirrorTokenTrackingController.prototype._hidePopover):
+
2016-02-25 Nikita Vasilyev <[email protected]>
Web Inspector: Unify selected item colors
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTokenTrackingController.js (197168 => 197169)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTokenTrackingController.js 2016-02-26 17:04:18 UTC (rev 197168)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTokenTrackingController.js 2016-02-26 17:15:11 UTC (rev 197169)
@@ -276,8 +276,6 @@
const forceHidePopover = true;
this._delegate.tokenTrackingControllerHighlightedRangeReleased(this, forceHidePopover);
}
-
- this._candidate = null;
}
_mouseEntered(event)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
