Title: [197193] trunk/Source/WebCore
- Revision
- 197193
- Author
- [email protected]
- Date
- 2016-02-26 12:47:24 -0800 (Fri, 26 Feb 2016)
Log Message
Initialize LocaleICU data members in header
https://bugs.webkit.org/show_bug.cgi?id=154731
Patch by Olivier Blin <[email protected]> on 2016-02-26
Reviewed by Michael Catanzaro.
LocaleICU data members should be initialized in the header, to
avoid conditional initialization lines in the constructor, as
suggested by Darin in bug 154484.
* platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::LocaleICU): Deleted.
* platform/text/LocaleICU.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (197192 => 197193)
--- trunk/Source/WebCore/ChangeLog 2016-02-26 20:25:42 UTC (rev 197192)
+++ trunk/Source/WebCore/ChangeLog 2016-02-26 20:47:24 UTC (rev 197193)
@@ -1,3 +1,18 @@
+2016-02-26 Olivier Blin <[email protected]>
+
+ Initialize LocaleICU data members in header
+ https://bugs.webkit.org/show_bug.cgi?id=154731
+
+ Reviewed by Michael Catanzaro.
+
+ LocaleICU data members should be initialized in the header, to
+ avoid conditional initialization lines in the constructor, as
+ suggested by Darin in bug 154484.
+
+ * platform/text/LocaleICU.cpp:
+ (WebCore::LocaleICU::LocaleICU): Deleted.
+ * platform/text/LocaleICU.h:
+
2016-02-26 Brady Eidson <[email protected]>
Modern IDB: Using existing database info from SQLite backing store is busted.
Modified: trunk/Source/WebCore/platform/text/LocaleICU.cpp (197192 => 197193)
--- trunk/Source/WebCore/platform/text/LocaleICU.cpp 2016-02-26 20:25:42 UTC (rev 197192)
+++ trunk/Source/WebCore/platform/text/LocaleICU.cpp 2016-02-26 20:47:24 UTC (rev 197193)
@@ -50,17 +50,6 @@
LocaleICU::LocaleICU(const char* locale)
: m_locale(locale)
-#if !UCONFIG_NO_FORMATTING
- , m_numberFormat(0)
- , m_didCreateDecimalFormat(false)
-#endif
-#if ENABLE(DATE_AND_TIME_INPUT_TYPES)
- , m_shortDateFormat(0)
- , m_mediumTimeFormat(0)
- , m_shortTimeFormat(0)
- , m_didCreateShortDateFormat(false)
- , m_didCreateTimeFormat(false)
-#endif
{
}
Modified: trunk/Source/WebCore/platform/text/LocaleICU.h (197192 => 197193)
--- trunk/Source/WebCore/platform/text/LocaleICU.h 2016-02-26 20:25:42 UTC (rev 197192)
+++ trunk/Source/WebCore/platform/text/LocaleICU.h 2016-02-26 20:47:24 UTC (rev 197193)
@@ -81,8 +81,8 @@
CString m_locale;
#if !UCONFIG_NO_FORMATTING
- UNumberFormat* m_numberFormat;
- bool m_didCreateDecimalFormat;
+ UNumberFormat* m_numberFormat { nullptr };
+ bool m_didCreateDecimalFormat { false };
#endif
#if ENABLE(DATE_AND_TIME_INPUT_TYPES)
@@ -94,15 +94,15 @@
String m_timeFormatWithoutSeconds;
String m_dateTimeFormatWithSeconds;
String m_dateTimeFormatWithoutSeconds;
- UDateFormat* m_shortDateFormat;
- UDateFormat* m_mediumTimeFormat;
- UDateFormat* m_shortTimeFormat;
+ UDateFormat* m_shortDateFormat { nullptr };
+ UDateFormat* m_mediumTimeFormat { nullptr };
+ UDateFormat* m_shortTimeFormat { nullptr };
Vector<String> m_shortMonthLabels;
Vector<String> m_standAloneMonthLabels;
Vector<String> m_shortStandAloneMonthLabels;
Vector<String> m_timeAMPMLabels;
- bool m_didCreateShortDateFormat;
- bool m_didCreateTimeFormat;
+ bool m_didCreateShortDateFormat { false };
+ bool m_didCreateTimeFormat { false };
#endif
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
