Diff
Modified: trunk/Source/WebKit2/ChangeLog (197202 => 197203)
--- trunk/Source/WebKit2/ChangeLog 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/ChangeLog 2016-02-26 22:26:03 UTC (rev 197203)
@@ -1,5 +1,100 @@
2016-02-26 Anders Carlsson <[email protected]>
+ WKWebsiteDataStore/WKWebsiteDataRecord needs to provide size information about each type of data
+ https://bugs.webkit.org/show_bug.cgi?id=154750
+
+ Reviewed by Tim Horton.
+
+ * DatabaseProcess/DatabaseProcess.cpp:
+ (WebKit::DatabaseProcess::fetchWebsiteData):
+ WebsiteData::Entry now takes a size.
+
+ * NetworkProcess/NetworkProcess.cpp:
+ (WebKit::fetchDiskCacheEntries):
+ If necessary, compute sizes.
+
+ (WebKit::NetworkProcess::fetchWebsiteData):
+ Just pass 0 for the CF cache for now.
+
+ * NetworkProcess/NetworkProcess.h:
+ * NetworkProcess/NetworkProcess.messages.in:
+ FetchWebsiteData now takes a OptionSet<WebsiteDataFetchOption>.
+
+ * Shared/WebsiteData/WebsiteData.cpp:
+ (WebKit::WebsiteData::Entry::encode):
+ (WebKit::WebsiteData::Entry::decode):
+ Encode and decode the size.
+
+ * Shared/WebsiteData/WebsiteData.h:
+ Add size.
+
+ * Shared/WebsiteData/WebsiteDataFetchOption.h:
+ Add new enum.
+
+ * UIProcess/API/C/WKApplicationCacheManager.cpp:
+ (WKApplicationCacheManagerGetApplicationCacheOrigins):
+ Pass an empty OptionSet<WebsiteDataFetchOption>.
+
+ * UIProcess/API/C/WKResourceCacheManager.cpp:
+ (WKResourceCacheManagerGetCacheOrigins):
+ Pass an empty OptionSet<WebsiteDataFetchOption>.
+
+ * UIProcess/API/Cocoa/WKWebsiteDataRecord.mm:
+ (-[WKWebsiteDataRecord description]):
+ If we have a size, print it out as well.
+
+ (-[WKWebsiteDataRecord _dataSize]):
+ Return a size if we have one.
+
+ * UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h:
+ * UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
+ (-[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:]):
+ Call through to the SPI.
+
+ (-[WKWebsiteDataStore _fetchDataRecordsOfTypes:withOptions:completionHandler:]):
+ Compute the right options.
+
+ * UIProcess/API/Cocoa/WKWebsiteDataStoreInternal.h:
+ Import WKWebsiteDataStorePrivate.h.
+
+ * UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
+ Add SPI.
+
+ * UIProcess/API/Cocoa/_WKWebsiteDataSize.h:
+ * UIProcess/API/Cocoa/_WKWebsiteDataSize.mm:
+ (-[_WKWebsiteDataSize initWithSize:]):
+ (-[_WKWebsiteDataSize totalSize]):
+ (-[_WKWebsiteDataSize sizeOfDataTypes:]):
+ Add _WKWebsiteDataSize header.
+
+ * UIProcess/API/Cocoa/_WKWebsiteDataSizeInternal.h: Add IPI header.
+
+ * UIProcess/Network/NetworkProcessProxy.cpp:
+ (WebKit::NetworkProcessProxy::fetchWebsiteData):
+ This now takes a OptionSet<WebsiteDataFetchOption>.
+
+ * UIProcess/Network/NetworkProcessProxy.h:
+ Update members.
+
+ * UIProcess/WebsiteData/WebsiteDataRecord.h:
+ Add a hash map from types to sizes.
+
+ * UIProcess/WebsiteData/WebsiteDataStore.cpp:
+ (WebKit::WebsiteDataStore::fetchData):
+ This now takes a OptionSet<WebsiteDataFetchOption>.
+
+ * UIProcess/WebsiteData/WebsiteDataStore.h:
+ Update member functions.
+
+ * WebKit2.xcodeproj/project.pbxproj:
+ Add new files.
+
+ * WebProcess/WebProcess.cpp:
+ (WebKit::WebProcess::fetchWebsiteData):
+ This now takes a OptionSet<WebsiteDataFetchOption>.
+
+2016-02-26 Anders Carlsson <[email protected]>
+
Add a toWebsiteDataType and reimplement toWebsiteDataTypes using it
https://bugs.webkit.org/show_bug.cgi?id=154746
Modified: trunk/Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp (197202 => 197203)
--- trunk/Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/DatabaseProcess/DatabaseProcess.cpp 2016-02-26 22:26:03 UTC (rev 197203)
@@ -228,7 +228,7 @@
RunLoop::main().dispatch([callbackAggregator, securityOrigins] {
for (const auto& securityOrigin : securityOrigins)
- callbackAggregator->m_websiteData.entries.append(WebsiteData::Entry { securityOrigin, WebsiteDataType::IndexedDBDatabases });
+ callbackAggregator->m_websiteData.entries.append(WebsiteData::Entry { securityOrigin, WebsiteDataType::IndexedDBDatabases, 0 });
});
}));
}
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp (197202 => 197203)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2016-02-26 22:26:03 UTC (rev 197203)
@@ -46,6 +46,7 @@
#include "WebCoreArgumentCoders.h"
#include "WebProcessPoolMessages.h"
#include "WebsiteData.h"
+#include "WebsiteDataFetchOption.h"
#include "WebsiteDataType.h"
#include <WebCore/DNS.h>
#include <WebCore/DiagnosticLoggingClient.h>
@@ -281,21 +282,24 @@
SessionTracker::destroySession(sessionID);
}
-static void fetchDiskCacheEntries(SessionID sessionID, std::function<void (Vector<WebsiteData::Entry>)> completionHandler)
+static void fetchDiskCacheEntries(SessionID sessionID, OptionSet<WebsiteDataFetchOption> fetchOptions, std::function<void (Vector<WebsiteData::Entry>)> completionHandler)
{
#if ENABLE(NETWORK_CACHE)
if (NetworkCache::singleton().isEnabled()) {
- auto* origins = new HashSet<RefPtr<SecurityOrigin>>();
+ auto* originsAndSizes = new HashMap<RefPtr<SecurityOrigin>, uint64_t>();
- NetworkCache::singleton().traverse([completionHandler, origins](const NetworkCache::Cache::TraversalEntry *traversalEntry) {
+ NetworkCache::singleton().traverse([fetchOptions, completionHandler, originsAndSizes](const NetworkCache::Cache::TraversalEntry *traversalEntry) {
if (!traversalEntry) {
Vector<WebsiteData::Entry> entries;
- for (auto& origin : *origins)
- entries.append(WebsiteData::Entry { origin, WebsiteDataType::DiskCache });
+ for (auto& originAndSize : *originsAndSizes) {
+ WebsiteData::Entry entry { originAndSize.key, WebsiteDataType::DiskCache, originAndSize.value };
- delete origins;
+ entries.append(WTFMove(entry));
+ }
+ delete originsAndSizes;
+
RunLoop::main().dispatch([completionHandler, entries] {
completionHandler(entries);
});
@@ -303,7 +307,10 @@
return;
}
- origins->add(SecurityOrigin::create(traversalEntry->entry.response().url()));
+ auto result = originsAndSizes->add(SecurityOrigin::create(traversalEntry->entry.response().url()), 0);
+
+ if (fetchOptions.contains(WebsiteDataFetchOption::ComputeSizes))
+ result.iterator->value += traversalEntry->entry.sourceStorageRecord().header.size() + traversalEntry->recordInfo.bodySize;
});
return;
@@ -314,7 +321,7 @@
#if USE(CFURLCACHE)
for (auto& origin : NetworkProcess::cfURLCacheOrigins())
- entries.append(WebsiteData::Entry { WTFMove(origin), WebsiteDataType::DiskCache });
+ entries.append(WebsiteData::Entry { WTFMove(origin), WebsiteDataType::DiskCache, 0 });
#endif
RunLoop::main().dispatch([completionHandler, entries] {
@@ -322,7 +329,7 @@
});
}
-void NetworkProcess::fetchWebsiteData(SessionID sessionID, OptionSet<WebsiteDataType> websiteDataTypes, uint64_t callbackID)
+void NetworkProcess::fetchWebsiteData(SessionID sessionID, OptionSet<WebsiteDataType> websiteDataTypes, OptionSet<WebsiteDataFetchOption> fetchOptions, uint64_t callbackID)
{
struct CallbackAggregator final : public RefCounted<CallbackAggregator> {
explicit CallbackAggregator(std::function<void (WebsiteData)> completionHandler)
@@ -356,7 +363,7 @@
}
if (websiteDataTypes.contains(WebsiteDataType::DiskCache)) {
- fetchDiskCacheEntries(sessionID, [callbackAggregator](Vector<WebsiteData::Entry> entries) {
+ fetchDiskCacheEntries(sessionID, fetchOptions, [callbackAggregator](Vector<WebsiteData::Entry> entries) {
callbackAggregator->m_websiteData.entries.appendVector(entries);
});
}
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h (197202 => 197203)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h 2016-02-26 22:26:03 UTC (rev 197203)
@@ -54,6 +54,7 @@
class AuthenticationManager;
class NetworkConnectionToWebProcess;
class NetworkProcessSupplement;
+enum class WebsiteDataFetchOption;
enum class WebsiteDataType;
struct NetworkProcessCreationParameters;
@@ -151,7 +152,7 @@
void ensurePrivateBrowsingSession(WebCore::SessionID);
void destroyPrivateBrowsingSession(WebCore::SessionID);
- void fetchWebsiteData(WebCore::SessionID, OptionSet<WebsiteDataType>, uint64_t callbackID);
+ void fetchWebsiteData(WebCore::SessionID, OptionSet<WebsiteDataType>, OptionSet<WebsiteDataFetchOption>, uint64_t callbackID);
void deleteWebsiteData(WebCore::SessionID, OptionSet<WebsiteDataType>, std::chrono::system_clock::time_point modifiedSince, uint64_t callbackID);
void deleteWebsiteDataForOrigins(WebCore::SessionID, OptionSet<WebsiteDataType>, const Vector<WebCore::SecurityOriginData>& origins, const Vector<String>& cookieHostNames, uint64_t callbackID);
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.messages.in (197202 => 197203)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.messages.in 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.messages.in 2016-02-26 22:26:03 UTC (rev 197203)
@@ -37,7 +37,7 @@
EnsurePrivateBrowsingSession(WebCore::SessionID sessionID)
DestroyPrivateBrowsingSession(WebCore::SessionID sessionID)
- FetchWebsiteData(WebCore::SessionID sessionID, OptionSet<WebKit::WebsiteDataType> websiteDataTypes, uint64_t callbackID)
+ FetchWebsiteData(WebCore::SessionID sessionID, OptionSet<WebKit::WebsiteDataType> websiteDataTypes, OptionSet<WebKit::WebsiteDataFetchOption> fetchOptions, uint64_t callbackID)
DeleteWebsiteData(WebCore::SessionID sessionID, OptionSet<WebKit::WebsiteDataType> websiteDataTypes, std::chrono::system_clock::time_point modifiedSince, uint64_t callbackID)
DeleteWebsiteDataForOrigins(WebCore::SessionID sessionID, OptionSet<WebKit::WebsiteDataType> websiteDataTypes, Vector<WebCore::SecurityOriginData> origins, Vector<String> cookieHostNames, uint64_t callbackID)
Modified: trunk/Source/WebKit2/Shared/WebsiteData/WebsiteData.cpp (197202 => 197203)
--- trunk/Source/WebKit2/Shared/WebsiteData/WebsiteData.cpp 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/Shared/WebsiteData/WebsiteData.cpp 2016-02-26 22:26:03 UTC (rev 197203)
@@ -36,6 +36,7 @@
{
encoder << WebCore::SecurityOriginData::fromSecurityOrigin(*origin);
encoder.encodeEnum(type);
+ encoder << size;
}
bool WebsiteData::Entry::decode(IPC::ArgumentDecoder& decoder, WebsiteData::Entry& result)
@@ -47,6 +48,9 @@
if (!decoder.decodeEnum(result.type))
return false;
+ if (!decoder.decode(result.size))
+ return false;
+
result.origin = securityOriginData.securityOrigin();
return true;
}
Modified: trunk/Source/WebKit2/Shared/WebsiteData/WebsiteData.h (197202 => 197203)
--- trunk/Source/WebKit2/Shared/WebsiteData/WebsiteData.h 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/Shared/WebsiteData/WebsiteData.h 2016-02-26 22:26:03 UTC (rev 197203)
@@ -27,6 +27,7 @@
#define WebsiteData_h
#include <WebCore/SecurityOrigin.h>
+#include <wtf/HashMap.h>
#include <wtf/HashSet.h>
#include <wtf/Vector.h>
@@ -43,6 +44,7 @@
struct Entry {
RefPtr<WebCore::SecurityOrigin> origin;
WebsiteDataType type;
+ uint64_t size;
void encode(IPC::ArgumentEncoder&) const;
static bool decode(IPC::ArgumentDecoder&, WebsiteData::Entry&);
Copied: trunk/Source/WebKit2/Shared/WebsiteData/WebsiteDataFetchOption.h (from rev 197197, trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h) (0 => 197203)
--- trunk/Source/WebKit2/Shared/WebsiteData/WebsiteDataFetchOption.h (rev 0)
+++ trunk/Source/WebKit2/Shared/WebsiteData/WebsiteDataFetchOption.h 2016-02-26 22:26:03 UTC (rev 197203)
@@ -0,0 +1,38 @@
+/*
+ * Copyright (C) 2016 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef WebsiteDataFetchOption_h
+#define WebsiteDataFetchOption_h
+
+namespace WebKit {
+
+enum class WebsiteDataFetchOption {
+ ComputeSizes = 1 << 0,
+};
+
+}
+
+
+#endif // WebsiteDataFetchOption_h
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKApplicationCacheManager.cpp (197202 => 197203)
--- trunk/Source/WebKit2/UIProcess/API/C/WKApplicationCacheManager.cpp 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKApplicationCacheManager.cpp 2016-02-26 22:26:03 UTC (rev 197203)
@@ -40,7 +40,7 @@
void WKApplicationCacheManagerGetApplicationCacheOrigins(WKApplicationCacheManagerRef applicationCacheManager, void* context, WKApplicationCacheManagerGetApplicationCacheOriginsFunction callback)
{
auto& websiteDataStore = toImpl(reinterpret_cast<WKWebsiteDataStoreRef>(applicationCacheManager))->websiteDataStore();
- websiteDataStore.fetchData(WebsiteDataType::OfflineWebApplicationCache, [context, callback](Vector<WebsiteDataRecord> dataRecords) {
+ websiteDataStore.fetchData(WebsiteDataType::OfflineWebApplicationCache, { }, [context, callback](Vector<WebsiteDataRecord> dataRecords) {
Vector<RefPtr<API::Object>> securityOrigins;
for (const auto& dataRecord : dataRecords) {
for (const auto& origin : dataRecord.origins)
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKResourceCacheManager.cpp (197202 => 197203)
--- trunk/Source/WebKit2/UIProcess/API/C/WKResourceCacheManager.cpp 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKResourceCacheManager.cpp 2016-02-26 22:26:03 UTC (rev 197203)
@@ -52,7 +52,7 @@
void WKResourceCacheManagerGetCacheOrigins(WKResourceCacheManagerRef cacheManager, void* context, WKResourceCacheManagerGetCacheOriginsFunction callback)
{
auto& websiteDataStore = toImpl(reinterpret_cast<WKWebsiteDataStoreRef>(cacheManager))->websiteDataStore();
- websiteDataStore.fetchData(toWebsiteDataTypes(WKResourceCachesToClearAll), [context, callback](Vector<WebsiteDataRecord> dataRecords) {
+ websiteDataStore.fetchData(toWebsiteDataTypes(WKResourceCachesToClearAll), { }, [context, callback](Vector<WebsiteDataRecord> dataRecords) {
Vector<RefPtr<API::Object>> securityOrigins;
for (const auto& dataRecord : dataRecords) {
for (const auto& origin : dataRecord.origins)
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataRecord.mm (197202 => 197203)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataRecord.mm 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataRecord.mm 2016-02-26 22:26:03 UTC (rev 197203)
@@ -28,6 +28,8 @@
#if WK_API_ENABLED
+#import "_WKWebsiteDataSizeInternal.h"
+
NSString * const WKWebsiteDataTypeDiskCache = @"WKWebsiteDataTypeDiskCache";
NSString * const WKWebsiteDataTypeMemoryCache = @"WKWebsiteDataTypeMemoryCache";
NSString * const WKWebsiteDataTypeOfflineWebApplicationCache = @"WKWebsiteDataTypeOfflineWebApplicationCache";
@@ -92,7 +94,13 @@
- (NSString *)description
{
- return [NSString stringWithFormat:@"<%@: %p; displayName = %@; dataTypes = { %@ }>", NSStringFromClass(self.class), self, self.displayName, dataTypesToString(self.dataTypes)];
+ auto result = adoptNS([[NSMutableString alloc] initWithFormat:@"<%@: %p; displayName = %@; dataTypes = { %@ }", NSStringFromClass(self.class), self, self.displayName, dataTypesToString(self.dataTypes)]);
+
+ if (auto* dataSize = self._dataSize)
+ [result appendFormat:@"; _dataSize = { %llu bytes }", dataSize.totalSize];
+
+ [result appendString:@">"];
+ return result.autorelease();
}
- (NSString *)displayName
@@ -114,4 +122,18 @@
@end
+@implementation WKWebsiteDataRecord (WKPrivate)
+
+- (_WKWebsiteDataSize *)_dataSize
+{
+ auto& size = _websiteDataRecord->websiteDataRecord().size;
+
+ if (!size)
+ return nil;
+
+ return [[[_WKWebsiteDataSize alloc] initWithSize:*size] autorelease];
+}
+
+@end
+
#endif
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h (197202 => 197203)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h 2016-02-26 22:26:03 UTC (rev 197203)
@@ -27,6 +27,10 @@
#if WK_API_ENABLED
+NS_ASSUME_NONNULL_BEGIN
+
+@class _WKWebsiteDataSize;
+
WK_EXTERN NSString * const _WKWebsiteDataTypeHSTSCache WK_AVAILABLE(10_11, 9_0);
WK_EXTERN NSString * const _WKWebsiteDataTypeMediaKeys WK_AVAILABLE(10_11, 9_0);
WK_EXTERN NSString * const _WKWebsiteDataTypeSearchFieldRecentSearches WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);
@@ -35,4 +39,12 @@
WK_EXTERN NSString * const _WKWebsiteDataTypePlugInData WK_AVAILABLE(10_11, NA);
#endif
+@interface WKWebsiteDataRecord (WKPrivate)
+
+@property (nullable, nonatomic, readonly) _WKWebsiteDataSize *_dataSize;
+
+@end
+
+NS_ASSUME_NONNULL_END
+
#endif
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm (197202 => 197203)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm 2016-02-26 22:26:03 UTC (rev 197203)
@@ -30,6 +30,7 @@
#import "WKNSArray.h"
#import "WKWebsiteDataRecordInternal.h"
+#import "WebsiteDataFetchOption.h"
#import <wtf/BlockPtr.h>
@implementation WKWebsiteDataStore
@@ -103,17 +104,7 @@
- (void)fetchDataRecordsOfTypes:(NSSet *)dataTypes completionHandler:(void (^)(WK_ARRAY(WKWebsiteDataRecord *) *))completionHandler
{
- auto completionHandlerCopy = makeBlockPtr(completionHandler);
-
- _websiteDataStore->websiteDataStore().fetchData(WebKit::toWebsiteDataTypes(dataTypes), [completionHandlerCopy](Vector<WebKit::WebsiteDataRecord> websiteDataRecords) {
- Vector<RefPtr<API::Object>> elements;
- elements.reserveInitialCapacity(websiteDataRecords.size());
-
- for (auto& websiteDataRecord : websiteDataRecords)
- elements.uncheckedAppend(API::WebsiteDataRecord::create(WTFMove(websiteDataRecord)));
-
- completionHandlerCopy(wrapper(API::Array::create(WTFMove(elements))));
- });
+ [self _fetchDataRecordsOfTypes:dataTypes withOptions:0 completionHandler:completionHandler];
}
- (void)removeDataOfTypes:(NSSet *)dataTypes modifiedSince:(NSDate *)date completionHandler:(void (^)(void))completionHandler
@@ -152,4 +143,27 @@
@end
+@implementation WKWebsiteDataStore (WKPrivate)
+
+- (void)_fetchDataRecordsOfTypes:(WK_SET(NSString *) *)dataTypes withOptions:(_WKWebsiteDataStoreFetchOptions)options completionHandler:(void (^)(WK_ARRAY(WKWebsiteDataRecord *) *))completionHandler
+{
+ auto completionHandlerCopy = makeBlockPtr(completionHandler);
+
+ OptionSet<WebKit::WebsiteDataFetchOption> fetchOptions;
+ if (options & _WKWebsiteDataStoreFetchOptionComputeSizes)
+ fetchOptions |= WebKit::WebsiteDataFetchOption::ComputeSizes;
+
+ _websiteDataStore->websiteDataStore().fetchData(WebKit::toWebsiteDataTypes(dataTypes), fetchOptions, [completionHandlerCopy](Vector<WebKit::WebsiteDataRecord> websiteDataRecords) {
+ Vector<RefPtr<API::Object>> elements;
+ elements.reserveInitialCapacity(websiteDataRecords.size());
+
+ for (auto& websiteDataRecord : websiteDataRecords)
+ elements.uncheckedAppend(API::WebsiteDataRecord::create(WTFMove(websiteDataRecord)));
+
+ completionHandlerCopy(wrapper(API::Array::create(WTFMove(elements))));
+ });
+}
+
+@end
+
#endif // WK_API_ENABLED
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStoreInternal.h (197202 => 197203)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStoreInternal.h 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStoreInternal.h 2016-02-26 22:26:03 UTC (rev 197203)
@@ -23,7 +23,7 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-#import "WKWebsiteDataStore.h"
+#import "WKWebsiteDataStorePrivate.h"
#if WK_API_ENABLED
Copied: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h (from rev 197197, trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStoreInternal.h) (0 => 197203)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h (rev 0)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h 2016-02-26 22:26:03 UTC (rev 197203)
@@ -0,0 +1,44 @@
+/*
+ * Copyright (C) 2016 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#import <WebKit/WKWebsiteDataStore.h>
+
+#if WK_API_ENABLED
+
+NS_ASSUME_NONNULL_BEGIN
+
+typedef NS_OPTIONS(NSUInteger, _WKWebsiteDataStoreFetchOptions) {
+ _WKWebsiteDataStoreFetchOptionComputeSizes = 1 << 0,
+} WK_ENUM_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);
+
+@interface WKWebsiteDataStore (WKPrivate)
+
+- (void)_fetchDataRecordsOfTypes:(WK_SET(NSString *) *)dataTypes withOptions:(_WKWebsiteDataStoreFetchOptions)options completionHandler:(void (^)(WK_ARRAY(WKWebsiteDataRecord *) *))completionHandler;
+
+@end
+
+NS_ASSUME_NONNULL_END
+
+#endif
Copied: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataSize.h (from rev 197197, trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h) (0 => 197203)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataSize.h (rev 0)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataSize.h 2016-02-26 22:26:03 UTC (rev 197203)
@@ -0,0 +1,45 @@
+/*
+ * Copyright (C) 2016 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#import <WebKit/WKFoundation.h>
+
+#if WK_API_ENABLED
+
+#import <Foundation/Foundation.h>
+
+NS_ASSUME_NONNULL_BEGIN
+
+WK_CLASS_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA)
+@interface _WKWebsiteDataSize : NSObject
+
+@property (nonatomic, readonly) unsigned long long totalSize;
+
+- (unsigned long long)sizeOfDataTypes:(WK_SET(NSString *) *)dataTypes;
+
+@end
+
+NS_ASSUME_NONNULL_END
+
+#endif
Copied: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataSize.mm (from rev 197197, trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStoreInternal.h) (0 => 197203)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataSize.mm (rev 0)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataSize.mm 2016-02-26 22:26:03 UTC (rev 197203)
@@ -0,0 +1,64 @@
+/*
+ * Copyright (C) 2016 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#import "config.h"
+#import "_WKWebsiteDataSizeInternal.h"
+
+#if WK_API_ENABLED
+
+#import "WKWebsiteDataRecordInternal.h"
+
+@implementation _WKWebsiteDataSize
+
+- (instancetype)initWithSize:(const WebKit::WebsiteDataRecord::Size&)size
+{
+ if (!(self = [super init]))
+ return nil;
+
+ _size = size;
+
+ return self;
+}
+
+- (unsigned long long)totalSize
+{
+ return _size.totalSize;
+}
+
+- (unsigned long long)sizeOfDataTypes:(NSSet<NSString *> *)dataTypes
+{
+ unsigned long long size = 0;
+
+ for (NSString *dataType in dataTypes) {
+ if (auto websiteDataType = WebKit::toWebsiteDataType(dataType))
+ size += _size.typeSizes.get(static_cast<unsigned>(*websiteDataType));
+ }
+
+ return size;
+}
+
+@end
+
+#endif
Copied: trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataSizeInternal.h (from rev 197197, trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h) (0 => 197203)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataSizeInternal.h (rev 0)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKWebsiteDataSizeInternal.h 2016-02-26 22:26:03 UTC (rev 197203)
@@ -0,0 +1,40 @@
+/*
+ * Copyright (C) 2016 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#import "_WKWebsiteDataSize.h"
+
+#if WK_API_ENABLED
+
+#import "WebsiteDataRecord.h"
+
+@interface _WKWebsiteDataSize () {
+ WebKit::WebsiteDataRecord::Size _size;
+}
+
+- (instancetype)initWithSize:(const WebKit::WebsiteDataRecord::Size&)size;
+
+@end
+
+#endif
Modified: trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp (197202 => 197203)
--- trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp 2016-02-26 22:26:03 UTC (rev 197203)
@@ -118,7 +118,7 @@
return m_downloadProxyMap->createDownloadProxy(m_processPool, resourceRequest);
}
-void NetworkProcessProxy::fetchWebsiteData(SessionID sessionID, OptionSet<WebsiteDataType> dataTypes, std::function<void (WebsiteData)> completionHandler)
+void NetworkProcessProxy::fetchWebsiteData(SessionID sessionID, OptionSet<WebsiteDataType> dataTypes, OptionSet<WebsiteDataFetchOption> fetchOptions, std::function<void (WebsiteData)> completionHandler)
{
ASSERT(canSendMessage());
@@ -129,7 +129,7 @@
completionHandler(WTFMove(websiteData));
});
- send(Messages::WebProcess::FetchWebsiteData(sessionID, dataTypes, callbackID), 0);
+ send(Messages::NetworkProcess::FetchWebsiteData(sessionID, dataTypes, fetchOptions, callbackID), 0);
}
void NetworkProcessProxy::deleteWebsiteData(WebCore::SessionID sessionID, OptionSet<WebsiteDataType> dataTypes, std::chrono::system_clock::time_point modifiedSince, std::function<void ()> completionHandler)
Modified: trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h (197202 => 197203)
--- trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/UIProcess/Network/NetworkProcessProxy.h 2016-02-26 22:26:03 UTC (rev 197203)
@@ -47,6 +47,7 @@
class DownloadProxy;
class DownloadProxyMap;
class WebProcessPool;
+enum class WebsiteDataFetchOption;
enum class WebsiteDataType;
struct NetworkProcessCreationParameters;
@@ -59,7 +60,7 @@
DownloadProxy* createDownloadProxy(const WebCore::ResourceRequest&);
- void fetchWebsiteData(WebCore::SessionID, OptionSet<WebsiteDataType>, std::function<void (WebsiteData)> completionHandler);
+ void fetchWebsiteData(WebCore::SessionID, OptionSet<WebsiteDataType>, OptionSet<WebsiteDataFetchOption>, std::function<void (WebsiteData)> completionHandler);
void deleteWebsiteData(WebCore::SessionID, OptionSet<WebsiteDataType>, std::chrono::system_clock::time_point modifiedSince, std::function<void ()> completionHandler);
void deleteWebsiteDataForOrigins(WebCore::SessionID, OptionSet<WebKit::WebsiteDataType>, const Vector<RefPtr<WebCore::SecurityOrigin>>& origins, const Vector<String>& cookieHostNames, std::function<void ()> completionHandler);
Modified: trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataRecord.h (197202 => 197203)
--- trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataRecord.h 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataRecord.h 2016-02-26 22:26:03 UTC (rev 197203)
@@ -30,6 +30,7 @@
#include <WebCore/SecurityOriginHash.h>
#include <wtf/HashSet.h>
#include <wtf/OptionSet.h>
+#include <wtf/Optional.h>
#include <wtf/text/StringHash.h>
#include <wtf/text/WTFString.h>
@@ -54,6 +55,13 @@
String displayName;
OptionSet<WebsiteDataType> types;
+
+ struct Size {
+ uint64_t totalSize;
+ HashMap<unsigned, uint64_t> typeSizes;
+ };
+ Optional<Size> size;
+
HashSet<RefPtr<WebCore::SecurityOrigin>> origins;
HashSet<String> cookieHostNames;
#if ENABLE(NETSCAPE_PLUGIN_API)
Modified: trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp (197202 => 197203)
--- trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp 2016-02-26 22:26:03 UTC (rev 197203)
@@ -150,11 +150,12 @@
return processAccessType;
}
-void WebsiteDataStore::fetchData(OptionSet<WebsiteDataType> dataTypes, std::function<void (Vector<WebsiteDataRecord>)> completionHandler)
+void WebsiteDataStore::fetchData(OptionSet<WebsiteDataType> dataTypes, OptionSet<WebsiteDataFetchOption> fetchOptions, std::function<void (Vector<WebsiteDataRecord>)> completionHandler)
{
struct CallbackAggregator final : ThreadSafeRefCounted<CallbackAggregator> {
- explicit CallbackAggregator(std::function<void (Vector<WebsiteDataRecord>)> completionHandler)
- : completionHandler(WTFMove(completionHandler))
+ explicit CallbackAggregator(OptionSet<WebsiteDataFetchOption> fetchOptions, std::function<void (Vector<WebsiteDataRecord>)> completionHandler)
+ : fetchOptions(fetchOptions)
+ , completionHandler(WTFMove(completionHandler))
{
}
@@ -183,6 +184,14 @@
record.displayName = WTFMove(displayName);
record.add(entry.type, WTFMove(entry.origin));
+
+ if (fetchOptions.contains(WebsiteDataFetchOption::ComputeSizes)) {
+ if (!record.size)
+ record.size = WebsiteDataRecord::Size { 0, { } };
+
+ record.size->totalSize += entry.size;
+ record.size->typeSizes.add(static_cast<unsigned>(entry.type), 0).iterator->value += entry.size;
+ }
}
for (auto& hostName : websiteData.hostNamesWithCookies) {
@@ -232,13 +241,15 @@
});
}
+ const OptionSet<WebsiteDataFetchOption> fetchOptions;
+
unsigned pendingCallbacks = 0;
std::function<void (Vector<WebsiteDataRecord>)> completionHandler;
HashMap<String, WebsiteDataRecord> m_websiteDataRecords;
};
- RefPtr<CallbackAggregator> callbackAggregator = adoptRef(new CallbackAggregator(WTFMove(completionHandler)));
+ RefPtr<CallbackAggregator> callbackAggregator = adoptRef(new CallbackAggregator(fetchOptions, WTFMove(completionHandler)));
auto networkProcessAccessType = computeNetworkProcessAccessTypeForDataFetch(dataTypes, !isPersistent());
if (networkProcessAccessType != ProcessAccessType::None) {
@@ -258,7 +269,7 @@
}
callbackAggregator->addPendingCallback();
- processPool->networkProcess()->fetchWebsiteData(m_sessionID, dataTypes, [callbackAggregator, processPool](WebsiteData websiteData) {
+ processPool->networkProcess()->fetchWebsiteData(m_sessionID, dataTypes, fetchOptions, [callbackAggregator, processPool](WebsiteData websiteData) {
callbackAggregator->removePendingCallback(WTFMove(websiteData));
});
}
@@ -296,7 +307,7 @@
WebsiteData websiteData;
while (!origins.isEmpty())
- websiteData.entries.append(WebsiteData::Entry { origins.takeAny(), WebsiteDataType::SessionStorage });
+ websiteData.entries.append(WebsiteData::Entry { origins.takeAny(), WebsiteDataType::SessionStorage, 0 });
callbackAggregator->removePendingCallback(WTFMove(websiteData));
});
@@ -309,7 +320,7 @@
WebsiteData websiteData;
while (!origins.isEmpty())
- websiteData.entries.append(WebsiteData::Entry { origins.takeAny(), WebsiteDataType::LocalStorage });
+ websiteData.entries.append(WebsiteData::Entry { origins.takeAny(), WebsiteDataType::LocalStorage, 0 });
callbackAggregator->removePendingCallback(WTFMove(websiteData));
});
@@ -320,19 +331,25 @@
callbackAggregator->addPendingCallback();
- m_queue->dispatch([applicationCacheDirectory, callbackAggregator] {
+ m_queue->dispatch([fetchOptions, applicationCacheDirectory, callbackAggregator] {
auto storage = WebCore::ApplicationCacheStorage::create(applicationCacheDirectory.string(), "Files");
+ WebsiteData* websiteData = new WebsiteData;
+
HashSet<RefPtr<WebCore::SecurityOrigin>> origins;
storage->getOriginsWithCache(origins);
- WTF::RunLoop::main().dispatch([callbackAggregator, origins]() mutable {
- WebsiteData websiteData;
+ for (auto& origin : origins) {
+ uint64_t size = fetchOptions.contains(WebsiteDataFetchOption::ComputeSizes) ? storage->diskUsageForOrigin(*origin) : 0;
+ WebsiteData::Entry entry { origin, WebsiteDataType::OfflineWebApplicationCache, size };
- for (auto& origin : origins)
- websiteData.entries.append(WebsiteData::Entry { origin, WebsiteDataType::OfflineWebApplicationCache });
+ websiteData->entries.append(WTFMove(entry));
+ }
- callbackAggregator->removePendingCallback(WTFMove(websiteData));
+ WTF::RunLoop::main().dispatch([callbackAggregator, origins, websiteData]() mutable {
+ callbackAggregator->removePendingCallback(WTFMove(*websiteData));
+
+ delete websiteData;
});
});
}
@@ -349,7 +366,7 @@
RunLoop::main().dispatch([callbackAggregator, origins]() mutable {
WebsiteData websiteData;
for (auto& origin : origins)
- websiteData.entries.append(WebsiteData::Entry { WTFMove(origin), WebsiteDataType::WebSQLDatabases });
+ websiteData.entries.append(WebsiteData::Entry { WTFMove(origin), WebsiteDataType::WebSQLDatabases, 0 });
callbackAggregator->removePendingCallback(WTFMove(websiteData));
});
@@ -380,7 +397,7 @@
RunLoop::main().dispatch([callbackAggregator, origins]() mutable {
WebsiteData websiteData;
for (auto& origin : origins)
- websiteData.entries.append(WebsiteData::Entry { WTFMove(origin), WebsiteDataType::MediaKeys });
+ websiteData.entries.append(WebsiteData::Entry { WTFMove(origin), WebsiteDataType::MediaKeys, 0 });
callbackAggregator->removePendingCallback(WTFMove(websiteData));
});
Modified: trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h (197202 => 197203)
--- trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.h 2016-02-26 22:26:03 UTC (rev 197203)
@@ -46,6 +46,7 @@
class StorageManager;
class WebPageProxy;
class WebProcessPool;
+enum class WebsiteDataFetchOption;
enum class WebsiteDataType;
struct WebsiteDataRecord;
@@ -74,7 +75,7 @@
static void cloneSessionData(WebPageProxy& sourcePage, WebPageProxy& newPage);
- void fetchData(OptionSet<WebsiteDataType>, std::function<void (Vector<WebsiteDataRecord>)> completionHandler);
+ void fetchData(OptionSet<WebsiteDataType>, OptionSet<WebsiteDataFetchOption>, std::function<void (Vector<WebsiteDataRecord>)> completionHandler);
void removeData(OptionSet<WebsiteDataType>, std::chrono::system_clock::time_point modifiedSince, std::function<void ()> completionHandler);
void removeData(OptionSet<WebsiteDataType>, const Vector<WebsiteDataRecord>&, std::function<void ()> completionHandler);
Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (197202 => 197203)
--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2016-02-26 22:26:03 UTC (rev 197203)
@@ -235,8 +235,6 @@
1A44B95B16B73F9F00B7BBD8 /* StorageManager.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A44B95916B73F9F00B7BBD8 /* StorageManager.cpp */; };
1A44B95C16B73F9F00B7BBD8 /* StorageManager.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A44B95A16B73F9F00B7BBD8 /* StorageManager.h */; };
1A4832C31A965A3C008B4DFE /* WebsiteDataStoreCocoa.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A4832C11A965A3C008B4DFE /* WebsiteDataStoreCocoa.mm */; };
- 1A4832C71A9BC13C008B4DFE /* APIWebsiteDataRecord.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A4832C51A9BC13C008B4DFE /* APIWebsiteDataRecord.cpp */; };
- 1A4832C81A9BC13C008B4DFE /* APIWebsiteDataRecord.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A4832C61A9BC13C008B4DFE /* APIWebsiteDataRecord.h */; };
1A4832CB1A9BC465008B4DFE /* WKWebsiteDataRecord.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A4832C91A9BC465008B4DFE /* WKWebsiteDataRecord.mm */; };
1A4832CC1A9BC465008B4DFE /* WKWebsiteDataRecord.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A4832CA1A9BC465008B4DFE /* WKWebsiteDataRecord.h */; settings = {ATTRIBUTES = (Public, ); }; };
1A4832CE1A9BC484008B4DFE /* WKWebsiteDataRecordInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A4832CD1A9BC484008B4DFE /* WKWebsiteDataRecordInternal.h */; };
@@ -470,6 +468,12 @@
1AE00D6B18327C1200087DD7 /* StringReference.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1AE00D6918327C1200087DD7 /* StringReference.cpp */; };
1AE00D6C18327C1200087DD7 /* StringReference.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AE00D6A18327C1200087DD7 /* StringReference.h */; };
1AE117F611DBB30900981615 /* ProcessLauncher.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1AE117F511DBB30900981615 /* ProcessLauncher.cpp */; };
+ 1AE286771C7E76510069AC4F /* _WKWebsiteDataSize.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1AE286751C7E76510069AC4F /* _WKWebsiteDataSize.mm */; };
+ 1AE286781C7E76510069AC4F /* _WKWebsiteDataSize.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AE286761C7E76510069AC4F /* _WKWebsiteDataSize.h */; };
+ 1AE2867A1C7F7BA60069AC4F /* WKWebsiteDataStorePrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AE286791C7F7BA60069AC4F /* WKWebsiteDataStorePrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ 1AE286801C7F92C00069AC4F /* _WKWebsiteDataSizeInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AE2867F1C7F92BF0069AC4F /* _WKWebsiteDataSizeInternal.h */; };
+ 1AE286831C7F93860069AC4F /* APIWebsiteDataRecord.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1AE286811C7F93860069AC4F /* APIWebsiteDataRecord.cpp */; };
+ 1AE286841C7F93860069AC4F /* APIWebsiteDataRecord.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AE286821C7F93860069AC4F /* APIWebsiteDataRecord.h */; };
1AE4976811FF658E0048B464 /* NPJSObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AE4976611FF658E0048B464 /* NPJSObject.h */; };
1AE4976911FF658E0048B464 /* NPJSObject.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1AE4976711FF658E0048B464 /* NPJSObject.cpp */; };
1AE4987811FF7FAA0048B464 /* JSNPObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 1AE4987611FF7FAA0048B464 /* JSNPObject.h */; };
@@ -2097,6 +2101,7 @@
1A256E3518A1A788006FB922 /* WKNavigationAction.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKNavigationAction.mm; sourceTree = "<group>"; };
1A256E3618A1A788006FB922 /* WKNavigationAction.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKNavigationAction.h; sourceTree = "<group>"; };
1A256E3918A1A7DF006FB922 /* WKNavigationActionInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKNavigationActionInternal.h; sourceTree = "<group>"; };
+ 1A28B8CB1C80ED59006FD743 /* WebsiteDataFetchOption.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebsiteDataFetchOption.h; sourceTree = "<group>"; };
1A2A4AFD158693920090C9E9 /* ColorSpaceData.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ColorSpaceData.mm; sourceTree = "<group>"; };
1A2A4AFE158693920090C9E9 /* ColorSpaceData.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ColorSpaceData.h; sourceTree = "<group>"; };
1A2BB6CC14117A5F000F35D4 /* PluginProcessConnection.messages.in */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = PluginProcessConnection.messages.in; sourceTree = "<group>"; };
@@ -2151,8 +2156,6 @@
1A44B95916B73F9F00B7BBD8 /* StorageManager.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = StorageManager.cpp; sourceTree = "<group>"; };
1A44B95A16B73F9F00B7BBD8 /* StorageManager.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StorageManager.h; sourceTree = "<group>"; };
1A4832C11A965A3C008B4DFE /* WebsiteDataStoreCocoa.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebsiteDataStoreCocoa.mm; sourceTree = "<group>"; };
- 1A4832C51A9BC13C008B4DFE /* APIWebsiteDataRecord.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = APIWebsiteDataRecord.cpp; sourceTree = "<group>"; };
- 1A4832C61A9BC13C008B4DFE /* APIWebsiteDataRecord.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = APIWebsiteDataRecord.h; sourceTree = "<group>"; };
1A4832C91A9BC465008B4DFE /* WKWebsiteDataRecord.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKWebsiteDataRecord.mm; sourceTree = "<group>"; };
1A4832CA1A9BC465008B4DFE /* WKWebsiteDataRecord.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKWebsiteDataRecord.h; sourceTree = "<group>"; };
1A4832CD1A9BC484008B4DFE /* WKWebsiteDataRecordInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKWebsiteDataRecordInternal.h; sourceTree = "<group>"; };
@@ -2415,6 +2418,12 @@
1AE00D6918327C1200087DD7 /* StringReference.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = StringReference.cpp; sourceTree = "<group>"; };
1AE00D6A18327C1200087DD7 /* StringReference.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = StringReference.h; sourceTree = "<group>"; };
1AE117F511DBB30900981615 /* ProcessLauncher.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ProcessLauncher.cpp; sourceTree = "<group>"; };
+ 1AE286751C7E76510069AC4F /* _WKWebsiteDataSize.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = _WKWebsiteDataSize.mm; sourceTree = "<group>"; };
+ 1AE286761C7E76510069AC4F /* _WKWebsiteDataSize.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = _WKWebsiteDataSize.h; sourceTree = "<group>"; };
+ 1AE286791C7F7BA60069AC4F /* WKWebsiteDataStorePrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKWebsiteDataStorePrivate.h; sourceTree = "<group>"; };
+ 1AE2867F1C7F92BF0069AC4F /* _WKWebsiteDataSizeInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = _WKWebsiteDataSizeInternal.h; sourceTree = "<group>"; };
+ 1AE286811C7F93860069AC4F /* APIWebsiteDataRecord.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = APIWebsiteDataRecord.cpp; sourceTree = "<group>"; };
+ 1AE286821C7F93860069AC4F /* APIWebsiteDataRecord.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = APIWebsiteDataRecord.h; sourceTree = "<group>"; };
1AE4976611FF658E0048B464 /* NPJSObject.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NPJSObject.h; sourceTree = "<group>"; };
1AE4976711FF658E0048B464 /* NPJSObject.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = NPJSObject.cpp; sourceTree = "<group>"; };
1AE4987611FF7FAA0048B464 /* JSNPObject.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSNPObject.h; sourceTree = "<group>"; };
@@ -4607,6 +4616,7 @@
children = (
1A4832D41A9CDF96008B4DFE /* WebsiteData.cpp */,
1A4832D51A9CDF96008B4DFE /* WebsiteData.h */,
+ 1A28B8CB1C80ED59006FD743 /* WebsiteDataFetchOption.h */,
1ABF43791A368050003FB0E6 /* WebsiteDataType.h */,
);
path = WebsiteData;
@@ -4983,6 +4993,9 @@
1A81B37F18BD66AD0007FDAC /* _WKVisitedLinkStore.h */,
1A81B37E18BD66AD0007FDAC /* _WKVisitedLinkStore.mm */,
1A81B38418BD673A0007FDAC /* _WKVisitedLinkStoreInternal.h */,
+ 1AE286751C7E76510069AC4F /* _WKWebsiteDataSize.mm */,
+ 1AE286761C7E76510069AC4F /* _WKWebsiteDataSize.h */,
+ 1AE2867F1C7F92BF0069AC4F /* _WKWebsiteDataSizeInternal.h */,
FED3C1DA1B447AE800E0EB7F /* APISerializedScriptValueCocoa.mm */,
7CEFA9601AC0999300B910FD /* APIUserContentExtensionStoreCocoa.mm */,
1A3635AB1A3145E500ED6197 /* APIWebsiteDataStoreCocoa.mm */,
@@ -5051,6 +5064,7 @@
75A8D2C4187CCF9F00C39C9E /* WKWebsiteDataStore.h */,
75A8D2C5187CCF9F00C39C9E /* WKWebsiteDataStore.mm */,
75A8D2D4187D1C0100C39C9E /* WKWebsiteDataStoreInternal.h */,
+ 1AE286791C7F7BA60069AC4F /* WKWebsiteDataStorePrivate.h */,
1A3CC16518906ACF001E6ED8 /* WKWebView.h */,
1A3CC16418906ACF001E6ED8 /* WKWebView.mm */,
1ADF59191890528E0043C145 /* WKWebViewConfiguration.h */,
@@ -5895,6 +5909,8 @@
BC032DC410F4387C0058C15A /* API */ = {
isa = PBXGroup;
children = (
+ 1AE286811C7F93860069AC4F /* APIWebsiteDataRecord.cpp */,
+ 1AE286821C7F93860069AC4F /* APIWebsiteDataRecord.h */,
BC0C376610F807660076D7CB /* C */,
37C4C08318149C2A003688B9 /* Cocoa */,
BC8A501311765F4500757573 /* cpp */,
@@ -5941,8 +5957,6 @@
7C89D2921A67122F003A5FDE /* APIUserScript.h */,
2D8786211BDB58FF00D02ABB /* APIUserStyleSheet.cpp */,
2D8786221BDB58FF00D02ABB /* APIUserStyleSheet.h */,
- 1A4832C51A9BC13C008B4DFE /* APIWebsiteDataRecord.cpp */,
- 1A4832C61A9BC13C008B4DFE /* APIWebsiteDataRecord.h */,
1A3635A71A3144A300ED6197 /* APIWebsiteDataStore.cpp */,
1A3635A81A3144A300ED6197 /* APIWebsiteDataStore.h */,
1A6563E21B7A8C50009CF787 /* APIWindowFeatures.cpp */,
@@ -7122,6 +7136,7 @@
93E6A4EE1BC5DD3900F8A0E7 /* _WKHitTestResult.h in Headers */,
93A88B3B1BC710D900ABA5C2 /* _WKHitTestResultInternal.h in Headers */,
37A64E5518F38E3C00EB30F1 /* _WKInputDelegate.h in Headers */,
+ 1AE2867A1C7F7BA60069AC4F /* WKWebsiteDataStorePrivate.h in Headers */,
9955A6EF1C79810800EB6A93 /* Automation.json in Headers */,
2D790A9D1AD7050D00AB90B3 /* _WKLayoutMode.h in Headers */,
A118A9F31908B8EA00F7C92B /* _WKNSFileManagerExtras.h in Headers */,
@@ -7204,7 +7219,6 @@
2D8786241BDB58FF00D02ABB /* APIUserStyleSheet.h in Headers */,
C5E1AFED16B21017006CC1F2 /* APIWebArchive.h in Headers */,
C5E1AFEF16B21029006CC1F2 /* APIWebArchiveResource.h in Headers */,
- 1A4832C81A9BC13C008B4DFE /* APIWebsiteDataRecord.h in Headers */,
C5BCE5DF1C50766A00CDE3FA /* InteractionInformationAtPosition.h in Headers */,
1A3635AA1A3144A300ED6197 /* APIWebsiteDataStore.h in Headers */,
1A6563E51B7A8C50009CF787 /* APIWindowFeatures.h in Headers */,
@@ -7335,6 +7349,7 @@
1ABC3DF61899E437004F0626 /* NavigationState.h in Headers */,
1A6FBA2A11E6862700DB1371 /* NetscapeBrowserFuncs.h in Headers */,
990D28AB1C6420C600986977 /* _WKAutomationSession.h in Headers */,
+ 1AE286801C7F92C00069AC4F /* _WKWebsiteDataSizeInternal.h in Headers */,
1A6FBD2811E69BC200DB1371 /* NetscapePlugin.h in Headers */,
1A4A9C5612B816CF008FE984 /* NetscapePluginModule.h in Headers */,
1AA5889211EE70400061B882 /* NetscapePluginStream.h in Headers */,
@@ -7858,6 +7873,7 @@
37C4C0941814B3AF003688B9 /* WKNSArray.h in Headers */,
373CEAD6185417AE008C363D /* WKNSData.h in Headers */,
371A19421824D29300F32A5E /* WKNSDictionary.h in Headers */,
+ 1AE286781C7E76510069AC4F /* _WKWebsiteDataSize.h in Headers */,
372CAF0B1833FD910040AC27 /* WKNSError.h in Headers */,
378E1A4A18208CD60031007A /* WKNSString.h in Headers */,
378E1A4E18208D700031007A /* WKNSURL.h in Headers */,
@@ -7879,6 +7895,7 @@
1AB8A1F018400B0000E9AE69 /* WKPageFormClient.h in Headers */,
BC7B633712A45ABA00D174A4 /* WKPageGroup.h in Headers */,
2D9EA30D1A96CB59002D2807 /* WKPageInjectedBundleClient.h in Headers */,
+ 1AE286841C7F93860069AC4F /* APIWebsiteDataRecord.h in Headers */,
1AB8A1EC1840080900E9AE69 /* WKPageLoaderClient.h in Headers */,
BC2D021912AC426C00E732A3 /* WKPageLoadTypes.h in Headers */,
93BDEB01171DD7AF00BFEE1B /* WKPageLoadTypesPrivate.h in Headers */,
@@ -8643,7 +8660,6 @@
2D8786231BDB58FF00D02ABB /* APIUserStyleSheet.cpp in Sources */,
C5E1AFEC16B21012006CC1F2 /* APIWebArchive.mm in Sources */,
C5E1AFEE16B21025006CC1F2 /* APIWebArchiveResource.mm in Sources */,
- 1A4832C71A9BC13C008B4DFE /* APIWebsiteDataRecord.cpp in Sources */,
1A3635A91A3144A300ED6197 /* APIWebsiteDataStore.cpp in Sources */,
1A3635AD1A3145E500ED6197 /* APIWebsiteDataStoreCocoa.mm in Sources */,
1A6563E41B7A8C50009CF787 /* APIWindowFeatures.cpp in Sources */,
@@ -8681,6 +8697,7 @@
B878B616133428DC006888E9 /* CorrectionPanel.mm in Sources */,
2984F588164BA095004BC0C6 /* CustomProtocolManagerMessageReceiver.cpp in Sources */,
29AD3096164B4C930072DEA9 /* CustomProtocolManagerProxyMac.mm in Sources */,
+ 1AE286831C7F93860069AC4F /* APIWebsiteDataRecord.cpp in Sources */,
2984F57C164B915F004BC0C6 /* CustomProtocolManagerProxyMessageReceiver.cpp in Sources */,
51E351FF180F5D0F00E53BE9 /* DatabaseProcess.cpp in Sources */,
515E772B184008B90007203F /* DatabaseProcessCreationParameters.cpp in Sources */,
@@ -9247,6 +9264,7 @@
C57193BE18C14A44002D0F12 /* WKFormSelectControl.mm in Sources */,
C55CB5B818C2A5D600CA81E1 /* WKFormSelectPicker.mm in Sources */,
C55CB5B718C269CF00CA81E1 /* WKFormSelectPopover.mm in Sources */,
+ 1AE286771C7E76510069AC4F /* _WKWebsiteDataSize.mm in Sources */,
BCE469591214EDF4000B98EB /* WKFormSubmissionListener.cpp in Sources */,
BCD0139C110FA420003B8A67 /* WKFrame.cpp in Sources */,
1A4D664B18A3030E00D82E21 /* WKFrameInfo.mm in Sources */,
Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (197202 => 197203)
--- trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2016-02-26 22:26:03 UTC (rev 197203)
@@ -1117,7 +1117,7 @@
if (websiteDataTypes.contains(WebsiteDataType::MemoryCache)) {
for (auto& origin : MemoryCache::singleton().originsWithCache(sessionID))
- websiteData.entries.append(WebsiteData::Entry { origin, WebsiteDataType::MemoryCache });
+ websiteData.entries.append(WebsiteData::Entry { origin, WebsiteDataType::MemoryCache, 0 });
}
parentProcessConnection()->send(Messages::WebProcessProxy::DidFetchWebsiteData(callbackID, websiteData), 0);
Modified: trunk/Tools/ChangeLog (197202 => 197203)
--- trunk/Tools/ChangeLog 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Tools/ChangeLog 2016-02-26 22:26:03 UTC (rev 197203)
@@ -1,3 +1,15 @@
+2016-02-26 Anders Carlsson <[email protected]>
+
+ WKWebsiteDataStore/WKWebsiteDataRecord needs to provide size information about each type of data
+ https://bugs.webkit.org/show_bug.cgi?id=154750
+ rdar://problem/23861395
+
+ Reviewed by Tim Horton.
+
+ * MiniBrowser/mac/WK2BrowserWindowController.m:
+ (-[WK2BrowserWindowController fetchWebsiteData:]):
+ Use the new WKWebsiteDataStore SPI to compute data sizes.
+
2016-02-25 Gavin Barraclough <[email protected]>
RefCounter value changed callback should be called on all changes (not just zero edge).
Modified: trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m (197202 => 197203)
--- trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2016-02-26 22:24:29 UTC (rev 197202)
+++ trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2016-02-26 22:26:03 UTC (rev 197203)
@@ -35,6 +35,7 @@
#import <WebKit/WKUIDelegate.h>
#import <WebKit/WKWebViewConfigurationPrivate.h>
#import <WebKit/WKWebViewPrivate.h>
+#import <WebKit/WKWebsiteDataStorePrivate.h>
#import <WebKit/WebNSURLExtras.h>
static void* keyValueObservingContext = &keyValueObservingContext;
@@ -479,7 +480,7 @@
- (IBAction)fetchWebsiteData:(id)sender
{
- [_configuration.websiteDataStore fetchDataRecordsOfTypes:dataTypes() completionHandler:^(NSArray *websiteDataRecords) {
+ [_configuration.websiteDataStore _fetchDataRecordsOfTypes:dataTypes() withOptions:_WKWebsiteDataStoreFetchOptionComputeSizes completionHandler:^(NSArray *websiteDataRecords) {
NSLog(@"did fetch website data %@.", websiteDataRecords);
}];
}
