Title: [197406] trunk
- Revision
- 197406
- Author
- commit-qu...@webkit.org
- Date
- 2016-03-01 11:47:31 -0800 (Tue, 01 Mar 2016)
Log Message
Unreviewed, rolling out r197056.
https://bugs.webkit.org/show_bug.cgi?id=154870
broke win ews (Requested by alexchristensen on #webkit).
Reverted changeset:
"[cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK."
https://bugs.webkit.org/show_bug.cgi?id=154651
http://trac.webkit.org/changeset/197056
Modified Paths
Diff
Modified: trunk/ChangeLog (197405 => 197406)
--- trunk/ChangeLog 2016-03-01 19:41:46 UTC (rev 197405)
+++ trunk/ChangeLog 2016-03-01 19:47:31 UTC (rev 197406)
@@ -1,3 +1,16 @@
+2016-03-01 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r197056.
+ https://bugs.webkit.org/show_bug.cgi?id=154870
+
+ broke win ews (Requested by alexchristensen on #webkit).
+
+ Reverted changeset:
+
+ "[cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK."
+ https://bugs.webkit.org/show_bug.cgi?id=154651
+ http://trac.webkit.org/changeset/197056
+
2016-02-29 Konstantin Tokarev <annu...@yandex.ru>
[cmake] Allow using FindGLIB in case glib is optional dependency.
Modified: trunk/Source/_javascript_Core/CMakeLists.txt (197405 => 197406)
--- trunk/Source/_javascript_Core/CMakeLists.txt 2016-03-01 19:41:46 UTC (rev 197405)
+++ trunk/Source/_javascript_Core/CMakeLists.txt 2016-03-01 19:47:31 UTC (rev 197406)
@@ -1311,6 +1311,14 @@
WEBKIT_WRAP_SOURCELIST(${_javascript_Core_SOURCES})
WEBKIT_FRAMEWORK(_javascript_Core)
+if (_javascript_Core_PRE_BUILD_COMMAND)
+ add_custom_command(TARGET _javascript_Core PRE_BUILD COMMAND ${_javascript_Core_PRE_BUILD_COMMAND} VERBATIM)
+endif ()
+
+if (_javascript_Core_POST_BUILD_COMMAND)
+ add_custom_command(TARGET _javascript_Core POST_BUILD COMMAND ${_javascript_Core_POST_BUILD_COMMAND} VERBATIM)
+endif ()
+
if (${_javascript_Core_LIBRARY_TYPE} STREQUAL "SHARED")
POPULATE_LIBRARY_VERSION(_javascript_CORE)
set_target_properties(_javascript_Core PROPERTIES VERSION ${_javascript_CORE_VERSION} SOVERSION ${_javascript_CORE_VERSION_MAJOR})
Modified: trunk/Source/_javascript_Core/ChangeLog (197405 => 197406)
--- trunk/Source/_javascript_Core/ChangeLog 2016-03-01 19:41:46 UTC (rev 197405)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-03-01 19:47:31 UTC (rev 197406)
@@ -1,3 +1,16 @@
+2016-03-01 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r197056.
+ https://bugs.webkit.org/show_bug.cgi?id=154870
+
+ broke win ews (Requested by alexchristensen on #webkit).
+
+ Reverted changeset:
+
+ "[cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK."
+ https://bugs.webkit.org/show_bug.cgi?id=154651
+ http://trac.webkit.org/changeset/197056
+
2016-02-29 Saam barati <sbar...@apple.com>
[[PreventExtensions]] should be a virtual method in the method table.
Modified: trunk/Source/WTF/ChangeLog (197405 => 197406)
--- trunk/Source/WTF/ChangeLog 2016-03-01 19:41:46 UTC (rev 197405)
+++ trunk/Source/WTF/ChangeLog 2016-03-01 19:47:31 UTC (rev 197406)
@@ -1,3 +1,16 @@
+2016-03-01 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r197056.
+ https://bugs.webkit.org/show_bug.cgi?id=154870
+
+ broke win ews (Requested by alexchristensen on #webkit).
+
+ Reverted changeset:
+
+ "[cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK."
+ https://bugs.webkit.org/show_bug.cgi?id=154651
+ http://trac.webkit.org/changeset/197056
+
2016-02-29 Gavin Barraclough <barraclo...@apple.com>
RefCounter<T>::Event -> RefCounterEvent
Modified: trunk/Source/WTF/wtf/CMakeLists.txt (197405 => 197406)
--- trunk/Source/WTF/wtf/CMakeLists.txt 2016-03-01 19:41:46 UTC (rev 197405)
+++ trunk/Source/WTF/wtf/CMakeLists.txt 2016-03-01 19:47:31 UTC (rev 197406)
@@ -289,3 +289,7 @@
set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /SUBSYSTEM:WINDOWS")
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /SUBSYSTEM:WINDOWS")
endif ()
+
+if (WTF_PRE_BUILD_COMMAND)
+ add_custom_command(TARGET WTF PRE_BUILD COMMAND ${WTF_PRE_BUILD_COMMAND} VERBATIM)
+endif ()
Modified: trunk/Source/WebCore/CMakeLists.txt (197405 => 197406)
--- trunk/Source/WebCore/CMakeLists.txt 2016-03-01 19:41:46 UTC (rev 197405)
+++ trunk/Source/WebCore/CMakeLists.txt 2016-03-01 19:47:31 UTC (rev 197406)
@@ -3781,6 +3781,15 @@
ADD_TARGET_PROPERTIES(WebCore COMPILE_FLAGS "-fno-tree-sra")
endif ()
+if (WebCore_PRE_BUILD_COMMAND)
+ add_custom_target(WebCorePreBuild COMMAND ${WebCore_PRE_BUILD_COMMAND} VERBATIM)
+ add_dependencies(WebCore WebCorePreBuild)
+endif ()
+
+if (WebCore_POST_BUILD_COMMAND)
+ add_custom_command(TARGET WebCore POST_BUILD COMMAND ${WebCore_POST_BUILD_COMMAND} VERBATIM)
+endif ()
+
if (MSVC)
ADD_PRECOMPILED_HEADER("WebCoreTestSupportPrefix.h" "testing/js/WebCoreTestSupportPrefix.cpp" WebCoreTestSupport_SOURCES)
endif ()
Modified: trunk/Source/WebCore/ChangeLog (197405 => 197406)
--- trunk/Source/WebCore/ChangeLog 2016-03-01 19:41:46 UTC (rev 197405)
+++ trunk/Source/WebCore/ChangeLog 2016-03-01 19:47:31 UTC (rev 197406)
@@ -1,3 +1,16 @@
+2016-03-01 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r197056.
+ https://bugs.webkit.org/show_bug.cgi?id=154870
+
+ broke win ews (Requested by alexchristensen on #webkit).
+
+ Reverted changeset:
+
+ "[cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK."
+ https://bugs.webkit.org/show_bug.cgi?id=154651
+ http://trac.webkit.org/changeset/197056
+
2016-03-01 Brady Eidson <beid...@apple.com>
Modern IDB: Possible crash deallocating IDBDatabaseInfo/IDBObjectStoreInfo/IDBIndexInfo.
Modified: trunk/Source/cmake/WebKitMacros.cmake (197405 => 197406)
--- trunk/Source/cmake/WebKitMacros.cmake 2016-03-01 19:41:46 UTC (rev 197405)
+++ trunk/Source/cmake/WebKitMacros.cmake 2016-03-01 19:47:31 UTC (rev 197406)
@@ -258,14 +258,6 @@
set_target_properties(${_target} PROPERTIES OUTPUT_NAME ${${_target}_OUTPUT_NAME})
endif ()
- if (${_target}_PRE_BUILD_COMMAND)
- add_custom_command(TARGET ${_target} PRE_BUILD COMMAND ${${_target}_PRE_BUILD_COMMAND} VERBATIM)
- endif ()
-
- if (${_target}_POST_BUILD_COMMAND)
- add_custom_command(TARGET _javascript_Core POST_BUILD COMMAND ${${_target}_POST_BUILD_COMMAND} VERBATIM)
- endif ()
-
if (APPLE AND NOT PORT STREQUAL "GTK")
set_target_properties(${_target} PROPERTIES FRAMEWORK TRUE)
install(TARGETS ${_target} FRAMEWORK DESTINATION ${LIB_INSTALL_DIR})
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
