Skip to site navigation (Press enter)

[webkit-changes] [197414] trunk

commit-queue Tue, 01 Mar 2016 14:29:42 -0800

Title: [197414] trunk

Revision: 197414
Author: commit-qu...@webkit.org
Date: 2016-03-01 14:29:39 -0800 (Tue, 01 Mar 2016)

Log Message

Reduce size of internal windows build output
https://bugs.webkit.org/show_bug.cgi?id=154763


Patch by Alex Christensen <achristen...@webkit.org> on 2016-03-01
Reviewed by Brent Fulgham.

.:

* Source/cmake/OptionsWin.cmake:

Source/_javascript_Core:

* _javascript_Core.vcxproj/_javascript_Core.proj:

Source/WebCore:

* WebCore.vcxproj/WebCore.proj:

Source/WebKit:

* WebKit.vcxproj/WebKit.proj:

Source/WTF:

* WTF.vcxproj/WTF.proj:

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.proj
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.vcxproj/WTF.proj
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcxproj/WebCore.proj
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.vcxproj/WebKit.proj
trunk/Source/cmake/OptionsWin.cmake

Diff

Modified: trunk/ChangeLog (197413 => 197414)


--- trunk/ChangeLog	2016-03-01 22:13:00 UTC (rev 197413)
+++ trunk/ChangeLog	2016-03-01 22:29:39 UTC (rev 197414)
@@ -1,3 +1,12 @@
+2016-03-01  Alex Christensen  <achristen...@webkit.org>
+
+        Reduce size of internal windows build output
+        https://bugs.webkit.org/show_bug.cgi?id=154763
+
+        Reviewed by Brent Fulgham.
+
+        * Source/cmake/OptionsWin.cmake:
+
 2016-03-01  Commit Queue  <commit-qu...@webkit.org>
 
         Unreviewed, rolling out r197056.

Modified: trunk/Source/_javascript_Core/ChangeLog (197413 => 197414)


--- trunk/Source/_javascript_Core/ChangeLog	2016-03-01 22:13:00 UTC (rev 197413)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-03-01 22:29:39 UTC (rev 197414)
@@ -1,3 +1,12 @@
+2016-03-01  Alex Christensen  <achristen...@webkit.org>
+
+        Reduce size of internal windows build output
+        https://bugs.webkit.org/show_bug.cgi?id=154763
+
+        Reviewed by Brent Fulgham.
+
+        * _javascript_Core.vcxproj/_javascript_Core.proj:
+
 2016-03-01  Saam barati  <sbar...@apple.com>
 
         [[IsExtensible]] should be a virtual method in the method table

Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.proj (197413 => 197414)


--- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.proj	2016-03-01 22:13:00 UTC (rev 197413)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.proj	2016-03-01 22:29:39 UTC (rev 197414)
@@ -55,9 +55,9 @@
     <Message Text="Building $(CONFIGURATION) Solution" />
     <Error Text="DSTROOT property or environment variable must be defined." Condition="'$(DSTROOT)' == ''" />
 	<Exec Command="$(CMakeCommandCommon) -DWTF_CPU_X86=1 -G &quot;Visual Studio 14 2015&quot;" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build32"/>
-	<Exec Command="msbuild Project.sln" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build32"/>
+	<Exec Command="msbuild Project.sln /p:Configuration=$(CONFIG)" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build32"/>
 	<Exec Command="$(CMakeCommandCommon) -DWTF_CPU_X86_64=1 -G &quot;Visual Studio 14 2015 Win64&quot;" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build64"/>
-	<Exec Command="msbuild Project.sln" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build64"/>
+	<Exec Command="msbuild Project.sln /p:Configuration=$(CONFIG)" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build64"/>
   </Target>
 
   <Target Name="PostBuild" AfterTargets="Build">

Modified: trunk/Source/WTF/ChangeLog (197413 => 197414)


--- trunk/Source/WTF/ChangeLog	2016-03-01 22:13:00 UTC (rev 197413)
+++ trunk/Source/WTF/ChangeLog	2016-03-01 22:29:39 UTC (rev 197414)
@@ -1,3 +1,12 @@
+2016-03-01  Alex Christensen  <achristen...@webkit.org>
+
+        Reduce size of internal windows build output
+        https://bugs.webkit.org/show_bug.cgi?id=154763
+
+        Reviewed by Brent Fulgham.
+
+        * WTF.vcxproj/WTF.proj:
+
 2016-03-01  Commit Queue  <commit-qu...@webkit.org>
 
         Unreviewed, rolling out r197056.

Modified: trunk/Source/WTF/WTF.vcxproj/WTF.proj (197413 => 197414)


--- trunk/Source/WTF/WTF.vcxproj/WTF.proj	2016-03-01 22:13:00 UTC (rev 197413)
+++ trunk/Source/WTF/WTF.vcxproj/WTF.proj	2016-03-01 22:29:39 UTC (rev 197414)
@@ -47,9 +47,9 @@
     <Message Text="Building $(CONFIGURATION) Solution" />
     <Error Text="DSTROOT property or environment variable must be defined." Condition="'$(DSTROOT)' == ''" />
 	<Exec Command="$(CMakeCommandCommon) -G &quot;Visual Studio 14 2015&quot;" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build32"/>
-	<Exec Command="msbuild Project.sln" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build32"/>
+	<Exec Command="msbuild Project.sln /p:Configuration=$(CONFIG)" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build32"/>
 	<Exec Command="$(CMakeCommandCommon) -G &quot;Visual Studio 14 2015 Win64&quot;" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build64"/>
-	<Exec Command="msbuild Project.sln" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build64"/>
+	<Exec Command="msbuild Project.sln /p:Configuration=$(CONFIG)" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build64"/>
   </Target>
 
   <Target Name="PostBuild" AfterTargets="Build">

Modified: trunk/Source/WebCore/ChangeLog (197413 => 197414)


--- trunk/Source/WebCore/ChangeLog	2016-03-01 22:13:00 UTC (rev 197413)
+++ trunk/Source/WebCore/ChangeLog	2016-03-01 22:29:39 UTC (rev 197414)
@@ -1,3 +1,12 @@
+2016-03-01  Alex Christensen  <achristen...@webkit.org>
+
+        Reduce size of internal windows build output
+        https://bugs.webkit.org/show_bug.cgi?id=154763
+
+        Reviewed by Brent Fulgham.
+
+        * WebCore.vcxproj/WebCore.proj:
+
 2016-03-01  Andreas Kling  <akl...@apple.com>
 
         REGRESSION (r154616): Accelerated drawing is off during the initial load

Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.proj (197413 => 197414)


--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.proj	2016-03-01 22:13:00 UTC (rev 197413)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.proj	2016-03-01 22:29:39 UTC (rev 197414)
@@ -55,9 +55,9 @@
     <Message Text="Building $(CONFIGURATION) Solution" />
     <Error Text="DSTROOT property or environment variable must be defined." Condition="'$(DSTROOT)' == ''" />
 	<Exec Command="$(CMakeCommandCommon) -G &quot;Visual Studio 14 2015&quot;" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build32"/>
-	<Exec Command="msbuild Project.sln" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build32"/>
+	<Exec Command="msbuild Project.sln /p:Configuration=$(CONFIG)" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build32"/>
 	<Exec Command="$(CMakeCommandCommon) -G &quot;Visual Studio 14 2015 Win64&quot;" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build64"/>
-	<Exec Command="msbuild Project.sln" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build64"/>
+	<Exec Command="msbuild Project.sln /p:Configuration=$(CONFIG)" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build64"/>
   </Target>
 
   <Target Name="PostBuild" AfterTargets="Build">

Modified: trunk/Source/WebKit/ChangeLog (197413 => 197414)


--- trunk/Source/WebKit/ChangeLog	2016-03-01 22:13:00 UTC (rev 197413)
+++ trunk/Source/WebKit/ChangeLog	2016-03-01 22:29:39 UTC (rev 197414)
@@ -1,3 +1,12 @@
+2016-03-01  Alex Christensen  <achristen...@webkit.org>
+
+        Reduce size of internal windows build output
+        https://bugs.webkit.org/show_bug.cgi?id=154763
+
+        Reviewed by Brent Fulgham.
+
+        * WebKit.vcxproj/WebKit.proj:
+
 2016-02-26  Konstantin Tokarev  <annu...@yandex.ru>
 
         [cmake] Moved WebKit/Storage sources and include dir to CMakeLists.txt.

Modified: trunk/Source/WebKit/WebKit.vcxproj/WebKit.proj (197413 => 197414)


--- trunk/Source/WebKit/WebKit.vcxproj/WebKit.proj	2016-03-01 22:13:00 UTC (rev 197413)
+++ trunk/Source/WebKit/WebKit.vcxproj/WebKit.proj	2016-03-01 22:29:39 UTC (rev 197414)
@@ -55,9 +55,9 @@
     <Message Text="Building $(CONFIGURATION) Solution" />
     <Error Text="DSTROOT property or environment variable must be defined." Condition="'$(DSTROOT)' == ''" />
 	<Exec Command="$(CMakeCommandCommon) -G &quot;Visual Studio 14 2015&quot;" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build32"/>
-	<Exec Command="msbuild Project.sln" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build32"/>
+	<Exec Command="msbuild Project.sln /p:Configuration=$(CONFIG)" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build32"/>
 	<Exec Command="$(CMakeCommandCommon) -G &quot;Visual Studio 14 2015 Win64&quot;" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build64"/>
-	<Exec Command="msbuild Project.sln" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build64"/>
+	<Exec Command="msbuild Project.sln /p:Configuration=$(CONFIG)" WorkingDirectory="$(OBJROOT)/$(CONFIG)/build64"/>
   </Target>
 
   <Target Name="PostBuild" AfterTargets="Build">

Modified: trunk/Source/cmake/OptionsWin.cmake (197413 => 197414)


--- trunk/Source/cmake/OptionsWin.cmake	2016-03-01 22:13:00 UTC (rev 197413)
+++ trunk/Source/cmake/OptionsWin.cmake	2016-03-01 22:29:39 UTC (rev 197414)
@@ -130,8 +130,8 @@
     # Create pdb files for debugging purposes, also for Release builds
     add_compile_options(/Zi /GS)
 
-    set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /DEBUG")
-    set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /DEBUG")
+    set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /DEBUG /OPT:ICF /OPT:REF")
+    set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /DEBUG /OPT:ICF /OPT:REF")
 
     # We do not use exceptions
     add_definitions(-D_HAS_EXCEPTIONS=0)

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes