Title: [197468] trunk
- Revision
- 197468
- Author
- [email protected]
- Date
- 2016-03-02 14:45:46 -0800 (Wed, 02 Mar 2016)
Log Message
[cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK.
https://bugs.webkit.org/show_bug.cgi?id=154651
Patch by Konstantin Tokarev <[email protected]> on 2016-03-02
Reviewed by Alex Christensen.
.:
* Source/cmake/WebKitMacros.cmake: Used phony target instead of
CMake's PRE_BUILD COMMAND feature because the latter actually
generates pre-link target instead of pre-build.
Source/_javascript_Core:
* CMakeLists.txt: Moved shared code to WEBKIT_FRAMEWORK macro.
Source/WebCore:
No new tests needed.
* CMakeLists.txt: Moved shared code to WEBKIT_FRAMEWORK macro.
Source/WTF:
* CMakeLists.txt: Moved shared code to WEBKIT_FRAMEWORK macro.
Modified Paths
Diff
Modified: trunk/ChangeLog (197467 => 197468)
--- trunk/ChangeLog 2016-03-02 22:39:02 UTC (rev 197467)
+++ trunk/ChangeLog 2016-03-02 22:45:46 UTC (rev 197468)
@@ -1,3 +1,14 @@
+2016-03-02 Konstantin Tokarev <[email protected]>
+
+ [cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK.
+ https://bugs.webkit.org/show_bug.cgi?id=154651
+
+ Reviewed by Alex Christensen.
+
+ * Source/cmake/WebKitMacros.cmake: Used phony target instead of
+ CMake's PRE_BUILD COMMAND feature because the latter actually
+ generates pre-link target instead of pre-build.
+
2016-03-01 Alex Christensen <[email protected]>
Reduce size of internal windows build output
Modified: trunk/Source/_javascript_Core/CMakeLists.txt (197467 => 197468)
--- trunk/Source/_javascript_Core/CMakeLists.txt 2016-03-02 22:39:02 UTC (rev 197467)
+++ trunk/Source/_javascript_Core/CMakeLists.txt 2016-03-02 22:45:46 UTC (rev 197468)
@@ -1312,14 +1312,6 @@
WEBKIT_WRAP_SOURCELIST(${_javascript_Core_SOURCES})
WEBKIT_FRAMEWORK(_javascript_Core)
-if (_javascript_Core_PRE_BUILD_COMMAND)
- add_custom_command(TARGET _javascript_Core PRE_BUILD COMMAND ${_javascript_Core_PRE_BUILD_COMMAND} VERBATIM)
-endif ()
-
-if (_javascript_Core_POST_BUILD_COMMAND)
- add_custom_command(TARGET _javascript_Core POST_BUILD COMMAND ${_javascript_Core_POST_BUILD_COMMAND} VERBATIM)
-endif ()
-
if (${_javascript_Core_LIBRARY_TYPE} STREQUAL "SHARED")
POPULATE_LIBRARY_VERSION(_javascript_CORE)
set_target_properties(_javascript_Core PROPERTIES VERSION ${_javascript_CORE_VERSION} SOVERSION ${_javascript_CORE_VERSION_MAJOR})
Modified: trunk/Source/_javascript_Core/ChangeLog (197467 => 197468)
--- trunk/Source/_javascript_Core/ChangeLog 2016-03-02 22:39:02 UTC (rev 197467)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-03-02 22:45:46 UTC (rev 197468)
@@ -1,3 +1,12 @@
+2016-03-02 Konstantin Tokarev <[email protected]>
+
+ [cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK.
+ https://bugs.webkit.org/show_bug.cgi?id=154651
+
+ Reviewed by Alex Christensen.
+
+ * CMakeLists.txt: Moved shared code to WEBKIT_FRAMEWORK macro.
+
2016-03-02 Saam barati <[email protected]>
[[SetPrototypeOf]] should be a fully virtual method in ClassInfo::methodTable
Modified: trunk/Source/WTF/ChangeLog (197467 => 197468)
--- trunk/Source/WTF/ChangeLog 2016-03-02 22:39:02 UTC (rev 197467)
+++ trunk/Source/WTF/ChangeLog 2016-03-02 22:45:46 UTC (rev 197468)
@@ -1,3 +1,12 @@
+2016-03-02 Konstantin Tokarev <[email protected]>
+
+ [cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK.
+ https://bugs.webkit.org/show_bug.cgi?id=154651
+
+ Reviewed by Alex Christensen.
+
+ * CMakeLists.txt: Moved shared code to WEBKIT_FRAMEWORK macro.
+
2016-03-01 Commit Queue <[email protected]>
Unreviewed, rolling out r197226 and r197256.
Modified: trunk/Source/WTF/wtf/CMakeLists.txt (197467 => 197468)
--- trunk/Source/WTF/wtf/CMakeLists.txt 2016-03-02 22:39:02 UTC (rev 197467)
+++ trunk/Source/WTF/wtf/CMakeLists.txt 2016-03-02 22:45:46 UTC (rev 197468)
@@ -289,7 +289,3 @@
set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /SUBSYSTEM:WINDOWS")
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /SUBSYSTEM:WINDOWS")
endif ()
-
-if (WTF_PRE_BUILD_COMMAND)
- add_custom_command(TARGET WTF PRE_BUILD COMMAND ${WTF_PRE_BUILD_COMMAND} VERBATIM)
-endif ()
Modified: trunk/Source/WebCore/CMakeLists.txt (197467 => 197468)
--- trunk/Source/WebCore/CMakeLists.txt 2016-03-02 22:39:02 UTC (rev 197467)
+++ trunk/Source/WebCore/CMakeLists.txt 2016-03-02 22:45:46 UTC (rev 197468)
@@ -3781,15 +3781,6 @@
ADD_TARGET_PROPERTIES(WebCore COMPILE_FLAGS "-fno-tree-sra")
endif ()
-if (WebCore_PRE_BUILD_COMMAND)
- add_custom_target(WebCorePreBuild COMMAND ${WebCore_PRE_BUILD_COMMAND} VERBATIM)
- add_dependencies(WebCore WebCorePreBuild)
-endif ()
-
-if (WebCore_POST_BUILD_COMMAND)
- add_custom_command(TARGET WebCore POST_BUILD COMMAND ${WebCore_POST_BUILD_COMMAND} VERBATIM)
-endif ()
-
if (MSVC)
ADD_PRECOMPILED_HEADER("WebCoreTestSupportPrefix.h" "testing/js/WebCoreTestSupportPrefix.cpp" WebCoreTestSupport_SOURCES)
endif ()
Modified: trunk/Source/WebCore/ChangeLog (197467 => 197468)
--- trunk/Source/WebCore/ChangeLog 2016-03-02 22:39:02 UTC (rev 197467)
+++ trunk/Source/WebCore/ChangeLog 2016-03-02 22:45:46 UTC (rev 197468)
@@ -1,3 +1,14 @@
+2016-03-02 Konstantin Tokarev <[email protected]>
+
+ [cmake] Moved PRE/POST_BUILD_COMMAND to WEBKIT_FRAMEWORK.
+ https://bugs.webkit.org/show_bug.cgi?id=154651
+
+ Reviewed by Alex Christensen.
+
+ No new tests needed.
+
+ * CMakeLists.txt: Moved shared code to WEBKIT_FRAMEWORK macro.
+
2016-03-02 Dave Hyatt <[email protected]>
Add support for the "first" value of the hanging-punctuation property.
Modified: trunk/Source/cmake/WebKitMacros.cmake (197467 => 197468)
--- trunk/Source/cmake/WebKitMacros.cmake 2016-03-02 22:39:02 UTC (rev 197467)
+++ trunk/Source/cmake/WebKitMacros.cmake 2016-03-02 22:45:46 UTC (rev 197468)
@@ -258,6 +258,15 @@
set_target_properties(${_target} PROPERTIES OUTPUT_NAME ${${_target}_OUTPUT_NAME})
endif ()
+ if (${_target}_PRE_BUILD_COMMAND)
+ add_custom_target(_${_target}_PreBuild COMMAND ${${_target}_PRE_BUILD_COMMAND} VERBATIM)
+ add_dependencies(${_target} _${_target}_PreBuild)
+ endif ()
+
+ if (${_target}_POST_BUILD_COMMAND)
+ add_custom_command(TARGET ${_target} POST_BUILD COMMAND ${${_target}_POST_BUILD_COMMAND} VERBATIM)
+ endif ()
+
if (APPLE AND NOT PORT STREQUAL "GTK")
set_target_properties(${_target} PROPERTIES FRAMEWORK TRUE)
install(TARGETS ${_target} FRAMEWORK DESTINATION ${LIB_INSTALL_DIR})
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
