Title: [197817] trunk/Source/_javascript_Core
Revision
197817
Author
mark....@apple.com
Date
2016-03-08 16:21:26 -0800 (Tue, 08 Mar 2016)

Log Message

Implement Function.name support for getters/setters and inferring name of function properties.
https://bugs.webkit.org/show_bug.cgi?id=154865

Rubber-stamped by Joseph Pecoraro.

Follow up to the fix for this bug: adding a few small clean-ups for issues Joe
pointed out in the bug.

* runtime/JSBoundSlotBaseFunction.cpp:
(JSC::JSBoundSlotBaseFunction::create):
* runtime/JSCJSValue.cpp:
(JSC::JSValue::putToPrimitiveByIndex):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (197816 => 197817)


--- trunk/Source/_javascript_Core/ChangeLog	2016-03-09 00:08:53 UTC (rev 197816)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-03-09 00:21:26 UTC (rev 197817)
@@ -1,3 +1,18 @@
+2016-03-08  Mark Lam  <mark....@apple.com>
+
+        Implement Function.name support for getters/setters and inferring name of function properties.
+        https://bugs.webkit.org/show_bug.cgi?id=154865
+
+        Rubber-stamped by Joseph Pecoraro.
+
+        Follow up to the fix for this bug: adding a few small clean-ups for issues Joe
+        pointed out in the bug.
+
+        * runtime/JSBoundSlotBaseFunction.cpp:
+        (JSC::JSBoundSlotBaseFunction::create):
+        * runtime/JSCJSValue.cpp:
+        (JSC::JSValue::putToPrimitiveByIndex):
+
 2016-03-08  Oliver Hunt  <oli...@apple.com>
 
         Start moving to separated writable and executable mappings in the JIT

Modified: trunk/Source/_javascript_Core/runtime/JSBoundSlotBaseFunction.cpp (197816 => 197817)


--- trunk/Source/_javascript_Core/runtime/JSBoundSlotBaseFunction.cpp	2016-03-09 00:08:53 UTC (rev 197816)
+++ trunk/Source/_javascript_Core/runtime/JSBoundSlotBaseFunction.cpp	2016-03-09 00:21:26 UTC (rev 197817)
@@ -67,7 +67,7 @@
     JSBoundSlotBaseFunction* function = new (NotNull, allocateCell<JSBoundSlotBaseFunction>(vm.heap)) JSBoundSlotBaseFunction(vm, globalObject, globalObject->boundSlotBaseFunctionStructure(), type);
 
     // Can't do this during initialization because getHostFunction might do a GC allocation.
-    String prefix = (type == Type::Getter) ? "get " : "set ";
+    const char* prefix = (type == Type::Getter) ? "get " : "set ";
     function->finishCreation(vm, executable, boundSlotBase, getterSetter, makeString(prefix, name));
     return function;
 }

Modified: trunk/Source/_javascript_Core/runtime/JSCJSValue.cpp (197816 => 197817)


--- trunk/Source/_javascript_Core/runtime/JSCJSValue.cpp	2016-03-09 00:08:53 UTC (rev 197816)
+++ trunk/Source/_javascript_Core/runtime/JSCJSValue.cpp	2016-03-09 00:21:26 UTC (rev 197817)
@@ -207,7 +207,6 @@
     if (prototype->attemptToInterceptPutByIndexOnHoleForPrototype(exec, *this, propertyName, value, shouldThrow))
         return;
     
-    if (shouldThrow && !exec->hadException())
     if (shouldThrow)
         throwTypeError(exec, StrictModeReadonlyPropertyWriteError);
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to