Title: [198027] trunk
Revision
198027
Author
[email protected]
Date
2016-03-11 10:36:27 -0800 (Fri, 11 Mar 2016)

Log Message

Unreviewed, rolling out r197984.

This change caused an existing LayoutTest to fail

Reverted changeset:

"WebKit should not be redirected to an invalid URL"
https://bugs.webkit.org/show_bug.cgi?id=155263
http://trac.webkit.org/changeset/197984

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (198026 => 198027)


--- trunk/LayoutTests/ChangeLog	2016-03-11 18:30:13 UTC (rev 198026)
+++ trunk/LayoutTests/ChangeLog	2016-03-11 18:36:27 UTC (rev 198027)
@@ -1,3 +1,15 @@
+2016-03-11  Ryan Haddad  <[email protected]>
+
+        Unreviewed, rolling out r197984.
+
+        This change caused an existing LayoutTest to fail
+
+        Reverted changeset:
+
+        "WebKit should not be redirected to an invalid URL"
+        https://bugs.webkit.org/show_bug.cgi?id=155263
+        http://trac.webkit.org/changeset/197984
+
 2016-03-11  Yusuke Suzuki  <[email protected]>
 
         [ES6] Implement Reflect.set without receiver support

Deleted: trunk/LayoutTests/http/tests/navigation/redirect-to-invalid-url-expected.txt (198026 => 198027)


--- trunk/LayoutTests/http/tests/navigation/redirect-to-invalid-url-expected.txt	2016-03-11 18:30:13 UTC (rev 198026)
+++ trunk/LayoutTests/http/tests/navigation/redirect-to-invalid-url-expected.txt	2016-03-11 18:36:27 UTC (rev 198027)
@@ -1,6 +0,0 @@
-http://127.0.0.1:8000/navigation/resources/redirect-to-invalid-url-frame.php - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/navigation/resources/redirect-to-invalid-url-frame.php, main document URL http://127.0.0.1:8000/navigation/redirect-to-invalid-url.html, http method GET> redirectResponse (null)
-http://127.0.0.1:8000/navigation/redirect-to-invalid-url.html - didFinishLoading
-http://127.0.0.1:8000/navigation/resources/redirect-to-invalid-url-frame.php - didFailLoadingWithError: <NSError domain NSURLErrorDomain, code -999, failing URL "http://127.0.0.1:8000/navigation/resources/redirect-to-invalid-url-frame.php">
-Test passes if WebKit doesn't request the redirected URL.
-
-

Deleted: trunk/LayoutTests/http/tests/navigation/redirect-to-invalid-url.html (198026 => 198027)


--- trunk/LayoutTests/http/tests/navigation/redirect-to-invalid-url.html	2016-03-11 18:30:13 UTC (rev 198026)
+++ trunk/LayoutTests/http/tests/navigation/redirect-to-invalid-url.html	2016-03-11 18:36:27 UTC (rev 198027)
@@ -1,21 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<script>
-    if (window.testRunner) {
-        testRunner.dumpAsText();
-        testRunner.dumpResourceLoadCallbacks();
-        testRunner.waitUntilDone();
-    }
-
-    _onload_ = function() {
-        if (window.testRunner)
-            testRunner.notifyDone();
-    }
-</script>
-</head>
-<body>
-    <p>Test passes if WebKit doesn't request the redirected URL.</p>
-    <iframe src=""
-</body>
-</html>

Deleted: trunk/LayoutTests/http/tests/navigation/resources/redirect-to-invalid-url-frame.php (198026 => 198027)


--- trunk/LayoutTests/http/tests/navigation/resources/redirect-to-invalid-url-frame.php	2016-03-11 18:30:13 UTC (rev 198026)
+++ trunk/LayoutTests/http/tests/navigation/resources/redirect-to-invalid-url-frame.php	2016-03-11 18:36:27 UTC (rev 198027)
@@ -1,4 +0,0 @@
-<?php
-header('Location: http://localhost:xyz/none-existed.html');
-?>
-

Modified: trunk/Source/WebCore/ChangeLog (198026 => 198027)


--- trunk/Source/WebCore/ChangeLog	2016-03-11 18:30:13 UTC (rev 198026)
+++ trunk/Source/WebCore/ChangeLog	2016-03-11 18:36:27 UTC (rev 198027)
@@ -1,3 +1,15 @@
+2016-03-11  Ryan Haddad  <[email protected]>
+
+        Unreviewed, rolling out r197984.
+
+        This change caused an existing LayoutTest to fail
+
+        Reverted changeset:
+
+        "WebKit should not be redirected to an invalid URL"
+        https://bugs.webkit.org/show_bug.cgi?id=155263
+        http://trac.webkit.org/changeset/197984
+
 2016-03-11  Yusuke Suzuki  <[email protected]>
 
         [ES6] Implement Reflect.set without receiver support

Modified: trunk/Source/WebCore/loader/SubresourceLoader.cpp (198026 => 198027)


--- trunk/Source/WebCore/loader/SubresourceLoader.cpp	2016-03-11 18:30:13 UTC (rev 198026)
+++ trunk/Source/WebCore/loader/SubresourceLoader.cpp	2016-03-11 18:36:27 UTC (rev 198027)
@@ -160,11 +160,6 @@
     URL previousURL = request().url();
     Ref<SubresourceLoader> protect(*this);
 
-    if (!newRequest.url().isValid()) {
-        cancel();
-        return;
-    }
-
     ASSERT(!newRequest.isNull());
     if (!redirectResponse.isNull()) {
         // CachedResources are keyed off their original request URL.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to