Title: [198290] trunk/Source/_javascript_Core
- Revision
- 198290
- Author
- bb...@apple.com
- Date
- 2016-03-16 12:03:36 -0700 (Wed, 16 Mar 2016)
Log Message
Unreviewed, rolling out r198257.
https://bugs.webkit.org/show_bug.cgi?id=155553
This change is unnecessary, clients can instead compile the
file with ARC enabled (Requested by brrian on #webkit).
Reverted changeset:
"REGRESSION(r198077): generated Objective-C protocol object
getters leak their wrappers"
https://bugs.webkit.org/show_bug.cgi?id=155523
http://trac.webkit.org/changeset/198257
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (198289 => 198290)
--- trunk/Source/_javascript_Core/ChangeLog 2016-03-16 18:31:32 UTC (rev 198289)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-03-16 19:03:36 UTC (rev 198290)
@@ -1,3 +1,18 @@
+2016-03-16 Brian Burg <bb...@apple.com>
+
+ Unreviewed, rolling out r198257.
+ https://bugs.webkit.org/show_bug.cgi?id=155553
+
+ This change is unnecessary, clients can instead compile the
+ file with ARC enabled (Requested by brrian on #webkit).
+
+ Reverted changeset:
+
+ "REGRESSION(r198077): generated Objective-C protocol object
+ getters leak their wrappers"
+ https://bugs.webkit.org/show_bug.cgi?id=155523
+ http://trac.webkit.org/changeset/198257
+
2016-03-16 Mark Lam <mark....@apple.com>
Add support for setting Function.name from computed properties.
Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/objc_generator.py (198289 => 198290)
--- trunk/Source/_javascript_Core/inspector/scripts/codegen/objc_generator.py 2016-03-16 18:31:32 UTC (rev 198289)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/objc_generator.py 2016-03-16 19:03:36 UTC (rev 198290)
@@ -444,7 +444,7 @@
return sub_expression
if category is ObjCTypeCategory.Object:
objc_class = self.objc_class_for_type(member.type)
- return '[[[%s alloc] initWithInspectorObject:[%s toInspectorObject].get()] autorelease]' % (objc_class, sub_expression)
+ return '[[%s alloc] initWithInspectorObject:[%s toInspectorObject].get()]' % (objc_class, sub_expression)
if category is ObjCTypeCategory.Array:
protocol_type = ObjCGenerator.protocol_type_for_type(member.type.element_type)
objc_class = self.objc_class_for_type(member.type.element_type)
Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-object-type.json-result (198289 => 198290)
--- trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-object-type.json-result 2016-03-16 18:31:32 UTC (rev 198289)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-object-type.json-result 2016-03-16 19:03:36 UTC (rev 198290)
@@ -1595,7 +1595,7 @@
- (RWIProtocolJSONObject *)values
{
- return [[[RWIProtocolJSONObject alloc] initWithInspectorObject:[[super objectForKey:@"values"] toInspectorObject].get()] autorelease];
+ return [[RWIProtocolJSONObject alloc] initWithInspectorObject:[[super objectForKey:@"values"] toInspectorObject].get()];
}
- (void)setPayload:(RWIProtocolJSONObject *)payload
@@ -1605,7 +1605,7 @@
- (RWIProtocolJSONObject *)payload
{
- return [[[RWIProtocolJSONObject alloc] initWithInspectorObject:[[super objectForKey:@"payload"] toInspectorObject].get()] autorelease];
+ return [[RWIProtocolJSONObject alloc] initWithInspectorObject:[[super objectForKey:@"payload"] toInspectorObject].get()];
}
- (void)setError:(TestProtocolDatabaseError *)error
@@ -1615,7 +1615,7 @@
- (TestProtocolDatabaseError *)error
{
- return [[[TestProtocolDatabaseError alloc] initWithInspectorObject:[[super objectForKey:@"error"] toInspectorObject].get()] autorelease];
+ return [[TestProtocolDatabaseError alloc] initWithInspectorObject:[[super objectForKey:@"error"] toInspectorObject].get()];
}
- (void)setErrorList:(NSArray/*<TestProtocolDatabaseError>*/ *)errorList
@@ -1730,7 +1730,7 @@
- (RWIProtocolJSONObject *)values
{
- return [[[RWIProtocolJSONObject alloc] initWithInspectorObject:[[super objectForKey:@"values"] toInspectorObject].get()] autorelease];
+ return [[RWIProtocolJSONObject alloc] initWithInspectorObject:[[super objectForKey:@"values"] toInspectorObject].get()];
}
- (void)setPayload:(RWIProtocolJSONObject *)payload
@@ -1740,7 +1740,7 @@
- (RWIProtocolJSONObject *)payload
{
- return [[[RWIProtocolJSONObject alloc] initWithInspectorObject:[[super objectForKey:@"payload"] toInspectorObject].get()] autorelease];
+ return [[RWIProtocolJSONObject alloc] initWithInspectorObject:[[super objectForKey:@"payload"] toInspectorObject].get()];
}
- (void)setError:(TestProtocolDatabaseError *)error
@@ -1750,7 +1750,7 @@
- (TestProtocolDatabaseError *)error
{
- return [[[TestProtocolDatabaseError alloc] initWithInspectorObject:[[super objectForKey:@"error"] toInspectorObject].get()] autorelease];
+ return [[TestProtocolDatabaseError alloc] initWithInspectorObject:[[super objectForKey:@"error"] toInspectorObject].get()];
}
- (void)setErrorList:(NSArray/*<TestProtocolDatabaseError>*/ *)errorList
@@ -1983,7 +1983,7 @@
- (RWIProtocolJSONObject *)values
{
- return [[[RWIProtocolJSONObject alloc] initWithInspectorObject:[[super objectForKey:@"values"] toInspectorObject].get()] autorelease];
+ return [[RWIProtocolJSONObject alloc] initWithInspectorObject:[[super objectForKey:@"values"] toInspectorObject].get()];
}
- (void)setPayload:(RWIProtocolJSONObject *)payload
@@ -1993,7 +1993,7 @@
- (RWIProtocolJSONObject *)payload
{
- return [[[RWIProtocolJSONObject alloc] initWithInspectorObject:[[super objectForKey:@"payload"] toInspectorObject].get()] autorelease];
+ return [[RWIProtocolJSONObject alloc] initWithInspectorObject:[[super objectForKey:@"payload"] toInspectorObject].get()];
}
- (void)setError:(TestProtocolDatabaseError *)error
@@ -2003,7 +2003,7 @@
- (TestProtocolDatabaseError *)error
{
- return [[[TestProtocolDatabaseError alloc] initWithInspectorObject:[[super objectForKey:@"error"] toInspectorObject].get()] autorelease];
+ return [[TestProtocolDatabaseError alloc] initWithInspectorObject:[[super objectForKey:@"error"] toInspectorObject].get()];
}
@end
Modified: trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result (198289 => 198290)
--- trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result 2016-03-16 18:31:32 UTC (rev 198289)
+++ trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result 2016-03-16 19:03:36 UTC (rev 198290)
@@ -1473,7 +1473,7 @@
- (TestProtocolTestRecursiveObject1 *)tree
{
- return [[[TestProtocolTestRecursiveObject1 alloc] initWithInspectorObject:[[super objectForKey:@"tree"] toInspectorObject].get()] autorelease];
+ return [[TestProtocolTestRecursiveObject1 alloc] initWithInspectorObject:[[super objectForKey:@"tree"] toInspectorObject].get()];
}
@end
@@ -1504,7 +1504,7 @@
- (TestProtocolTestRecursiveObject2 *)obj
{
- return [[[TestProtocolTestRecursiveObject2 alloc] initWithInspectorObject:[[super objectForKey:@"obj"] toInspectorObject].get()] autorelease];
+ return [[TestProtocolTestRecursiveObject2 alloc] initWithInspectorObject:[[super objectForKey:@"obj"] toInspectorObject].get()];
}
@end
@@ -1535,7 +1535,7 @@
- (TestProtocolTestRecursiveObject1 *)obj
{
- return [[[TestProtocolTestRecursiveObject1 alloc] initWithInspectorObject:[[super objectForKey:@"obj"] toInspectorObject].get()] autorelease];
+ return [[TestProtocolTestRecursiveObject1 alloc] initWithInspectorObject:[[super objectForKey:@"obj"] toInspectorObject].get()];
}
@end
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
