Title: [198305] trunk/Source/WebCore
Revision
198305
Author
achristen...@apple.com
Date
2016-03-16 15:10:02 -0700 (Wed, 16 Mar 2016)

Log Message

Fix assertion failure on drive.google.com after r196052
https://bugs.webkit.org/show_bug.cgi?id=155562

Reviewed by Jer Noble.

* rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::mapToContainer):
Change float equality check to areEssentiallyEqual.
This assertion was failing because rendererMappedResult was (944.335693, 232.047409)
but result was (944.335693, 232.047394).  They differ by (0, 0.000015).

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (198304 => 198305)


--- trunk/Source/WebCore/ChangeLog	2016-03-16 22:06:41 UTC (rev 198304)
+++ trunk/Source/WebCore/ChangeLog	2016-03-16 22:10:02 UTC (rev 198305)
@@ -1,3 +1,16 @@
+2016-03-16  Alex Christensen  <achristen...@webkit.org>
+
+        Fix assertion failure on drive.google.com after r196052
+        https://bugs.webkit.org/show_bug.cgi?id=155562
+
+        Reviewed by Jer Noble.
+
+        * rendering/RenderGeometryMap.cpp:
+        (WebCore::RenderGeometryMap::mapToContainer):
+        Change float equality check to areEssentiallyEqual.
+        This assertion was failing because rendererMappedResult was (944.335693, 232.047409)
+        but result was (944.335693, 232.047394).  They differ by (0, 0.000015).
+
 2016-03-16  Nan Wang  <n_w...@apple.com>
 
         AX: Expose aria-current status to children

Modified: trunk/Source/WebCore/rendering/RenderGeometryMap.cpp (198304 => 198305)


--- trunk/Source/WebCore/rendering/RenderGeometryMap.cpp	2016-03-16 22:06:41 UTC (rev 198304)
+++ trunk/Source/WebCore/rendering/RenderGeometryMap.cpp	2016-03-16 22:10:02 UTC (rev 198305)
@@ -116,7 +116,7 @@
         TransformState transformState(TransformState::ApplyTransformDirection, p);
         mapToContainer(transformState, container);
         result = transformState.lastPlanarPoint();
-        ASSERT(rendererMappedResult == result);
+        ASSERT(areEssentiallyEqual(rendererMappedResult, result));
     }
 
     return result;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to