Title: [198500] trunk/Source/WebCore
- Revision
- 198500
- Author
- cdu...@apple.com
- Date
- 2016-03-21 15:07:33 -0700 (Mon, 21 Mar 2016)
Log Message
Unreviewed, rolling out r197552.
May have caused a ~2% PLT regression on iOS
Reverted changeset:
"Drop DocumentSharedObjectPool immediately when going into
PageCache."
https://bugs.webkit.org/show_bug.cgi?id=154986
http://trac.webkit.org/changeset/197552
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (198499 => 198500)
--- trunk/Source/WebCore/ChangeLog 2016-03-21 20:54:27 UTC (rev 198499)
+++ trunk/Source/WebCore/ChangeLog 2016-03-21 22:07:33 UTC (rev 198500)
@@ -1,3 +1,16 @@
+2016-03-21 Chris Dumez <cdu...@apple.com>
+
+ Unreviewed, rolling out r197552.
+
+ May have caused a ~2% PLT regression on iOS
+
+ Reverted changeset:
+
+ "Drop DocumentSharedObjectPool immediately when going into
+ PageCache."
+ https://bugs.webkit.org/show_bug.cgi?id=154986
+ http://trac.webkit.org/changeset/197552
+
2016-03-21 Simon Fraser <simon.fra...@apple.com>
Very flashy scrolling on http://quellish.tumblr.com page
Modified: trunk/Source/WebCore/dom/Document.cpp (198499 => 198500)
--- trunk/Source/WebCore/dom/Document.cpp 2016-03-21 20:54:27 UTC (rev 198499)
+++ trunk/Source/WebCore/dom/Document.cpp 2016-03-21 22:07:33 UTC (rev 198500)
@@ -533,7 +533,7 @@
, m_scheduledTasksAreSuspended(false)
, m_visualUpdatesAllowed(true)
, m_visualUpdatesSuppressionTimer(*this, &Document::visualUpdatesSuppressionTimerFired)
- , m_sharedObjectPoolClearTimer(*this, &Document::clearSharedObjectPool)
+ , m_sharedObjectPoolClearTimer(*this, &Document::sharedObjectPoolClearTimerFired)
#ifndef NDEBUG
, m_didDispatchViewportPropertiesChanged(false)
#endif
@@ -4645,7 +4645,6 @@
clearStyleResolver();
clearSelectorQueryCache();
- clearSharedObjectPool();
} else {
if (childNeedsStyleRecalc())
scheduleStyleRecalc();
@@ -5092,10 +5091,9 @@
m_cachedResourceLoader->clearPreloads();
}
-void Document::clearSharedObjectPool()
+void Document::sharedObjectPoolClearTimerFired()
{
m_sharedObjectPool = nullptr;
- m_sharedObjectPoolClearTimer.stop();
}
#if ENABLE(TELEPHONE_NUMBER_DETECTION)
Modified: trunk/Source/WebCore/dom/Document.h (198499 => 198500)
--- trunk/Source/WebCore/dom/Document.h 2016-03-21 20:54:27 UTC (rev 198499)
+++ trunk/Source/WebCore/dom/Document.h 2016-03-21 22:07:33 UTC (rev 198500)
@@ -1723,7 +1723,7 @@
RefPtr<NamedFlowCollection> m_namedFlows;
- void clearSharedObjectPool();
+ void sharedObjectPoolClearTimerFired();
Timer m_sharedObjectPoolClearTimer;
std::unique_ptr<DocumentSharedObjectPool> m_sharedObjectPool;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
