Title: [198543] trunk
- Revision
- 198543
- Author
- n_w...@apple.com
- Date
- 2016-03-22 12:17:37 -0700 (Tue, 22 Mar 2016)
Log Message
AX: Change "dialog" role description to "web dialog" so users can distinguish from native alerts
https://bugs.webkit.org/show_bug.cgi?id=154292
Reviewed by Chris Fleizach.
Source/WebCore:
Changed role descriptions for "dialog" and "alert dialog" roles as required.
No new tests needed.
* English.lproj/Localizable.strings:
LayoutTests:
* platform/mac-mavericks/accessibility/roles-exposed-expected.txt:
* platform/mac/accessibility/roles-exposed-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (198542 => 198543)
--- trunk/LayoutTests/ChangeLog 2016-03-22 19:12:32 UTC (rev 198542)
+++ trunk/LayoutTests/ChangeLog 2016-03-22 19:17:37 UTC (rev 198543)
@@ -1,3 +1,13 @@
+2016-03-22 Nan Wang <n_w...@apple.com>
+
+ AX: Change "dialog" role description to "web dialog" so users can distinguish from native alerts
+ https://bugs.webkit.org/show_bug.cgi?id=154292
+
+ Reviewed by Chris Fleizach.
+
+ * platform/mac-mavericks/accessibility/roles-exposed-expected.txt:
+ * platform/mac/accessibility/roles-exposed-expected.txt:
+
2016-03-22 Daniel Bates <daba...@apple.com>
CSP: Check inline event handlers on each run, not only the first
Modified: trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt (198542 => 198543)
--- trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2016-03-22 19:12:32 UTC (rev 198542)
+++ trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2016-03-22 19:17:37 UTC (rev 198543)
@@ -807,7 +807,7 @@
div[role=alertdialog]
AXRole: AXGroup
AXSubrole: AXApplicationAlertDialog
- AXRoleDescription: alert dialog
+ AXRoleDescription: web alert dialog
div[role=application]
AXRole: AXGroup
@@ -857,7 +857,7 @@
div[role=dialog]
AXRole: AXGroup
AXSubrole: AXApplicationDialog
- AXRoleDescription: dialog
+ AXRoleDescription: web dialog
div[role=directory]
AXRole: AXList
Modified: trunk/LayoutTests/platform/mac-mavericks/accessibility/roles-exposed-expected.txt (198542 => 198543)
--- trunk/LayoutTests/platform/mac-mavericks/accessibility/roles-exposed-expected.txt 2016-03-22 19:12:32 UTC (rev 198542)
+++ trunk/LayoutTests/platform/mac-mavericks/accessibility/roles-exposed-expected.txt 2016-03-22 19:17:37 UTC (rev 198543)
@@ -807,7 +807,7 @@
div[role=alertdialog]
AXRole: AXGroup
AXSubrole: AXApplicationAlertDialog
- AXRoleDescription: alert dialog
+ AXRoleDescription: web alert dialog
div[role=application]
AXRole: AXGroup
@@ -857,7 +857,7 @@
div[role=dialog]
AXRole: AXGroup
AXSubrole: AXApplicationDialog
- AXRoleDescription: dialog
+ AXRoleDescription: web dialog
div[role=directory]
AXRole: AXList
Modified: trunk/Source/WebCore/ChangeLog (198542 => 198543)
--- trunk/Source/WebCore/ChangeLog 2016-03-22 19:12:32 UTC (rev 198542)
+++ trunk/Source/WebCore/ChangeLog 2016-03-22 19:17:37 UTC (rev 198543)
@@ -1,3 +1,16 @@
+2016-03-22 Nan Wang <n_w...@apple.com>
+
+ AX: Change "dialog" role description to "web dialog" so users can distinguish from native alerts
+ https://bugs.webkit.org/show_bug.cgi?id=154292
+
+ Reviewed by Chris Fleizach.
+
+ Changed role descriptions for "dialog" and "alert dialog" roles as required.
+
+ No new tests needed.
+
+ * English.lproj/Localizable.strings:
+
2016-03-22 Alex Christensen <achristen...@webkit.org>
Add null check in CachedResourceLoader::determineRevalidationPolicy
Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (198542 => 198543)
--- trunk/Source/WebCore/English.lproj/Localizable.strings 2016-03-22 19:12:32 UTC (rev 198542)
+++ trunk/Source/WebCore/English.lproj/Localizable.strings 2016-03-22 19:17:37 UTC (rev 198543)
@@ -713,7 +713,7 @@
"alert" = "alert";
/* An ARIA accessibility group that acts as an alert dialog. */
-"alert dialog" = "alert dialog";
+"alert dialog" = "web alert dialog";
/* An ARIA accessibility group that acts as an application. */
"application" = "application";
@@ -788,7 +788,7 @@
"description list" = "description list";
/* An ARIA accessibility group that acts as an dialog. */
-"dialog" = "dialog";
+"dialog" = "web dialog";
/* An ARIA accessibility group that acts as a document. */
"document" = "document";
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
