Title: [198601] trunk/Source/WebInspectorUI
- Revision
- 198601
- Author
- [email protected]
- Date
- 2016-03-23 15:45:15 -0700 (Wed, 23 Mar 2016)
Log Message
Web Inspector: Uncaught exceptions closing Timeline tab
https://bugs.webkit.org/show_bug.cgi?id=155805
Patch by Joseph Pecoraro <[email protected]> on 2016-03-23
Reviewed by Timothy Hatcher.
* UserInterface/Views/ScriptClusterTimelineView.js:
(WebInspector.ScriptClusterTimelineView.prototype._scriptClusterViewCurrentContentViewDidChange):
Gracefully handle if there is no content view.
* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype.closed): Deleted.
Fix typo.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (198600 => 198601)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-03-23 22:33:17 UTC (rev 198600)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-03-23 22:45:15 UTC (rev 198601)
@@ -1,3 +1,18 @@
+2016-03-23 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Uncaught exceptions closing Timeline tab
+ https://bugs.webkit.org/show_bug.cgi?id=155805
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/ScriptClusterTimelineView.js:
+ (WebInspector.ScriptClusterTimelineView.prototype._scriptClusterViewCurrentContentViewDidChange):
+ Gracefully handle if there is no content view.
+
+ * UserInterface/Views/TimelineRecordingContentView.js:
+ (WebInspector.TimelineRecordingContentView.prototype.closed): Deleted.
+ Fix typo.
+
2016-03-23 Matt Baker <[email protected]>
Web Inspector: Quick Open dialog has fuzzy icons at 1x
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScriptClusterTimelineView.js (198600 => 198601)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ScriptClusterTimelineView.js 2016-03-23 22:33:17 UTC (rev 198600)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScriptClusterTimelineView.js 2016-03-23 22:45:15 UTC (rev 198601)
@@ -187,6 +187,9 @@
_scriptClusterViewCurrentContentViewDidChange(event)
{
let currentContentView = this._contentViewContainer.currentContentView;
+ if (!currentContentView)
+ return;
+
let previousContentView = currentContentView === this._eventsContentView ? this._profileContentView : this._eventsContentView;
currentContentView.zeroTime = previousContentView.zeroTime;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (198600 => 198601)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2016-03-23 22:33:17 UTC (rev 198600)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2016-03-23 22:45:15 UTC (rev 198601)
@@ -185,7 +185,7 @@
closed()
{
- this._timelinContentBrowser.contentViewContainer.closeAllContentViews();
+ this._timelineContentBrowser.contentViewContainer.closeAllContentViews();
this._recording.removeEventListener(null, null, this);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
