Title: [198617] trunk/Tools
- Revision
- 198617
- Author
- [email protected]
- Date
- 2016-03-23 22:16:56 -0700 (Wed, 23 Mar 2016)
Log Message
webkit-patch failed to open pretty diff on Windows
https://bugs.webkit.org/show_bug.cgi?id=155827
Patch by Bill Ming <[email protected]> on 2016-03-23
Reviewed by Alex Christensen.
* Scripts/webkitpy/tool/steps/confirmdiff.py:
(ConfirmDiff._show_pretty_diff):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (198616 => 198617)
--- trunk/Tools/ChangeLog 2016-03-24 05:13:35 UTC (rev 198616)
+++ trunk/Tools/ChangeLog 2016-03-24 05:16:56 UTC (rev 198617)
@@ -1,3 +1,13 @@
+2016-03-23 Bill Ming <[email protected]>
+
+ webkit-patch failed to open pretty diff on Windows
+ https://bugs.webkit.org/show_bug.cgi?id=155827
+
+ Reviewed by Alex Christensen.
+
+ * Scripts/webkitpy/tool/steps/confirmdiff.py:
+ (ConfirmDiff._show_pretty_diff):
+
2016-03-23 Jer Noble <[email protected]>
[ios-sim] RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForVideoButNotAudioPlayback failing
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/confirmdiff.py (198616 => 198617)
--- trunk/Tools/Scripts/webkitpy/tool/steps/confirmdiff.py 2016-03-24 05:13:35 UTC (rev 198616)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/confirmdiff.py 2016-03-24 05:16:56 UTC (rev 198617)
@@ -53,7 +53,7 @@
pretty_patch = PrettyPatch(self._tool.executive,
self._tool.scm().checkout_root)
pretty_diff_file = pretty_patch.pretty_diff_file(diff)
- url = "" % urllib.quote(pretty_diff_file.name)
+ url = "" % urllib.pathname2url(pretty_diff_file.name)
self._tool.user.open_url(url)
# We return the pretty_diff_file here because we need to keep the
# file alive until the user has had a chance to confirm the diff.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
