Title: [198818] trunk/Source/WebCore
Revision
198818
Author
commit-qu...@webkit.org
Date
2016-03-29 18:31:33 -0700 (Tue, 29 Mar 2016)

Log Message

REGRESSION (r198782): CGImageSourceUpdateData() is called twice with the same data every time ImageSource::setData() is called
https://bugs.webkit.org/show_bug.cgi?id=155997

Patch by Said Abou-Hallawa <sabouhall...@apple.com> on 2016-03-29
Reviewed by Simon Fraser.

Remove a call to CGImageSourceUpdateData() which was mistakenly left in
ImageDecoder::setData() after ImageSource refactoring.

* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageDecoder::setData):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (198817 => 198818)


--- trunk/Source/WebCore/ChangeLog	2016-03-30 01:24:50 UTC (rev 198817)
+++ trunk/Source/WebCore/ChangeLog	2016-03-30 01:31:33 UTC (rev 198818)
@@ -1,3 +1,16 @@
+2016-03-29  Said Abou-Hallawa  <sabouhall...@apple.com>
+
+        REGRESSION (r198782): CGImageSourceUpdateData() is called twice with the same data every time ImageSource::setData() is called
+        https://bugs.webkit.org/show_bug.cgi?id=155997
+
+        Reviewed by Simon Fraser.
+
+        Remove a call to CGImageSourceUpdateData() which was mistakenly left in
+        ImageDecoder::setData() after ImageSource refactoring.
+
+        * platform/graphics/cg/ImageSourceCG.cpp:
+        (WebCore::ImageDecoder::setData):
+
 2016-03-29  Myles C. Maxfield  <mmaxfi...@apple.com>
 
         REGRESSION(r198784) Shouldn't add platform-dependent code to ScrollableArea.h

Modified: trunk/Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp (198817 => 198818)


--- trunk/Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp	2016-03-30 01:24:50 UTC (rev 198817)
+++ trunk/Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp	2016-03-30 01:31:33 UTC (rev 198818)
@@ -436,7 +436,6 @@
     // We use SharedBuffer's ability to wrap itself inside CFData to get around this, ensuring that ImageIO is
     // really looking at the SharedBuffer.
     setData(data->createCFData().get(), allDataReceived);
-    CGImageSourceUpdateData(m_nativeDecoder.get(), data->createCFData().get(), allDataReceived);
 #else
     // Create a CGDataProvider to wrap the SharedBuffer.
     data->ref();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to