Title: [199083] trunk/Source
- Revision
- 199083
- Author
- [email protected]
- Date
- 2016-04-05 16:33:47 -0700 (Tue, 05 Apr 2016)
Log Message
Make requestCandidatesForSelection available on any EditorClient
https://bugs.webkit.org/show_bug.cgi?id=156253
-and corresponding-
rdar://problem/24661147
Reviewed by Dean Jackson.
Source/WebCore:
* loader/EmptyClients.h:
* page/EditorClient.h:
(WebCore::EditorClient::requestCandidatesForSelection):
Source/WebKit/mac:
* WebCoreSupport/WebEditorClient.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (199082 => 199083)
--- trunk/Source/WebCore/ChangeLog 2016-04-05 23:20:34 UTC (rev 199082)
+++ trunk/Source/WebCore/ChangeLog 2016-04-05 23:33:47 UTC (rev 199083)
@@ -1,3 +1,16 @@
+2016-04-05 Beth Dakin <[email protected]>
+
+ Make requestCandidatesForSelection available on any EditorClient
+ https://bugs.webkit.org/show_bug.cgi?id=156253
+ -and corresponding-
+ rdar://problem/24661147
+
+ Reviewed by Dean Jackson.
+
+ * loader/EmptyClients.h:
+ * page/EditorClient.h:
+ (WebCore::EditorClient::requestCandidatesForSelection):
+
2016-04-05 Youenn Fablet <[email protected]>
[Fetch API] Add a runtime flag to fetch API and related constructs
Modified: trunk/Source/WebCore/loader/EmptyClients.h (199082 => 199083)
--- trunk/Source/WebCore/loader/EmptyClients.h 2016-04-05 23:20:34 UTC (rev 199082)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2016-04-05 23:33:47 UTC (rev 199083)
@@ -468,6 +468,7 @@
void willWriteSelectionToPasteboard(Range*) override { }
void didWriteSelectionToPasteboard() override { }
void getClientPasteboardDataForRange(Range*, Vector<String>&, Vector<RefPtr<SharedBuffer>>&) override { }
+ void requestCandidatesForSelection(const VisibleSelection&) override { }
void registerUndoStep(PassRefPtr<UndoStep>) override;
void registerRedoStep(PassRefPtr<UndoStep>) override;
Modified: trunk/Source/WebCore/page/EditorClient.h (199082 => 199083)
--- trunk/Source/WebCore/page/EditorClient.h 2016-04-05 23:20:34 UTC (rev 199082)
+++ trunk/Source/WebCore/page/EditorClient.h 2016-04-05 23:33:47 UTC (rev 199083)
@@ -99,6 +99,7 @@
virtual void willWriteSelectionToPasteboard(Range*) = 0;
virtual void didWriteSelectionToPasteboard() = 0;
virtual void getClientPasteboardDataForRange(Range*, Vector<String>& pasteboardTypes, Vector<RefPtr<SharedBuffer>>& pasteboardData) = 0;
+ virtual void requestCandidatesForSelection(const VisibleSelection&) { }
// Notify an input method that a composition was voluntarily discarded by WebCore, so that it could clean up too.
// This function is not called when a composition is closed per a request from an input method.
Modified: trunk/Source/WebKit/mac/ChangeLog (199082 => 199083)
--- trunk/Source/WebKit/mac/ChangeLog 2016-04-05 23:20:34 UTC (rev 199082)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-04-05 23:33:47 UTC (rev 199083)
@@ -1,3 +1,14 @@
+2016-04-05 Beth Dakin <[email protected]>
+
+ Make requestCandidatesForSelection available on any EditorClient
+ https://bugs.webkit.org/show_bug.cgi?id=156253
+ -and corresponding-
+ rdar://problem/24661147
+
+ Reviewed by Dean Jackson.
+
+ * WebCoreSupport/WebEditorClient.h:
+
2016-04-05 Youenn Fablet <[email protected]>
[Fetch API] Add a runtime flag to fetch API and related constructs
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h (199082 => 199083)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h 2016-04-05 23:20:34 UTC (rev 199082)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h 2016-04-05 23:33:47 UTC (rev 199083)
@@ -170,7 +170,7 @@
void requestCheckingOfString(PassRefPtr<WebCore::TextCheckingRequest>, const WebCore::VisibleSelection& currentSelection) override;
#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200
- void requestCandidatesForSelection(const WebCore::VisibleSelection&);
+ void requestCandidatesForSelection(const WebCore::VisibleSelection&) override;
void handleRequestedCandidates(NSInteger, NSArray<NSTextCheckingResult *> *);
void handleAcceptedCandidate(NSTextCheckingResult *);
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
