Title: [199208] trunk/Source/_javascript_Core
- Revision
- 199208
- Author
- [email protected]
- Date
- 2016-04-07 18:27:42 -0700 (Thu, 07 Apr 2016)
Log Message
Remote Inspector: When disallowing remote inspection on a debuggable, a listing is still sent to debuggers
https://bugs.webkit.org/show_bug.cgi?id=156380
<rdar://problem/25323727>
Patch by Joseph Pecoraro <[email protected]> on 2016-04-07
Reviewed by Timothy Hatcher.
* inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::updateTarget):
(Inspector::RemoteInspector::updateAutomaticInspectionCandidate):
When a target has been updated and it no longer generates a listing,
we should remove the old listing as that is now stale and should
not be sent. Not generating a listing means this target is no
longer allowed to be debugged.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (199207 => 199208)
--- trunk/Source/_javascript_Core/ChangeLog 2016-04-08 01:24:47 UTC (rev 199207)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-04-08 01:27:42 UTC (rev 199208)
@@ -1,5 +1,21 @@
2016-04-07 Joseph Pecoraro <[email protected]>
+ Remote Inspector: When disallowing remote inspection on a debuggable, a listing is still sent to debuggers
+ https://bugs.webkit.org/show_bug.cgi?id=156380
+ <rdar://problem/25323727>
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/remote/RemoteInspector.mm:
+ (Inspector::RemoteInspector::updateTarget):
+ (Inspector::RemoteInspector::updateAutomaticInspectionCandidate):
+ When a target has been updated and it no longer generates a listing,
+ we should remove the old listing as that is now stale and should
+ not be sent. Not generating a listing means this target is no
+ longer allowed to be debugged.
+
+2016-04-07 Joseph Pecoraro <[email protected]>
+
Web Inspector: Not necessary to validate webinspectord connection on iOS
https://bugs.webkit.org/show_bug.cgi?id=156377
<rdar://problem/25612460>
Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.mm (199207 => 199208)
--- trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.mm 2016-04-08 01:24:47 UTC (rev 199207)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.mm 2016-04-08 01:27:42 UTC (rev 199208)
@@ -171,8 +171,11 @@
}
// If the target has just allowed remote control, then the listing won't exist yet.
+ // If the target has no identifier remove the old listing.
if (RetainPtr<NSDictionary> targetListing = listingForTarget(*target))
m_targetListingMap.set(targetIdentifier, targetListing);
+ else
+ m_targetListingMap.remove(targetIdentifier);
pushListingsSoon();
}
@@ -191,8 +194,11 @@
ASSERT_UNUSED(result, !result.isNewEntry);
// If the target has just allowed remote control, then the listing won't exist yet.
+ // If the target has no identifier remove the old listing.
if (RetainPtr<NSDictionary> targetListing = listingForTarget(*target))
m_targetListingMap.set(targetIdentifier, targetListing);
+ else
+ m_targetListingMap.remove(targetIdentifier);
// Don't allow automatic inspection unless it is allowed or we are stopped.
if (!m_automaticInspectionEnabled || !m_enabled) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
