Diff
Modified: trunk/Source/WebCore/ChangeLog (199230 => 199231)
--- trunk/Source/WebCore/ChangeLog 2016-04-08 16:57:29 UTC (rev 199230)
+++ trunk/Source/WebCore/ChangeLog 2016-04-08 16:59:35 UTC (rev 199231)
@@ -1,3 +1,28 @@
+2016-04-08 Darin Adler <da...@apple.com>
+
+ Remove 14 more unnecessary uses of UsePointersEvenForNonNullableObjectArguments
+ https://bugs.webkit.org/show_bug.cgi?id=156405
+
+ Reviewed by Chris Dumez.
+
+ * Modules/encryptedmedia/MediaKeySession.idl:
+ * Modules/encryptedmedia/MediaKeys.idl:
+ * dom/Element.idl:
+ * dom/NamedNodeMap.idl:
+ * html/HTMLElement.idl:
+ * html/canvas/OESVertexArrayObject.idl:
+ * html/canvas/WebGLRenderingContext.idl:
+ * page/DOMSelection.idl:
+ * storage/StorageEvent.idl:
+ * svg/SVGSVGElement.idl:
+ * xml/XMLSerializer.idl:
+ * xml/XPathEvaluator.idl:
+ * xml/XPathExpression.idl:
+ * xml/XSLTProcessor.idl:
+ Removed UsePointersEvenForNonNullableObjectArguments, which was having no effect
+ in any of these classes. Also tweaked formatting of some of the IDL, merging things
+ onto single lines, changing paragraphing and indenting a bit, and fixing some typos.
+
2016-04-08 Brady Eidson <beid...@apple.com>
Modern IDB (Blob support): Write blobs to temporary files and move them to the correct location when storing them.
Modified: trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.idl (199230 => 199231)
--- trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.idl 2016-04-08 16:57:29 UTC (rev 199230)
+++ trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.idl 2016-04-08 16:59:35 UTC (rev 199231)
@@ -25,7 +25,6 @@
[
Conditional=ENCRYPTED_MEDIA_V2,
- UsePointersEvenForNonNullableObjectArguments,
InterfaceName=WebKitMediaKeySession,
ActiveDOMObject,
] interface MediaKeySession : EventTarget {
Modified: trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.idl (199230 => 199231)
--- trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.idl 2016-04-08 16:57:29 UTC (rev 199230)
+++ trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.idl 2016-04-08 16:59:35 UTC (rev 199231)
@@ -27,12 +27,9 @@
Conditional=ENCRYPTED_MEDIA_V2,
Constructor(DOMString keySystem),
ConstructorRaisesException,
- UsePointersEvenForNonNullableObjectArguments,
InterfaceName=WebKitMediaKeys,
] interface MediaKeys {
[CallWith=ScriptExecutionContext, RaisesException] MediaKeySession createSession([Default=Undefined] optional DOMString type, [Default=Undefined] optional Uint8Array initData);
-
static boolean isTypeSupported(DOMString keySystem, [Default=NullString] optional DOMString type);
-
readonly attribute DOMString keySystem;
};
Modified: trunk/Source/WebCore/dom/Element.idl (199230 => 199231)
--- trunk/Source/WebCore/dom/Element.idl 2016-04-08 16:57:29 UTC (rev 199230)
+++ trunk/Source/WebCore/dom/Element.idl 2016-04-08 16:59:35 UTC (rev 199231)
@@ -19,7 +19,6 @@
*/
[
- UsePointersEvenForNonNullableObjectArguments,
JSCustomHeader,
JSGenerateToNativeObject,
] interface Element : Node {
@@ -46,8 +45,8 @@
#if !defined(LANGUAGE_OBJECTIVE_C)
// For ObjC this is defined on Node for legacy support.
- readonly attribute NamedNodeMap attributes;
- boolean hasAttributes();
+ readonly attribute NamedNodeMap attributes;
+ boolean hasAttributes();
#endif
// DOM Level 2 Core
@@ -55,8 +54,7 @@
[ObjCLegacyUnnamedParameters] DOMString? getAttributeNS([Default=Undefined] optional DOMString? namespaceURI, [Default=Undefined] optional DOMString localName);
[ObjCLegacyUnnamedParameters, RaisesException, InvokesCustomElementLifecycleCallbacks]
- void setAttributeNS([Default=Undefined] optional DOMString? namespaceURI,
- [Default=Undefined] optional DOMString qualifiedName, [Default=Undefined] optional DOMString value);
+ void setAttributeNS([Default=Undefined] optional DOMString? namespaceURI, [Default=Undefined] optional DOMString qualifiedName, [Default=Undefined] optional DOMString value);
[ObjCLegacyUnnamedParameters, InvokesCustomElementLifecycleCallbacks] void removeAttributeNS(DOMString? namespaceURI, DOMString localName);
Modified: trunk/Source/WebCore/dom/NamedNodeMap.idl (199230 => 199231)
--- trunk/Source/WebCore/dom/NamedNodeMap.idl 2016-04-08 16:57:29 UTC (rev 199230)
+++ trunk/Source/WebCore/dom/NamedNodeMap.idl 2016-04-08 16:59:35 UTC (rev 199231)
@@ -19,28 +19,19 @@
*/
[
- UsePointersEvenForNonNullableObjectArguments,
GenerateIsReachable=ImplElementRoot,
ImplementationLacksVTable,
] interface NamedNodeMap {
getter Node getNamedItem([Default=Undefined] optional DOMString name);
-
[RaisesException] Node setNamedItem([Default=Undefined] optional Node node);
-
[RaisesException] Node removeNamedItem([Default=Undefined] optional DOMString name);
-
getter Node item([Default=Undefined] optional unsigned long index);
-
readonly attribute unsigned long length;
-
// Introduced in DOM Level 2:
[ObjCLegacyUnnamedParameters] Node getNamedItemNS([Default=Undefined] optional DOMString? namespaceURI, [Default=Undefined] optional DOMString localName);
-
[RaisesException] Node setNamedItemNS([Default=Undefined] optional Node node);
-
[ObjCLegacyUnnamedParameters, RaisesException] Node removeNamedItemNS([Default=Undefined] optional DOMString? namespaceURI, [Default=Undefined] optional DOMString localName);
};
-
Modified: trunk/Source/WebCore/html/HTMLElement.idl (199230 => 199231)
--- trunk/Source/WebCore/html/HTMLElement.idl 2016-04-08 16:57:29 UTC (rev 199230)
+++ trunk/Source/WebCore/html/HTMLElement.idl 2016-04-08 16:59:35 UTC (rev 199231)
@@ -22,58 +22,46 @@
#if defined(ENABLE_CUSTOM_ELEMENTS) && ENABLE_CUSTOM_ELEMENTS
CustomConstructor(),
#endif
- UsePointersEvenForNonNullableObjectArguments,
JSGenerateToNativeObject,
JSCustomPushEventHandlerScope,
] interface HTMLElement : Element {
-#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
- // FIXME: id should be moved to Element for ObjC as well.
- [Reflect] attribute DOMString id;
-#endif
- [Reflect] attribute DOMString title;
- [Reflect] attribute DOMString lang;
- attribute boolean translate;
- attribute DOMString dir;
+ [Reflect] attribute DOMString title;
+ [Reflect] attribute DOMString lang;
+ attribute boolean translate;
+ attribute DOMString dir;
- attribute long tabIndex;
- attribute boolean draggable;
+ attribute long tabIndex;
+ attribute boolean draggable;
- [Reflect] attribute DOMString webkitdropzone;
- // FIXME: Support the standard HTML equivalent.
- // [PutForwards=value] readonly attribute DOMTokenList dropzone;
+ [Reflect] attribute DOMString webkitdropzone;
+ // FIXME: Support the standard HTML equivalent.
+ // [PutForwards=value] readonly attribute DOMTokenList dropzone;
- [Reflect] attribute boolean hidden;
- [Reflect] attribute DOMString accessKey;
+ [Reflect] attribute boolean hidden;
+ [Reflect] attribute DOMString accessKey;
- // Extensions
[TreatNullAs=EmptyString, SetterRaisesException] attribute DOMString innerText;
[TreatNullAs=EmptyString, SetterRaisesException] attribute DOMString outerText;
- [RaisesException] Element insertAdjacentElement([Default=Undefined] optional DOMString where,
- [Default=Undefined] optional Element element);
- [RaisesException] void insertAdjacentHTML([Default=Undefined] optional DOMString where,
- [Default=Undefined] optional DOMString html);
- [RaisesException] void insertAdjacentText([Default=Undefined] optional DOMString where,
- [Default=Undefined] optional DOMString text);
+ [RaisesException] Element insertAdjacentElement([Default=Undefined] optional DOMString where, [Default=Undefined] optional Element element);
+ [RaisesException] void insertAdjacentHTML([Default=Undefined] optional DOMString where, [Default=Undefined] optional DOMString html);
+ [RaisesException] void insertAdjacentText([Default=Undefined] optional DOMString where, [Default=Undefined] optional DOMString text);
-#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
- readonly attribute HTMLCollection children;
-#endif
-
[SetterRaisesException] attribute DOMString contentEditable;
readonly attribute boolean isContentEditable;
- attribute boolean spellcheck;
+ attribute boolean spellcheck;
-#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
- readonly attribute DOMString titleDisplayString;
-#endif
-
void click();
#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
void focus();
void blur();
#endif
-};
+#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
+ [Reflect] attribute DOMString id;
+ readonly attribute HTMLCollection children;
+ readonly attribute DOMString titleDisplayString;
+#endif
+};
Modified: trunk/Source/WebCore/html/canvas/OESVertexArrayObject.idl (199230 => 199231)
--- trunk/Source/WebCore/html/canvas/OESVertexArrayObject.idl 2016-04-08 16:57:29 UTC (rev 199230)
+++ trunk/Source/WebCore/html/canvas/OESVertexArrayObject.idl 2016-04-08 16:59:35 UTC (rev 199231)
@@ -25,7 +25,6 @@
[
Conditional=WEBGL,
- UsePointersEvenForNonNullableObjectArguments,
DoNotCheckConstants,
GenerateIsReachable=ImplWebGLRenderingContext,
NoInterfaceObject,
@@ -33,7 +32,7 @@
const unsigned int VERTEX_ARRAY_BINDING_OES = 0x85B5;
[StrictTypeChecking] WebGLVertexArrayObjectOES createVertexArrayOES();
- [StrictTypeChecking] void deleteVertexArrayOES([Default=Undefined] optional WebGLVertexArrayObjectOES arrayObject);
- [StrictTypeChecking] boolean isVertexArrayOES([Default=Undefined] optional WebGLVertexArrayObjectOES arrayObject);
- [StrictTypeChecking, RaisesException] void bindVertexArrayOES([Default=Undefined] optional WebGLVertexArrayObjectOES arrayObject);
+ [StrictTypeChecking] void deleteVertexArrayOES([Default=Undefined] optional WebGLVertexArrayObjectOES arrayObject);
+ [StrictTypeChecking] boolean isVertexArrayOES([Default=Undefined] optional WebGLVertexArrayObjectOES arrayObject);
+ [StrictTypeChecking, RaisesException] void bindVertexArrayOES([Default=Undefined] optional WebGLVertexArrayObjectOES arrayObject);
};
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.idl (199230 => 199231)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.idl 2016-04-08 16:57:29 UTC (rev 199230)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.idl 2016-04-08 16:59:35 UTC (rev 199231)
@@ -27,6 +27,5 @@
Conditional=WEBGL,
JSCustomMarkFunction,
DoNotCheckConstants,
- UsePointersEvenForNonNullableObjectArguments,
] interface WebGLRenderingContext : WebGLRenderingContextBase {
};
Modified: trunk/Source/WebCore/page/DOMSelection.idl (199230 => 199231)
--- trunk/Source/WebCore/page/DOMSelection.idl 2016-04-08 16:57:29 UTC (rev 199230)
+++ trunk/Source/WebCore/page/DOMSelection.idl 2016-04-08 16:59:35 UTC (rev 199231)
@@ -30,7 +30,6 @@
// This is based off of Mozilla's Selection interface
// https://developer.mozilla.org/En/DOM/Selection
[
- UsePointersEvenForNonNullableObjectArguments,
GenerateIsReachable=ImplFrame,
InterfaceName=Selection,
] interface DOMSelection {
@@ -42,18 +41,15 @@
readonly attribute boolean isCollapsed;
readonly attribute long rangeCount;
- [RaisesException] void collapse([Default=Undefined] optional Node node,
- [Default=Undefined] optional long index);
+ [RaisesException] void collapse([Default=Undefined] optional Node node, [Default=Undefined] optional long index);
[RaisesException] void collapseToEnd();
[RaisesException] void collapseToStart();
void deleteFromDocument();
- boolean containsNode([Default=Undefined] optional Node node,
- [Default=Undefined] optional boolean allowPartial);
+ boolean containsNode([Default=Undefined] optional Node node, [Default=Undefined] optional boolean allowPartial);
[RaisesException] void selectAllChildren([Default=Undefined] optional Node node);
- [RaisesException] void extend([Default=Undefined] optional Node node,
- [Default=Undefined] optional long offset);
+ [RaisesException] void extend([Default=Undefined] optional Node node, [Default=Undefined] optional long offset);
[RaisesException] Range getRangeAt([Default=Undefined] optional long index);
void removeAllRanges();
@@ -73,17 +69,11 @@
// IE's type accessor returns "none", "text" and "control"
readonly attribute DOMString type;
- void modify([Default=Undefined] optional DOMString alter,
- [Default=Undefined] optional DOMString direction,
- [Default=Undefined] optional DOMString granularity);
- [RaisesException] void setBaseAndExtent([Default=Undefined] optional Node baseNode,
- [Default=Undefined] optional long baseOffset,
- [Default=Undefined] optional Node extentNode,
- [Default=Undefined] optional long extentOffset);
- [RaisesException] void setPosition([Default=Undefined] optional Node node,
- [Default=Undefined] optional long offset);
+ void modify([Default=Undefined] optional DOMString alter, [Default=Undefined] optional DOMString direction, [Default=Undefined] optional DOMString granularity);
+ [RaisesException] void setBaseAndExtent([Default=Undefined] optional Node baseNode, [Default=Undefined] optional long baseOffset, [Default=Undefined] optional Node extentNode, [Default=Undefined] optional long extentOffset);
+ [RaisesException] void setPosition([Default=Undefined] optional Node node, [Default=Undefined] optional long offset);
- // IE extentions
+ // IE extension
// http://msdn.microsoft.com/en-us/library/ms535869(VS.85).aspx
void empty();
};
Modified: trunk/Source/WebCore/storage/StorageEvent.idl (199230 => 199231)
--- trunk/Source/WebCore/storage/StorageEvent.idl 2016-04-08 16:57:29 UTC (rev 199230)
+++ trunk/Source/WebCore/storage/StorageEvent.idl 2016-04-08 16:59:35 UTC (rev 199231)
@@ -25,7 +25,6 @@
[
ConstructorTemplate=Event,
- UsePointersEvenForNonNullableObjectArguments,
] interface StorageEvent : Event {
[InitializedByEventConstructor] readonly attribute DOMString key;
[InitializedByEventConstructor] readonly attribute DOMString? oldValue;
Modified: trunk/Source/WebCore/svg/SVGGraphicsElement.idl (199230 => 199231)
--- trunk/Source/WebCore/svg/SVGGraphicsElement.idl 2016-04-08 16:57:29 UTC (rev 199230)
+++ trunk/Source/WebCore/svg/SVGGraphicsElement.idl 2016-04-08 16:59:35 UTC (rev 199231)
@@ -22,15 +22,14 @@
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-[
- UsePointersEvenForNonNullableObjectArguments,
-] interface SVGGraphicsElement : SVGElement {
+
+interface SVGGraphicsElement : SVGElement {
readonly attribute SVGAnimatedTransformList transform;
readonly attribute SVGElement nearestViewportElement;
readonly attribute SVGElement farthestViewportElement;
- SVGRect getBBox();
+ SVGRect getBBox();
SVGMatrix getCTM();
SVGMatrix getScreenCTM();
[RaisesException] SVGMatrix getTransformToElement([Default=Undefined] optional SVGElement element);
Modified: trunk/Source/WebCore/svg/SVGSVGElement.idl (199230 => 199231)
--- trunk/Source/WebCore/svg/SVGSVGElement.idl 2016-04-08 16:57:29 UTC (rev 199230)
+++ trunk/Source/WebCore/svg/SVGSVGElement.idl 2016-04-08 16:59:35 UTC (rev 199231)
@@ -20,18 +20,17 @@
* Boston, MA 02110-1301, USA.
*/
-// TODO: no css::ViewCSS available!
-// TODO: Fix SVGSVGElement inheritance (css::DocumentCSS)!
-// TODO: no events::DocumentEvent available!
-[
- UsePointersEvenForNonNullableObjectArguments,
-] interface SVGSVGElement : SVGGraphicsElement {
+// FIXME: no css::ViewCSS available!
+// FIXME: Fix SVGSVGElement inheritance (css::DocumentCSS)!
+// FIXME: no events::DocumentEvent available!
+
+interface SVGSVGElement : SVGGraphicsElement {
readonly attribute SVGAnimatedLength x;
readonly attribute SVGAnimatedLength y;
readonly attribute SVGAnimatedLength width;
readonly attribute SVGAnimatedLength height;
- attribute DOMString contentScriptType;
- attribute DOMString contentStyleType;
+ attribute DOMString contentScriptType;
+ attribute DOMString contentStyleType;
readonly attribute SVGRect viewport;
readonly attribute unrestricted float pixelUnitToMillimeterX;
readonly attribute unrestricted float pixelUnitToMillimeterY;
@@ -39,7 +38,7 @@
readonly attribute unrestricted float screenPixelToMillimeterY;
readonly attribute boolean useCurrentView;
readonly attribute SVGViewSpec currentView;
- attribute unrestricted float currentScale;
+ attribute unrestricted float currentScale;
readonly attribute SVGPoint currentTranslate;
unsigned long suspendRedraw([Default=Undefined] optional unsigned long maxWaitMilliseconds);
@@ -51,14 +50,10 @@
boolean animationsPaused();
unrestricted float getCurrentTime();
void setCurrentTime([Default=Undefined] optional unrestricted float seconds);
- NodeList getIntersectionList([Default=Undefined] optional SVGRect rect,
- [Default=Undefined] optional SVGElement referenceElement);
- NodeList getEnclosureList([Default=Undefined] optional SVGRect rect,
- [Default=Undefined] optional SVGElement referenceElement);
- boolean checkIntersection([Default=Undefined] optional SVGElement element,
- [Default=Undefined] optional SVGRect rect);
- boolean checkEnclosure([Default=Undefined] optional SVGElement element,
- [Default=Undefined] optional SVGRect rect);
+ NodeList getIntersectionList([Default=Undefined] optional SVGRect rect, [Default=Undefined] optional SVGElement referenceElement);
+ NodeList getEnclosureList([Default=Undefined] optional SVGRect rect, [Default=Undefined] optional SVGElement referenceElement);
+ boolean checkIntersection([Default=Undefined] optional SVGElement element, [Default=Undefined] optional SVGRect rect);
+ boolean checkEnclosure([Default=Undefined] optional SVGElement element, [Default=Undefined] optional SVGRect rect);
void deselectAll();
SVGNumber createSVGNumber();
Modified: trunk/Source/WebCore/xml/XMLSerializer.idl (199230 => 199231)
--- trunk/Source/WebCore/xml/XMLSerializer.idl 2016-04-08 16:57:29 UTC (rev 199230)
+++ trunk/Source/WebCore/xml/XMLSerializer.idl 2016-04-08 16:59:35 UTC (rev 199231)
@@ -20,7 +20,6 @@
[
Constructor,
- UsePointersEvenForNonNullableObjectArguments,
ImplementationLacksVTable,
] interface XMLSerializer {
[RaisesException] DOMString serializeToString([Default=Undefined] optional Node node);
Modified: trunk/Source/WebCore/xml/XPathEvaluator.idl (199230 => 199231)
--- trunk/Source/WebCore/xml/XPathEvaluator.idl 2016-04-08 16:57:29 UTC (rev 199230)
+++ trunk/Source/WebCore/xml/XPathEvaluator.idl 2016-04-08 16:59:35 UTC (rev 199231)
@@ -19,7 +19,6 @@
[
Constructor,
- UsePointersEvenForNonNullableObjectArguments,
ImplementationLacksVTable,
] interface XPathEvaluator {
[RaisesException] XPathExpression createExpression([Default=Undefined] optional DOMString _expression_,
Modified: trunk/Source/WebCore/xml/XPathExpression.idl (199230 => 199231)
--- trunk/Source/WebCore/xml/XPathExpression.idl 2016-04-08 16:57:29 UTC (rev 199230)
+++ trunk/Source/WebCore/xml/XPathExpression.idl 2016-04-08 16:59:35 UTC (rev 199231)
@@ -18,11 +18,8 @@
* Boston, MA 02110-1301, USA.
*/
[
- UsePointersEvenForNonNullableObjectArguments,
ImplementationLacksVTable,
] interface XPathExpression {
- [ObjCLegacyUnnamedParameters, RaisesException] XPathResult evaluate([Default=Undefined] optional Node contextNode,
- [Default=Undefined] optional unsigned short type,
- [Default=Undefined] optional XPathResult inResult);
+ [ObjCLegacyUnnamedParameters, RaisesException] XPathResult evaluate([Default=Undefined] optional Node contextNode, [Default=Undefined] optional unsigned short type, [Default=Undefined] optional XPathResult inResult);
};
Modified: trunk/Source/WebCore/xml/XSLTProcessor.idl (199230 => 199231)
--- trunk/Source/WebCore/xml/XSLTProcessor.idl 2016-04-08 16:57:29 UTC (rev 199230)
+++ trunk/Source/WebCore/xml/XSLTProcessor.idl 2016-04-08 16:59:35 UTC (rev 199231)
@@ -33,7 +33,6 @@
[
Conditional=XSLT,
Constructor,
- UsePointersEvenForNonNullableObjectArguments,
ImplementationLacksVTable,
] interface XSLTProcessor {
