Title: [199389] trunk/Source/_javascript_Core
- Revision
- 199389
- Author
- fpi...@apple.com
- Date
- 2016-04-12 14:10:27 -0700 (Tue, 12 Apr 2016)
Log Message
Unreviewed, remove FIXME for https://bugs.webkit.org/show_bug.cgi?id=156457 and replace it
with a comment that describes what we do now.
* bytecode/PolymorphicAccess.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (199388 => 199389)
--- trunk/Source/_javascript_Core/ChangeLog 2016-04-12 21:04:09 UTC (rev 199388)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-04-12 21:10:27 UTC (rev 199389)
@@ -1,3 +1,10 @@
+2016-04-12 Filip Pizlo <fpi...@apple.com>
+
+ Unreviewed, remove FIXME for https://bugs.webkit.org/show_bug.cgi?id=156457 and replace it
+ with a comment that describes what we do now.
+
+ * bytecode/PolymorphicAccess.h:
+
2016-04-12 Saam barati <sbar...@apple.com>
isLocked() assertion broke builds because ConcurrentJITLock isn't always a real lock.
Modified: trunk/Source/_javascript_Core/bytecode/PolymorphicAccess.h (199388 => 199389)
--- trunk/Source/_javascript_Core/bytecode/PolymorphicAccess.h 2016-04-12 21:04:09 UTC (rev 199388)
+++ trunk/Source/_javascript_Core/bytecode/PolymorphicAccess.h 2016-04-12 21:10:27 UTC (rev 199389)
@@ -84,10 +84,9 @@
//
// An AccessCase may be destroyed while in any of these states.
//
-// Note that right now, an AccessCase goes from Primordial to Generated quite quickly.
-// FIXME: Make it possible for PolymorphicAccess to hold onto AccessCases that haven't been
-// generated. That would allow us to significantly reduce the number of regeneration events.
-// https://bugs.webkit.org/show_bug.cgi?id=156457
+// We will sometimes buffer committed AccessCases in the PolymorphicAccess object before generating
+// code. This allows us to only regenerate once we've accumulated (hopefully) more than one new
+// AccessCase.
class AccessCase {
WTF_MAKE_NONCOPYABLE(AccessCase);
WTF_MAKE_FAST_ALLOCATED;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
