Title: [199653] trunk/Tools
- Revision
- 199653
- Author
- [email protected]
- Date
- 2016-04-18 00:40:22 -0700 (Mon, 18 Apr 2016)
Log Message
[GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=156621
Reviewed by Martin Robinson.
This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows
scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to
simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not.
* TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
(testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (199652 => 199653)
--- trunk/Tools/ChangeLog 2016-04-18 07:35:48 UTC (rev 199652)
+++ trunk/Tools/ChangeLog 2016-04-18 07:40:22 UTC (rev 199653)
@@ -1,3 +1,17 @@
+2016-04-18 Carlos Garcia Campos <[email protected]>
+
+ [GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars
+ https://bugs.webkit.org/show_bug.cgi?id=156621
+
+ Reviewed by Martin Robinson.
+
+ This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows
+ scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to
+ simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not.
+
+ * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
+ (testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test.
+
2016-04-17 Gyuyoung Kim <[email protected]>
[EFL] Bump gstreamer from 1.4.4 to 1.6.3
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp (199652 => 199653)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp 2016-04-18 07:35:48 UTC (rev 199652)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp 2016-04-18 07:40:22 UTC (rev 199653)
@@ -614,7 +614,6 @@
" <img style='position:absolute; left:1; top:10' src='' width=5 height=5></img>"
" <a style='position:absolute; left:1; top:20' href='' title='WebKitGTK+ Logo'><img src='' width=5 height=5></img></a>"
" <input style='position:absolute; left:1; top:30' size='10'></input>"
- " <div style='position:absolute; left:1; top:50; width:30; height:30; overflow:scroll'> </div>"
" <video style='position:absolute; left:1; top:100' width='300' height='300' controls='controls' preload='none'><source src='' type='video/ogg' /></video>"
" <p style='position:absolute; left:1; top:120' id='text_to_select'>Lorem ipsum.</p>"
"</body></html>";
@@ -690,7 +689,7 @@
g_assert(!test->m_mouseTargetModifiers);
// Move over scrollbar.
- hitTestResult = test->moveMouseAndWaitUntilMouseTargetChanged(5, 75);
+ hitTestResult = test->moveMouseAndWaitUntilMouseTargetChanged(gtk_widget_get_allocated_width(GTK_WIDGET(test->m_webView)) - 4, 5);
g_assert(!webkit_hit_test_result_context_is_link(hitTestResult));
g_assert(!webkit_hit_test_result_context_is_image(hitTestResult));
g_assert(!webkit_hit_test_result_context_is_media(hitTestResult));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
