Title: [199918] trunk/Source/_javascript_Core
- Revision
- 199918
- Author
- fpi...@apple.com
- Date
- 2016-04-22 15:46:18 -0700 (Fri, 22 Apr 2016)
Log Message
ASSERT(m_stack.last().isTailDeleted) at ShadowChicken.cpp:127 inspecting the inspector
https://bugs.webkit.org/show_bug.cgi?id=156930
Reviewed by Joseph Pecoraro.
The loop that prunes the stack from the top should preserve the invariant that the top frame
cannot be tail-deleted.
* interpreter/ShadowChicken.cpp:
(JSC::ShadowChicken::update):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (199917 => 199918)
--- trunk/Source/_javascript_Core/ChangeLog 2016-04-22 22:41:49 UTC (rev 199917)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-04-22 22:46:18 UTC (rev 199918)
@@ -1,3 +1,16 @@
+2016-04-22 Filip Pizlo <fpi...@apple.com>
+
+ ASSERT(m_stack.last().isTailDeleted) at ShadowChicken.cpp:127 inspecting the inspector
+ https://bugs.webkit.org/show_bug.cgi?id=156930
+
+ Reviewed by Joseph Pecoraro.
+
+ The loop that prunes the stack from the top should preserve the invariant that the top frame
+ cannot be tail-deleted.
+
+ * interpreter/ShadowChicken.cpp:
+ (JSC::ShadowChicken::update):
+
2016-04-22 Benjamin Poulain <benja...@webkit.org>
Attempt to fix the CLoop after r199866
Modified: trunk/Source/_javascript_Core/interpreter/ShadowChicken.cpp (199917 => 199918)
--- trunk/Source/_javascript_Core/interpreter/ShadowChicken.cpp 2016-04-22 22:41:49 UTC (rev 199917)
+++ trunk/Source/_javascript_Core/interpreter/ShadowChicken.cpp 2016-04-22 22:46:18 UTC (rev 199918)
@@ -114,7 +114,7 @@
if (verbose)
dataLog(" Highest point since last time: ", RawPointer(highestPointSinceLastTime), "\n");
- while (!m_stack.isEmpty() && m_stack.last().frame < highestPointSinceLastTime)
+ while (!m_stack.isEmpty() && (m_stack.last().frame < highestPointSinceLastTime || m_stack.last().isTailDeleted))
m_stack.removeLast();
if (verbose)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
